Received-SPF: pass (google.com: domain of linux-kernel+bounces-12149-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 27 Dec 2023 18:50:00 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, conor+dt@kernel.org, krzysztof.kozlowski@linaro.org,
	robh+dt@kernel.org, kevin-lu@ti.com, baojun.xu@ti.com,
	devicetree@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz,
	pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	liam.r.girdwood@intel.com, soyer@irl.hu, tiwai@suse.de,
	peeyush@ti.com, navada@ti.com
Subject: Re: [PATCH v3 2/5] ASoC: tas2562: move tas2563 from tas2562 driver
 to tas2781 driver
Message-ID: <ZYxVuGwyw1ZA3XBv@smile.fi.intel.com>
References: <20231225053932.1138-1-shenghao-ding@ti.com>
 <20231225053932.1138-2-shenghao-ding@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231225053932.1138-2-shenghao-ding@ti.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Mon, Dec 25, 2023 at 01:39:28PM +0800, Shenghao Ding wrote:
> Move tas2563 from tas2562 driver to tas2781 driver, because tas2563 only
> work in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode
> for tas2563, it has been moved to tas2781 driver. As to the hardware part,
> such as register setting and DSP firmware, all these are stored in the
> binary firmware. What tas2781 drivder dooes is to parse the firmware and
> download them to the tas2781 or tas2563, then power on tas2781 or tas2563.
> So, tas2781 driver can be resued as tas2563 driver。 Only attention will
> be paid to downloading corresponding firmware.

I dunno if you got my emails, but my comments were completely ignored.
You can't do this patch as after it the current users may have a regression.

-- 
With Best Regards,
Andy Shevchenko