Received-SPF: pass (google.com: domain of linux-kernel+bounces-12153-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 27 Dec 2023 18:56:45 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Yang Yingliang <yangyingliang@huawei.com>,
	LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr
Subject: Re: [PATCH] mmc: mmc_spi: Adjust error handling in mmc_spi_probe()
Message-ID: <ZYxXTVpLfI-mgxF4@smile.fi.intel.com>
References: <2aa6bd31-f3d8-41ac-abf1-9ec7cf7e064b@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2aa6bd31-f3d8-41ac-abf1-9ec7cf7e064b@web.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, Dec 27, 2023 at 12:50:50PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 27 Dec 2023 12:23:20 +0100
> 
> The kfree() function was called in one case by
> the mmc_spi_probe() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.

> * Thus return directly after a call of the function “kmalloc” failed
>   at the beginning.
> 
> * Move an error code assignment into an if branch.

How is this one better?

-- 
With Best Regards,
Andy Shevchenko