Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp3506376rdb; Wed, 27 Dec 2023 09:26:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IFt4bpMXyGXLBBfV37hr5p0RtzfNqSvA3ixjixqLrYEK77PW8IuK+cdUll1ZgS0I5UivgIh X-Received: by 2002:a05:622a:3ce:b0:427:737d:962a with SMTP id k14-20020a05622a03ce00b00427737d962amr12649614qtx.133.1703698000577; Wed, 27 Dec 2023 09:26:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703698000; cv=none; d=google.com; s=arc-20160816; b=JN6dpyj7o1yENd5CSziHs4FRFKFqMbXmTZmlpK6I7URoySDiofdipZMLRKef1XQuEo kh2Gvk5fq/AiHtku35uDxhQfIo4+mXKrI35uSU4d/rD1zSI0I1e+X94aBd393JxXx6LM F8cXrCI5XAuZw1XUv2ehaiwuPCIYC+4gsyuT0o+YVd3RVbW+akhBffDY79NvYk6fl6mD +enU7lifJKblCJ6+B6D31wyh3YWy2YOuK5XJV4rktcu6yAgdEv+AwUkRuPe+qZ13t6k6 dxtN3uHbyhWaif8CwHh3DuVswubYB4rNS3B0bjRr9y4WF7WElEulKopIBePq5aBkUzB1 rJOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=EqxyxjAfxK7CriVkAAYqyPBfpXiRQg2SI5yDHGPTm6s=; fh=kOU6zGcwt6mv8FHTaM0YWInKgJZg5Ip/mgCGBiDXS/4=; b=0Z2AG/YiGv0jon0Dak5N27XvcXDyPO7Gq1XtL/gDcVa17i6ABQ4Ot0wJvOJ6DyheAI fwCFVQ5vHfLOWJ/Gf6OC59hfDznam5J/pCzcWD5jYr82m0RhCvOFGMUhEfvZAOt13Bqq pJJ4NBpDbhQI+Hhgh5Hd11kNSHPcFr/g/VLs+0sC1+0ivlRORJg2niSpCS/bJP9geNIN k4Nq6AVYvAx0St4GgbWk+FCSBa5n6PPMulSxdKHmMtTgBX1nhRf53YPmZN8utQro1Rnh UueDqfTpowR+GdtVfz0uIqgeSdferIZNh9XyoPSabTWKROqKSqz42NWfsstSYsr01EFR Jr5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fbmnqlA+; spf=pass (google.com: domain of linux-kernel+bounces-12170-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12170-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id bp35-20020a05622a1ba300b00425da7bbf14si14497685qtb.641.2023.12.27.09.26.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 09:26:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12170-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fbmnqlA+; spf=pass (google.com: domain of linux-kernel+bounces-12170-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12170-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5382B1C210F9 for ; Wed, 27 Dec 2023 17:26:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DC56C46522; Wed, 27 Dec 2023 17:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fbmnqlA+" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDEEF45BE0; Wed, 27 Dec 2023 17:26:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703697991; x=1735233991; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hlkUwbDWvK8KsZE8U1/eeGcZHCBPmwFQ/HYeIrknmxY=; b=fbmnqlA+bmug7VF5vKk1BUWiGM3kGSwGu93Mf3VHpFfhETgqsrhaGHHH NnuL2fFxERh4z1+E7EpOksoq7kEmKcpR56doMGryAI3c7S0Swve8VwrPA dX9dLOA2qzKte0bKBApt0PdFJGGQCLb61LqGG+RwjjVFOVVBWPcogRAZp IDdM6IRfJ9HkP1X9YZJM+A2nxz0oEJtBmvHURkffH2zwP2bxy0qduGeMA m92OpqrKpczue9r22pv2rr8U068IQT/pqhSFcfx+0x44GVzyGBH7nG4Lh qOFtJpFrDdJGYzHQAZqYnf4qdJ0uU3f2j2uq6MkLz+kFSHPzd7i6klKGr g==; X-IronPort-AV: E=McAfee;i="6600,9927,10936"; a="400280270" X-IronPort-AV: E=Sophos;i="6.04,309,1695711600"; d="scan'208";a="400280270" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2023 09:26:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10936"; a="901732654" X-IronPort-AV: E=Sophos;i="6.04,309,1695711600"; d="scan'208";a="901732654" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2023 09:26:27 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rIXfk-00000009TUR-1WNu; Wed, 27 Dec 2023 19:26:24 +0200 Date: Wed, 27 Dec 2023 19:26:24 +0200 From: Andy Shevchenko To: Mark Hasemeyer Cc: LKML , AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , Konrad Dybcio , Sudeep Holla , Raul Rangel , Tzung-Bi Shih , Sakari Ailus , Daniel Scally , Greg Kroah-Hartman , Heikki Krogerus , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org Subject: Re: [PATCH v3 22/24] device property: Update functions to use EXPORT_SYMBOL_GPL Message-ID: References: <20231226192149.1830592-1-markhas@chromium.org> <20231226122113.v3.22.I186bc5737c5ac4c3a5a7a91e9ec75645e723ca7b@changeid> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231226122113.v3.22.I186bc5737c5ac4c3a5a7a91e9ec75645e723ca7b@changeid> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Dec 26, 2023 at 12:21:26PM -0700, Mark Hasemeyer wrote: > Some of the exported functions use EXPORT_SYMBOL instead of EXPORT_SYMBOL() > EXPORT_SYMBOL_GPL and are inconsistent with the other exported functions EXPORT_SYMBOL_GPL() > in the module. The underlying APCI/OF struct fwnode_operations > implementations are also exported via EXPORT_SYMBOL_GPL. EXPORT_SYMBOL_GPL() > Update them to use the EXPORT_SYMBOL_GPL macro. EXPORT_SYMBOL_GPL() ... With the above fixed, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko