Received-SPF: pass (google.com: domain of linux-kernel+bounces-12182-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 27 Dec 2023 19:39:28 +0200
From: Petre Rodan <petre.rodan@subdimension.ro>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andreas Klinger <ak@it-klinger.de>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Angel Iglesias <ang.iglesiasg@gmail.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v2 07/10] iio: pressure: mprls0025pa.c whitespace cleanup
Message-ID: <ZYxhUJlAb63wRJE-@sunspire>
References: <20231224143500.10940-1-petre.rodan@subdimension.ro>
 <20231224143500.10940-8-petre.rodan@subdimension.ro>
 <ZYxSERlEAfwWpqWP@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="9UdEwOF5KbXOTqo7"
Content-Disposition: inline
In-Reply-To: <ZYxSERlEAfwWpqWP@smile.fi.intel.com>


--9UdEwOF5KbXOTqo7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 27, 2023 at 06:34:25PM +0200, Andy Shevchenko wrote:
> On Sun, Dec 24, 2023 at 04:34:52PM +0200, Petre Rodan wrote:
> > Fix indentation and whitespace in code that will not get refactored.
> >=20
> > Make URL inside comment copy-paste friendly.
>=20
> >  			return dev_err_probe(dev, ret,
> > -				"honeywell,pmin-pascal could not be read\n");
> > +				   "honeywell,pmin-pascal could not be read\n");
>=20
> As done elsewhere, here and in other similar places fix the indentation
> by making first character on the latter line to be in the same column as
> the first character after the opening parenthesis.

I triple-checked that I am following the max 80 column rule, the parenthesis
rule and the 'do not split printk messages' rules in all my code in these 1=
0 patches.
precisely so I don't get feedback like this one.
if the parenthesis rule makes the line longer then 80 chars I right-align to
column 80 as seen above.
that is what I understand from the latest coding style document and that is=
 what
I will follow.

in this particular case if I were to ignore the 80 column rule we would end=
 up on
column 90 if I were to follow your feedback (open parenthesis is at column =
45
and the error takes 45 chars more).

peter


--9UdEwOF5KbXOTqo7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE2Ap/wXYVGTXsPl+pzyaZmYROfzAFAmWMYUwACgkQzyaZmYRO
fzDlsw/6AxQVmVvwyqrKyaMsIwfXxZtjIVhHGrQgzvXJJ5DAEJCtRCnFNCx95Igx
DXGqt0uyLZbhCtl7zi6oPrRKx8mtZPetQCNMJRn3fuYOwQd+yjJ35tMo7ZjAzWj+
b+z1nPSvlGOW+TbyNy5xW3tGnR5t2BatKn/WaZlbf1CAhdwAYvXzKNkg2DLxCHBR
P1hPWa3zaSr5c9vXewjpC56tgRx2CVbxxMusXZSm3Ertu45guHWGMP93rMhZPwUR
GHRJUc39GdKQrIRl6RxVVq8r3Bprvgt7pIQ7oij4+xpXlfd4dVriCu270rHq6Poj
cJ64F1TwkWA/P4SF/dnRsgRRxFatVDa9fQv462TCUjChe8/vla+1/4VKvoBiLgnC
QHsHzbS7x2FWXonjZHHQlCbkSfzYlIpHv0vNg1wJ3ZqVFGz+T3fP/WQwDQo5TL+Z
safXwZSWo/Vtet1000ADWr2r/gau3TS2eZKSXZ0NQMNgs2Q1ayst6id/f24qpTYy
vyvAWLZCmqByLagz4l67fKky8VqnOoN/w7f6TH0u/FB2Vg/HTjfRr4qVvn6YQmtZ
5fqOzbabVaAWdFBd0Aq7Yy1mDisDbxxPML190547u0f0dyDXj7FONewG6Zl9YhRN
Mjc0uCxiJYZH+yQMeuUB8l3nuhRxSzsbifdsql5muS6ThjK6pto=
=p8mw
-----END PGP SIGNATURE-----

--9UdEwOF5KbXOTqo7--