Received-SPF: pass (google.com: domain of linux-kernel+bounces-12184-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 27 Dec 2023 19:40:40 +0200
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Ulf Hansson <ulf.hansson@linaro.org>, Joel Stanley <joel@jms.id.au>,
	Walker Chen <walker.chen@starfivetech.com>,
	Jonathan =?iso-8859-1?Q?Neusch=E4fer?= <j.neuschaefer@gmx.net>,
	Huisong Li <lihuisong@huawei.com>, Arnd Bergmann <arnd@arndb.de>,
	Wei Xu <xuwei5@hisilicon.com>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexander Sverdlin <alexander.sverdlin@gmail.com>,
	Hal Feng <hal.feng@starfivetech.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 08/40] soc: Add SoC driver for Cirrus ep93xx
Message-ID: <ZYxhmDlShZG23u-Y@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo


On Sat, Dec 23, 2023 at 01:06:04PM +0300, Nikita Shubin wrote:
> On Wed, 2023-12-13 at 20:37 +0200, Andy Shevchenko wrote:
> > On Tue, Dec 12, 2023 at 11:20:25AM +0300, Nikita Shubin wrote:

...

> > > +???????dev_info(dev, "EP93xx SoC revision %s\n", attrs->revision);
> > 
> > Hmm... Is this message anyhow useful?
> 
> Can we keep it please ? It makes us happy when we see it in logs for
> historical reasons - it's been there since 2.4.

Maybe it's good to add in the comment area / cover letter why this is useful.

-- 
With Best Regards,
Andy Shevchenko