Received-SPF: pass (google.com: domain of linux-kernel+bounces-12185-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 27 Dec 2023 19:41:21 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, conor+dt@kernel.org, krzysztof.kozlowski@linaro.org,
	robh+dt@kernel.org, kevin-lu@ti.com, baojun.xu@ti.com,
	devicetree@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz,
	pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	liam.r.girdwood@intel.com, soyer@irl.hu, tiwai@suse.de,
	peeyush@ti.com, navada@ti.com
Subject: Re: [PATCH v3 3/5] ASoC: tas2781: Add tas2563 into header file for
 DSP mode
Message-ID: <ZYxhwW97kFu1pp6p@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo


On Mon, Dec 25, 2023 at 01:39:29PM +0800, Shenghao Ding wrote:
> Move tas2563 from tas2562 header file to tas2781 header file, because
> tas2563 only work in bypass-DSP mode with tas2562 driver. In oder to
> enable DSP mode for tas2563, it has been moved to tas2781 driver. As to
> the hardware part, such as register setting and DSP firmware, all these
> are stored in the binary firmware. What tas2781 drivder dooes is to parse
> the firmware and download them to the tas2781 or tas2563, then power on
> tas2781 or tas2563. So, tas2781 driver can be resued as tas2563 driver。
> Only attention will be paid to downloading corresponding firmware.

>  enum audio_device {
>  	TAS2781	= 0,
> +	TAS2563
>  };

Please, make it ordered, it doesn't seem to be an ABI.

enum audio_device {
	TAS2563,
	TAS2781,
};

Yes, and leave comma as the last entry is _not_ a terminator.

-- 
With Best Regards,
Andy Shevchenko