Received-SPF: pass (google.com: domain of linux-kernel+bounces-12194-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231226192149.1830592-1-markhas@chromium.org>
 <20231226122113.v3.18.I29b26a7f3b80fac0a618707446a10b6cc974fdaf@changeid> <ZYxcvSLL8yWW-URu@smile.fi.intel.com>
In-Reply-To: <ZYxcvSLL8yWW-URu@smile.fi.intel.com>
From: Mark Hasemeyer <markhas@chromium.org>
Date: Wed, 27 Dec 2023 11:21:14 -0700
Message-ID: <CANg-bXCrR2FKSi6ik7LZBqTQz9=HDW=0cy7GZN0yaB0PsKKjkQ@mail.gmail.com>
Subject: Re: [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource()
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh@kernel.org>, 
	Konrad Dybcio <konrad.dybcio@linaro.org>, Sudeep Holla <sudeep.holla@arm.com>, 
	Raul Rangel <rrangel@chromium.org>, Tzung-Bi Shih <tzungbi@kernel.org>, 
	Frank Rowand <frowand.list@gmail.com>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

>
> > +             u32 irq_flags;
> >               const char *name = NULL;
>
> Don't know if OF style requires reversed xmas tree order. If so, this should be
>
>                 const char *name = NULL;
>                 u32 irq_flags;
>

I see both methods used. For example, of_irq_init() uses normal xmas
tree order. I'll leave it unless Rob says otherwise.
It is Christmas time, so I do want to honor the Christmas trees appropriately!