Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp3544003rdb; Wed, 27 Dec 2023 10:42:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFR6ap5BPwq1bIAOeb8kgyc1LDgS5cc/RAQhcAVSXb79DQIQevai5qSdho6Y3KAoXThUC4t X-Received: by 2002:a05:620a:172a:b0:77e:fba3:939a with SMTP id az42-20020a05620a172a00b0077efba3939amr13531923qkb.124.1703702572686; Wed, 27 Dec 2023 10:42:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703702572; cv=none; d=google.com; s=arc-20160816; b=dDQ8h0LBK40c17VjlloMSR84JFbOIl7ZHkOEDIRLONoCrt2e1qChhVVALAyA7KvWPx JrWkrZ/PtVtuYv7DDOJvncdSzVgKzKYiVpaX2bjdp2ZEqqGmbXtQxbn9WKhKRrzTVqRI izLUtdoVlioa7QBDfwTk8u9L3PQX6Ks8A4M3WdgKsJfiMg0xpPwtC5d3K4hPwFX1SOj7 cXnpHABmimalL8lrSzdFdXyXYOggjb0HhE6A9ndrwPUiafaILGOZa14kiQ8XNAk5hcLd RJr52S8SLxk55TpqnJQQLUOEet7YyNPRMSzajavKVS+hBIBDgi4DbDeESDRKSTk3FjvN zNBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=MACIlCAS95kGuZkxL2PTIu24keiO1gQsykhtQwu7Crk=; fh=TbeN/Raw2a5+qnYgXeEAgFwLgsfFMhntwGTjapcZPKk=; b=OlD40KRu+U+KBqt7ILeesi3O1PdYmJJ7uffpRpnKTkREHvpS8E77UVmxF4WM3+DhON oTUWe6LNwUnWmPq0Z0Osh8v4JbIiz5NmrQvPp514yb0aL/TEIEX3LJblAlvN4S1icTzn GKM6P//XSfMY//D+T0Ox+crdHyQq4b93Nyma8qqHVdUiaXARoA7IMYfUnK5uMl3DqmzY o84KYe3O2VLEFEFD446QVQLnnr0YkoTOqoNFlh1HrxNenbWXr9kHsInqd/sOFvYfNLZ/ ONUZsN5Bk2FL+KNJgDVeoWahetZb5MGmciPZ0iv8fwJtueIEnZLqVWfZgWr68GVryzHQ 4HtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Odl1enjz; spf=pass (google.com: domain of linux-kernel+bounces-12216-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12216-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id i1-20020a05620a404100b007815e94f8c3si2201060qko.200.2023.12.27.10.42.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 10:42:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12216-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Odl1enjz; spf=pass (google.com: domain of linux-kernel+bounces-12216-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12216-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 654791C225C7 for ; Wed, 27 Dec 2023 18:42:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7EB3F45C1B; Wed, 27 Dec 2023 18:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Odl1enjz" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 422BB1E52F for ; Wed, 27 Dec 2023 18:42:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D7FAC433C7; Wed, 27 Dec 2023 18:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1703702565; bh=Itb1htvmWYpO4t/GAfB1X1BEGP2JCKRav8Pymo8NuEI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Odl1enjzu74MzygvCIiuGdQhGuwBJGYIrfEtU38Js+pJaoZgqZtkgAzxnt8KMGu1Z HnIBfcbwruRGCu4fnHHGpQUY7F610YMk2gcSRgtmGCxsz2CP9vBZFtS/g54K0EOiqb vXLQMw500IYoKRuQK2K0rtEuQiKxOdMtZzsO8p2I= Date: Wed, 27 Dec 2023 10:42:44 -0800 From: Andrew Morton To: David Rientjes Cc: Pasha Tatashin , Linus Torvalds , Greg Kroah-Hartman , rafael@kernel.org, surenb@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, souravpanda@google.com Subject: Re: Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto expand the sysfs files) Message-Id: <20231227104244.824b0977ae6d4bb6b37f6f79@linux-foundation.org> In-Reply-To: <13e5fbd4-d84d-faba-47f1-d0024d2c572d@google.com> References: <20231211154644.4103495-1-pasha.tatashin@soleen.com> <3d415ab4-e8c7-7e72-0379-952370612bdd@google.com> <13e5fbd4-d84d-faba-47f1-d0024d2c572d@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 26 Dec 2023 16:53:31 -0800 (PST) David Rientjes wrote: > But for existing files and conventions, I think we should settle it as > "keep doing what you've been doing for 13+ years" and don't force this > argument every time a kernel developer wants to just add one more stat. Absolutely. Let's do what makes most sense. For new things, one value per file. For stats which logically group with other existing stats, do whatever the existing other stats are currently doing.