Received-SPF: pass (google.com: domain of linux-kernel+bounces-12232-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 26 Dec 2023 06:32:54 -0500
From: Gregory Price <gregory.price@memverge.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	x86@kernel.org, akpm@linux-foundation.org, arnd@arndb.de,
	tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, mhocko@kernel.org,
	tj@kernel.org, corbet@lwn.net, rakie.kim@sk.com,
	hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com,
	peterz@infradead.org, jgroves@micron.com, ravis.opensrc@micron.com,
	sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
	seungjun.ha@samsung.com,
	Srinivasulu Thanneeru <sthanneeru.opensrc@micron.com>
Subject: Re: [PATCH v5 02/11] mm/mempolicy: introduce
 MPOL_WEIGHTED_INTERLEAVE for weighted interleaving
Message-ID: <ZYq55i03DIYCuC0u@memverge.com>
References: <20231223181101.1954-1-gregory.price@memverge.com>
 <20231223181101.1954-3-gregory.price@memverge.com>
 <8734vof3kq.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <ZYp6ZRLZQVtTHest@memverge.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZYp6ZRLZQVtTHest@memverge.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Xuj8GFvvxUBEl8iE9MqV23Y0gq5q3la1yfi03L/68cLHr2BzjNoqbxO8jR1/?=
 =?us-ascii?Q?rIn8saXfe0FREsqGAe+IuxWR1rsJbylOuwVgepSw6gpcZGC0EeyySWvmtRDI?=
 =?us-ascii?Q?ZoTE6NY6eNG6heC++Nlo+MyNch48bMYV+WSUL0OROBEMLcTyfJ0tsE24wkmV?=
 =?us-ascii?Q?KczpRJgQjcJinSGC/GEu3pktBIheCCyxkXwu+RMiSqVCtg+44KOe5dBXNpy3?=
 =?us-ascii?Q?IiIBoLIaS1PNGgVTIOj0MD3IN/2FLnJ2WmnuM+WFnns+Xs9GTR2U1+hvIOGn?=
 =?us-ascii?Q?pmYzJ7pNZGJ/bbMJI2Q2j3ER3sxTWyD1V2oDygeqbmjDvlOY/xmekVlSKH0K?=
 =?us-ascii?Q?c8R4bH1NZyyD7+sr8UP4vcOUSOGUdfTQdemR6+u6qAGXyx1yjdTZvTpHzoDH?=
 =?us-ascii?Q?m7HSZD6XfPGCqGGJaOvp0FvAtwtJ+3Qb5B342t4aN8ygsgUtJ4atyuYSorYM?=
 =?us-ascii?Q?euD04WDm1JdC8emk39OMAYCn0WbxBQxqp/u0y0MORnXSbZdL3Ag2jRz1r8IT?=
 =?us-ascii?Q?Ept5gjqsBmV5FhHx0R+J5mT8myUfWLklq9M6Lv0I0PCSFBmc7YyOgj2NV3Bq?=
 =?us-ascii?Q?Ocj71NeQ1+V/C778ftGELsBy1RYlFxLcDi0UNuH6irwTu9cnl2p5wU88Kbbh?=
 =?us-ascii?Q?WMI7Cqe9pxnNzZl75X+TrXvl049Bsanv2NQb9Z3dVz2kTq5CLrYV4DXf+OeR?=
 =?us-ascii?Q?S3L372yDEPdIYrNBSR0pW9AWZbfcq1fMxoGdZAJII4XIDpceySrwPgo+fFDg?=
 =?us-ascii?Q?FyUQtIfoHMVIDnZO0p7fHqTxTgfWHFOKaRaqhuUnnDn1OA7ZA39sZZDC4xlQ?=
 =?us-ascii?Q?JVnkQe1oSGJr01A8TIURxsNe1gwPBp9HMk7x47d/3kMp+/Qrks+QjeWd60FW?=
 =?us-ascii?Q?CGeD0WMtn150OUz/mU6VJQsramF4V/SvdEHrB7VIzfUiAeGA2Gn6krBhh3/5?=
 =?us-ascii?Q?8csEzjKZK0/aLGzMWnziEMHGYvEKoJh31GDpqx4uAF/bE8sapFHQMFNjK+Oy?=
 =?us-ascii?Q?3LDF82DbJvyYeM6pcbofMxsILf5A+DH86JbscbBvEV1/w/trctbJjVWULfmZ?=
 =?us-ascii?Q?oqjPVUad9mhWiqo1Z2ASwdWcQ6/tTwNbXg1no8CPTS/6ziATtWJcbwDEA34M?=
 =?us-ascii?Q?TMPVHcSny+lsz0W2UozZuIVDUbOzcDqsbAIVrQ+gCPRgmftYFpPFjPVYDQMZ?=
 =?us-ascii?Q?OLdbW1EpRKcBFe1yf2Mmf1fQddk37Xsxe+mCLUsWRCGr3ks6ZiGzWVa7/jDp?=
 =?us-ascii?Q?Pw/ME2NU5Jjp448NgH00gn7rkjzSJ+2wozLzm+nTJopID3+cwUjBHzIX/SS9?=
 =?us-ascii?Q?a93gY9WSSiFp8xhHAJ+QeEMfC+6AScZ/qVEUeZrxPDZ4gNbdUX8cfVPWObN/?=
 =?us-ascii?Q?WXxrBmfvP8w3ZE9otM1HIZvhf0otUYiKhvWYU4zleW/c2IWDsKAesv96KnJ0?=
 =?us-ascii?Q?FwDB/vyF12boUPRlrAzktNVyQXD+MVNPxpWwp0xwtuf/C6X4ejXA0dyNu80k?=
 =?us-ascii?Q?1UrIxb23OdMrnB/Gd3F2wukwrqS4QtTm6QtYCZ5vQtJKJ/HT979lXiVSNnaK?=
 =?us-ascii?Q?SO1EQoeidTPb0o/ctkT9GdEBFEcNJ3YOBVYVDdC5CBUraX4CotxwIdlWdMR7?=
 =?us-ascii?Q?DQ=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e86497ec-4eaa-4e48-1dfe-08dc071555d0
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2023 19:52:19.7089
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A4G2XUfLVQro0x8advvzpB+eXVO2qdGYaMGShVc7L66e8SzMfeLrZaLoqbf1FnYDOOtQx23CqW8oHSi+iGTbWppwwKfrQXAq8hHcVc7mTE8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR17MB6939

On Tue, Dec 26, 2023 at 02:01:57AM -0500, Gregory Price wrote:
> On Wed, Dec 27, 2023 at 04:32:37PM +0800, Huang, Ying wrote:
> > Gregory Price <gourry.memverge@gmail.com> writes:
> 
> Barrier is to stabilize nodemask on the stack, but yes i'll carry the
> comment from interleave_nid into this barrier as well.
> 
> > > +
> > > +	/* first ensure we have a valid nodemask */
> > > +	nid = first_node(nodemask);
> > > +	if (nid == MAX_NUMNODES)
> > > +		return nid;
> > 
> > It appears that this isn't necessary, because we can check whether
> > weight_total == 0 after the next loop.
> > 
> 
> fair, will snip.
> 

Follow up - this is only possible if the nodemask is invalid / has no
nodes, so it's better to check for this explicitly.  If nodemask is
valid, then it's not possible to have a weight_total of 0, because
weights cannot be 0.

~Gregory