Received-SPF: pass (google.com: domain of linux-kernel+bounces-12236-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 26 Dec 2023 06:48:34 -0500
From: Gregory Price <gregory.price@memverge.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	x86@kernel.org, akpm@linux-foundation.org, arnd@arndb.de,
	tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, mhocko@kernel.org,
	tj@kernel.org, corbet@lwn.net, rakie.kim@sk.com,
	hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com,
	peterz@infradead.org, jgroves@micron.com, ravis.opensrc@micron.com,
	sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
	seungjun.ha@samsung.com
Subject: Re: [PATCH v5 03/11] mm/mempolicy: refactor sanitize_mpol_flags for
 reuse
Message-ID: <ZYq9klTts4yg8RhG@memverge.com>
References: <20231223181101.1954-1-gregory.price@memverge.com>
 <20231223181101.1954-4-gregory.price@memverge.com>
 <87y1dgdoou.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <ZYp7P1fH8nvkr4o0@memverge.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZYp7P1fH8nvkr4o0@memverge.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?K/3AInaXmXZ7xvZbMWxN7K6GudR3mdt56bOrVs0xJTPL2CWgVGjCrZHeVQpV?=
 =?us-ascii?Q?7+PEhMoCtNkv3Wnes5AWH92Cm8Ae64Obk2t4UAQbvCnzPbyLxaQKYmDE2xsG?=
 =?us-ascii?Q?I2eWf+tsLbt8xNswnz+TKYgz9U16Ke49inAWHGs6kwmXIL6TjpTAXfQW8jCX?=
 =?us-ascii?Q?vSXLPbuHNgU4Eho1JN6PkptCvgz0c+5oYnfCotxfJd0LDraxzNFkthWQbS1G?=
 =?us-ascii?Q?Fb8LFfN15h/Shgmvuc9bX7P6Kw9u0q8jIAtL/qYyEO+X6v+Qond9Hnjzqoih?=
 =?us-ascii?Q?tPqhH9A1mFOV8009ijHDktMHFBD+Kurhxdn6q2ENuWIkCnf9qompro7FXWqz?=
 =?us-ascii?Q?g7r+IXuU3N38/VIH2MvZwDXP4ZIWu94TxkUut4unLqEIHQmTBjxXBZbb93OH?=
 =?us-ascii?Q?JMNHobEquVX9c1LAT05qs9OvjWBOnBVmvavUZRvMOnGwZWWoKp2/tG7ikPhC?=
 =?us-ascii?Q?V/V9UoZx24bP5dpUHdpp6OpVG8bcrhu3fPSnaOmwz52bRzAs9eA/WDldVs/R?=
 =?us-ascii?Q?IntcvJ9awkH0iUSwucO9qULgLzHo+p4zOrP/5tGwzSPSmBXzJCu1wgcce2ze?=
 =?us-ascii?Q?cLlG+58buNmm+bhStgaqOOcnmQit7vHJMgRFp+CVER9bGaEW9Cv1FWLUdAHd?=
 =?us-ascii?Q?wTZi6qSGYuMy+FZ5vCKVv7pBznLZcxiUCTMZB4Y/m1I7/5qgE8kazCTJLpmR?=
 =?us-ascii?Q?upzYGSKHrq4+tSOqncRfVoge6ati3K56p/T6jBKfVcp8qhD4Ya/u/avErlrD?=
 =?us-ascii?Q?PB2u9C2dR8WRs9vQOnY2ZP2C75byu030OH9caBdobAiGxJ7t9NU9jVHv/LNM?=
 =?us-ascii?Q?h1OjPsW15ea6xHD+WmYWjKmbVkohMsTv0DGgh7ATx8ewIPxQXtD12FwxOe5N?=
 =?us-ascii?Q?pxd8pVPhg3Th0WnLUGakNZ+l17H7AsX8EY417jTnDhvUhlL6HdfbUDFQVJ3d?=
 =?us-ascii?Q?eBOAx6QYY34ESijvbFm32LX7gm3lyBd77Lp3hevhNLazOt6TNpLFoGMkNLIz?=
 =?us-ascii?Q?1mlw2t77MFB2wzrtJJhAYb1ziFJ1jh+EPYz2sqaw7U779dQIrpwz/31uqUu5?=
 =?us-ascii?Q?P3IM5HjZ9vLSzktWLAKhxo9YNoX+ZAOvGyT+nEOvacp84VQ+DCxM9+NabVHu?=
 =?us-ascii?Q?fw73hYn/vA7vhfmcHRjDl7O1JFXlwYI8nBSVG6o3oOnDRTN3OK4D/W4Wowvx?=
 =?us-ascii?Q?dqoEqBIF+B04z1r0fkdHdcyBe+jXAXmv+8TAjph7HkXNJa4rTcq+RFEvniC4?=
 =?us-ascii?Q?Tu35LExoaI1R2tDFZpCGxbe4Gja0hjY+BM5+OCD/8AYYsBGqTtQGJAJ0F5ur?=
 =?us-ascii?Q?MP5U3ToF4vwjUb7f5dc/m8nP08UvJkMTS1vXtX/B6fZ/Xj9ZOlHSTPovql6Z?=
 =?us-ascii?Q?VXLFiq+RkR/FUWtmFrVi5bFP00//N6Abys/JyIVbzs6cegeTIbKt2HjAWI4F?=
 =?us-ascii?Q?Gk8tWuugvBNvYcRMVDY/RE7LCsfRf1XuxBOYSxGFvdy1/b9PuiEJWF7yJBhW?=
 =?us-ascii?Q?Xo8snziHLpVb2zQ6YohgPWl4KtCcdA3sKZO7ALSXufykzMH0Wu7AEWiOIwRx?=
 =?us-ascii?Q?Y+6klJn7SrhOrwLbb84yYdg4YkkORT8MCKKi+4Qy4XPe+tUIgUdZ8vPQ+BCA?=
 =?us-ascii?Q?9Q=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9240133c-ad2a-48b1-0e87-08dc07175907
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2023 20:06:44.0624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: beeW25LLMbz3SOuU5qIB4ohX36Mxlu29wurzwW6THd4AmAsZ90awEMAXW74BK3DoIPHWEd7kDQYRse++sXnRS9rFqz1WrHHnwItjw6Akmqk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR17MB5557

On Tue, Dec 26, 2023 at 02:05:35AM -0500, Gregory Price wrote:
> On Wed, Dec 27, 2023 at 04:39:29PM +0800, Huang, Ying wrote:
> > Gregory Price <gourry.memverge@gmail.com> writes:
> > 
> > > +	unsigned short mode = (*mode_arg & ~MPOL_MODE_FLAGS);
> > > +
> > > +	*flags = *mode_arg & MPOL_MODE_FLAGS;
> > > +	*mode_arg = mode;
> > 
> > It appears that it's unnecessary to introduce a local variable to split
> > mode/flags.  Just reuse the original code?
> > 

Revisiting during fixes: Note the change from int to short.

I chose to make this explicit because validate_mpol_flags takes a short.

I'm fairly sure changing it back throws a truncation warning.

~Gregroy