Received-SPF: pass (google.com: domain of linux-kernel+bounces-12248-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20231226192149.1830592-1-markhas@chromium.org>
 <20231226122113.v3.24.Ieee574a0e94fbaae01fd6883ffe2ceeb98d7df28@changeid> <ZYvDshfJ-jnWNEY5@google.com>
In-Reply-To: <ZYvDshfJ-jnWNEY5@google.com>
From: Mark Hasemeyer <markhas@chromium.org>
Date: Wed, 27 Dec 2023 13:45:56 -0700
Message-ID: <CANg-bXB0k-Z1PjAuW=vX3oR7T02g3z+d7ppdzfL-Cj7T+EQ6EA@mail.gmail.com>
Subject: Re: [PATCH v3 24/24] platform/chrome: cros_ec: Use PM subsystem to
 manage wakeirq
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh@kernel.org>, 
	Konrad Dybcio <konrad.dybcio@linaro.org>, Sudeep Holla <sudeep.holla@arm.com>, 
	Andy Shevchenko <andriy.shevchenko@intel.com>, Raul Rangel <rrangel@chromium.org>, 
	Benson Leung <bleung@chromium.org>, Bhanu Prakash Maiya <bhanumaiya@chromium.org>, 
	Chen-Yu Tsai <wenst@chromium.org>, Guenter Roeck <groeck@chromium.org>, Lee Jones <lee@kernel.org>, 
	Prashant Malani <pmalani@chromium.org>, Rob Barnes <robbarnes@google.com>, 
	Stephen Boyd <swboyd@chromium.org>, chrome-platform@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"

> >       /* Retrieve GpioInt and translate it to Linux IRQ number */
> > -     ret = acpi_dev_gpio_irq_get(adev, 0);
> > +     ret = acpi_dev_get_gpio_irq_resource(adev, NULL, 0, &irqres);
> >       if (ret < 0)
> >               return ret;
> >
> > -     ec_uart->irq = ret;
> > -     dev_dbg(&ec_uart->serdev->dev, "IRQ number %d\n", ec_uart->irq);
> > +     ec_uart->irq = irqres.start;
>
> How about keep using `ret`?

The return value for 'acpi_dev_get_gpio_irq_resource' is different: 0
on success, negative errno on failure.

> > @@ -301,7 +306,14 @@ static int cros_ec_uart_probe(struct serdev_device *serdev)
> >
> >       serdev_device_set_client_ops(serdev, &cros_ec_uart_client_ops);
> >
> > -     return cros_ec_register(ec_dev);
> > +     /* Register a new cros_ec device */
> > +     ret = cros_ec_register(ec_dev);
> > +     if (ret) {
> > +             dev_err(dev, "Couldn't register ec_dev (%d)\n", ret);
> > +             return ret;
> > +     }
>
> It doesn't need the change after moving device_init_wakeup() and
> dev_pm_set_wake_irq() into cros_ec_register().
>
> Drop it?

Will do.