Received-SPF: pass (google.com: domain of linux-kernel+bounces-12276-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d752d157-659b-4d05-90a9-ebbf19c07068@infradead.org>
Date: Wed, 27 Dec 2023 13:40:01 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] counter: linux/counter.h: fix Excess kernel-doc
 description warning
Content-Language: en-US
To: William Breathitt Gray <william.gray@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
References: <20231223050511.13849-1-rdunlap@infradead.org>
 <ZYw2SkkEzSW2C2gN@ubuntu-server-vm-macos>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <ZYw2SkkEzSW2C2gN@ubuntu-server-vm-macos>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 12/27/23 06:35, William Breathitt Gray wrote:
> On Fri, Dec 22, 2023 at 09:05:11PM -0800, Randy Dunlap wrote:
>> Remove the @priv: line to prevent the kernel-doc warning:
>>
>> include/linux/counter.h:400: warning: Excess struct member 'priv' description in 'counter_device'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: William Breathitt Gray <william.gray@linaro.org>
>> Cc: linux-iio@vger.kernel.org
>> ---
>>  include/linux/counter.h |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff -- a/include/linux/counter.h b/include/linux/counter.h
>> --- a/include/linux/counter.h
>> +++ b/include/linux/counter.h
>> @@ -359,7 +359,6 @@ struct counter_ops {
>>   * @num_counts:		number of Counts specified in @counts
>>   * @ext:		optional array of Counter device extensions
>>   * @num_ext:		number of Counter device extensions specified in @ext
>> - * @priv:		optional private data supplied by driver
>>   * @dev:		internal device structure
>>   * @chrdev:		internal character device structure
>>   * @events_list:	list of current watching Counter events
> 
> Hi Randy,
> 
> Would you provide a Fixes tag for the commit that removed the 'priv'
> member so we can track when this warning appeared? You can respond with
> it to this thread and I'll add it in when I merge your patch.

Fixes: f2ee4759fb70 ("counter: remove old and now unused registration API")

Thank you.

-- 
#Randy