Received-SPF: pass (google.com: domain of linux-kernel+bounces-12291-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 27 Dec 2023 01:16:01 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: John Clark <inindev@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Heiko Stuebner <heiko@sntech.de>, linux-rockchip@lists.infradead.org, 
	Thomas McKahan <tmckahan@singleboardsolutions.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the
 rock-5b
Message-ID: <pqvmguq77qbxmuxsushrz4ykxtmvkugirbxnckmbfk47gx2u5n@cz2kllnjr6ba>
References: <20231225222859.17153-1-inindev@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kvxm4plewcxgwfam"
Content-Disposition: inline
In-Reply-To: <20231225222859.17153-1-inindev@gmail.com>


--kvxm4plewcxgwfam
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Dec 25, 2023 at 10:28:19PM +0000, John Clark wrote:
> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now"
> on the rock-5b it reboots instead. Defining 'system-power-controller'
> allows the rk806 to power down.
>=20
> Commit c699fbfdfd54 ("arm64: dts: rockchip: Support poweroff on
> NanoPC-T6") similarly resolves this issue for the nanopc-t6.
>=20
> Signed-off-by: John Clark <inindev@gmail.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> Changes since v1:
>  - added commit message with additional patch detail
>  - expressed the related commit using checkpatch
>=20
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64=
/boot/dts/rockchip/rk3588-rock-5b.dts
> index 74719aaf697c..dc7b88f29172 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -426,6 +426,8 @@ pmic@0 {
>  		pinctrl-0 =3D <&pmic_pins>, <&rk806_dvs1_null>,
>  			    <&rk806_dvs2_null>, <&rk806_dvs3_null>;
> =20
> +		system-power-controller;
> +
>  		vcc1-supply =3D <&vcc5v0_sys>;
>  		vcc2-supply =3D <&vcc5v0_sys>;
>  		vcc3-supply =3D <&vcc5v0_sys>;
> --=20
> 2.43.0
>=20
>=20

--kvxm4plewcxgwfam
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmWLbL0ACgkQ2O7X88g7
+ppLdRAAh2XPhGTc/H7YdLn4Qr1Z2zdInwHqPU48aPogwAwNH0X4GOjp+e05nCPG
umdF7rRq+ZQvwp5wADlZ76cGpJ1PhxyiXGXjv00EvflDBb0S/edJjvrhxj4MFJMl
e5UJH8pQNLaJlCk2wpz0nSEO7MiCM5xnukb8aUAuXJhunjqrFEXT4b8I88kmWlW5
YmcvT40usLIv7s9tyYyy0l9KE/BdPBQ/ANDhKfJaulN2s3+UdfIco8cgUuR2UaUX
Ry3cqQUm7jLi3iDVAwUTS8lCv+3gI//D890PEh4KDd5XCsU5q5Y0XYi/WcXWNmJQ
hgbfyWSgAXToOc1AKFj2STX+hgESqLMigV1MbZOeDBVUajJ9U9d9I0ewMlGxjNwB
reCEvU60sH6LrO37Lxmzwt+w1G8oD1NA6LWPglhh3CAPGnOXW0Fq53TIs9DdZ0x6
vVRXWTevFPYwXTUehJD1PzLmJ0vUEwHXBtErcOcfllAieRetQMr9A5RwDNao6nST
j3kxWh3ExyXX48sAOU3b0AhF+lbqojesaxtXweXj6Nn9hPz6qvDyqWHn9nd9bL2e
E4rW7i91zVuovFC1ExDsLkypFMm7Wxxkte82NgbWAMGXC0eosSs+246wQWMlNniZ
7nyYUW/tin2mfYvugbyYzgpsbI4nW8gtoE3JgMuM0gEQzQr+jjU=
=+bGO
-----END PGP SIGNATURE-----

--kvxm4plewcxgwfam--