Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp3636958rdb; Wed, 27 Dec 2023 14:28:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUmxt/WwjPbKLWVOryBDSY4q3/0xSbdFdHdC8X0IeapTMIYcmxnRn74rCW2Q+BeGlT4Ya0 X-Received: by 2002:a05:6e02:19cd:b0:35f:ee15:688d with SMTP id r13-20020a056e0219cd00b0035fee15688dmr13371276ill.104.1703716134186; Wed, 27 Dec 2023 14:28:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703716134; cv=none; d=google.com; s=arc-20160816; b=CbsO5MMAQyhwxE5/xUXXFhw/NhwhZz7e55wNbm/tOqPwEW44m1l6rb821Jg3jI8Ge4 CvGznAQH2+b47OEEIwc1bOT8s8hbFJ/uFhBQ4UyomtypjbB0xzuXqVi7WHuJEyyItjIl bShTUpaI1e2pmrj4ytyTvzv4pW5N/ptbFleQUk0LMXxx7/4ovRGYSPn9OVkr4SgzA1VU nzNgy99Kaww5cSmZPsr7HS07jrb/ba0Y/2YIzsPywXnvOmWb7VmbqZldJO0LesDSbpGD eOPZOzZtY8EXKbMp0UnnF7ZEYZWtcZSUmWvUMVSpGT9grxYkPKLiwzngxEyslLbPJ98b v7AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=JWBf1IzDI4te1Z7yJaMLFE48TcXMDUCVA44V+FdpVh4=; fh=KLeS/c16yOJ1FS6Ho4w0J6IIxO2ziXCSDgX2W9R+at0=; b=hWD+YRwu4pTS8DircSHOiaXa5h+EyCTS9vD2QkHgIDDV2K9DI4s3/07A+8DkfaIBFH +wGoDJ0cUphzvB81Bw1zfMfeODlL/iiDkzvSHiqghNi9zVW3yK0ow6LRDxqCgo4XMf/b HDz/ta6YVzp7ZoXVhyrpAYfE7YHHoY81ngV7gVLZ9EQHxKdlzF1FVTXyw2C/pgytHMaI KRJszDccVUjk0sUz6ZX37A5MIR31muWdPz2z9iND54iNsmLB08kexnCqdYsCbZ3E5zOO YzFVuLJ+sqeI3fZRhU1OdJpbLb2H+xKTFDByZG9uIyJCNq6ZB5ggPUhcp6a1q6tfQ9Oz sLfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yH2Gd9ys; spf=pass (google.com: domain of linux-kernel+bounces-12295-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12295-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id o17-20020a635d51000000b00584ca25959csi12086037pgm.540.2023.12.27.14.28.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 14:28:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12295-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yH2Gd9ys; spf=pass (google.com: domain of linux-kernel+bounces-12295-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12295-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CB5872822CF for ; Wed, 27 Dec 2023 22:28:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 75109498B7; Wed, 27 Dec 2023 22:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yH2Gd9ys" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29F2F4988B for ; Wed, 27 Dec 2023 22:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40d5ae89c72so16952765e9.2 for ; Wed, 27 Dec 2023 14:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703716112; x=1704320912; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JWBf1IzDI4te1Z7yJaMLFE48TcXMDUCVA44V+FdpVh4=; b=yH2Gd9yskgZMRRwSw8ak+G4cdUbiIE0tBLQSDLz03v8ILNkDUI3a5US1Do2G6vPcQL 2fivac16cWoQn3D7IHvUJw6OvA1PH9fe+0Z5lIsZ4VlkKB1B4Pscrn+KsY/JhQjF73di oHjSsrBAQf3Wx3b82cdpTJgbekWD3jV7+0cY2fKvDPhPDoAuewOmeafholg/5yYoT8ZT 11y9EMvIpyFbuzPNlyHWilFhSSBvtxMQSOO0QCiZGjx+ZlewcOgzJ1cxBRlz7pZq61gB 1Y1bOzHDXOdAeDJAe5flDoARjOVsrBqvtRuySpwSGGeN5UALHiGoPK+Kv9xh99sNP8QQ MopA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703716112; x=1704320912; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JWBf1IzDI4te1Z7yJaMLFE48TcXMDUCVA44V+FdpVh4=; b=jC2uMpi5vnPHt6K74Y+xSZowB82yWKqauQ2uUUNXTYR/sT7W1+/5iI/SRNiXjMqRyr kGqNfBbZasAoVMOYF+PICxhJOORG2eRkw+6wGHsaMDLKvFZv2A1H9EZfxTSE/W+JX2Rl 6tfrhbtqUng09fS3jDPcwZYVBoP1EVIHnIuhiZKSuqA8E3u7IZISEYxXQ7cJUV+t+Sk4 358M2SWwZ6up1n1kgEy5FKGsQIUAVh1TvbtZZrgwDN2ozvWoS3fBzwpkpilBoO3zMtXP gpBVmrr2V6cg6Va5fiLqpqAzza8siC6yJOQIWu1pstuJyiz0y32/PY5pz6x2LvZ/tmK2 v6mg== X-Gm-Message-State: AOJu0Yyzul0xnPKl/9TixmRXq5Vv2pZ7iab4KKYFEvciY92A87WrUnRk 94M6beNrRMNgejCIfnMH96mltJ8I4qwPng== X-Received: by 2002:a7b:cbc5:0:b0:40d:6221:868f with SMTP id n5-20020a7bcbc5000000b0040d6221868fmr186298wmi.279.1703716112496; Wed, 27 Dec 2023 14:28:32 -0800 (PST) Received: from [10.167.154.1] (178235179028.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.28]) by smtp.gmail.com with ESMTPSA id fb20-20020a1709073a1400b00a26a061ae1esm6854252ejc.97.2023.12.27.14.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 14:28:32 -0800 (PST) From: Konrad Dybcio Date: Wed, 27 Dec 2023 23:28:26 +0100 Subject: [PATCH 1/3] arm64: dts: qcom: sc8280xp: Fix PCIe PHY power-domains Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231227-topic-8280_pcie_dts-v1-1-13d12b1698ff@linaro.org> References: <20231227-topic-8280_pcie_dts-v1-0-13d12b1698ff@linaro.org> In-Reply-To: <20231227-topic-8280_pcie_dts-v1-0-13d12b1698ff@linaro.org> To: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Johan Hovold Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1703716109; l=2255; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=kMvRAvWfpP/DEkU3LU/WsYqL/aUkUp2LCfdAhZy7cI4=; b=on07lEwMe5d6HDnWJbd3ihCw4sDHjf6qoR6QPRX9iQ0Vnh0ruqYLUNj+EZc5bK1Y5UyUQikEE 6Fwi+MxoF+pDhYo9Felu72ulAdl/i+cto7szIDueMCbObm95l0u4r++ X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= The PCIe GDSCs are only related to the RCs. The PCIe PHYs on the other hand, are powered by VDD_MX and their specific VDDA_PHY/PLL regulators. Fix the power-domains assignment to stop potentially toggling the GDSC unnecessarily. Fixes: 813e83157001 ("arm64: dts: qcom: sc8280xp/sa8540p: add PCIe2-4 nodes") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index febf28356ff8..72c5818b67f2 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1797,7 +1797,7 @@ pcie4_phy: phy@1c06000 { assigned-clocks = <&gcc GCC_PCIE4_PHY_RCHNG_CLK>; assigned-clock-rates = <100000000>; - power-domains = <&gcc PCIE_4_GDSC>; + power-domains = <&rpmhpd SC8280XP_MX>; resets = <&gcc GCC_PCIE_4_PHY_BCR>; reset-names = "phy"; @@ -1895,7 +1895,7 @@ pcie3b_phy: phy@1c0e000 { assigned-clocks = <&gcc GCC_PCIE3B_PHY_RCHNG_CLK>; assigned-clock-rates = <100000000>; - power-domains = <&gcc PCIE_3B_GDSC>; + power-domains = <&rpmhpd SC8280XP_MX>; resets = <&gcc GCC_PCIE_3B_PHY_BCR>; reset-names = "phy"; @@ -1994,7 +1994,7 @@ pcie3a_phy: phy@1c14000 { assigned-clocks = <&gcc GCC_PCIE3A_PHY_RCHNG_CLK>; assigned-clock-rates = <100000000>; - power-domains = <&gcc PCIE_3A_GDSC>; + power-domains = <&rpmhpd SC8280XP_MX>; resets = <&gcc GCC_PCIE_3A_PHY_BCR>; reset-names = "phy"; @@ -2094,7 +2094,7 @@ pcie2b_phy: phy@1c1e000 { assigned-clocks = <&gcc GCC_PCIE2B_PHY_RCHNG_CLK>; assigned-clock-rates = <100000000>; - power-domains = <&gcc PCIE_2B_GDSC>; + power-domains = <&rpmhpd SC8280XP_MX>; resets = <&gcc GCC_PCIE_2B_PHY_BCR>; reset-names = "phy"; @@ -2193,7 +2193,7 @@ pcie2a_phy: phy@1c24000 { assigned-clocks = <&gcc GCC_PCIE2A_PHY_RCHNG_CLK>; assigned-clock-rates = <100000000>; - power-domains = <&gcc PCIE_2A_GDSC>; + power-domains = <&rpmhpd SC8280XP_MX>; resets = <&gcc GCC_PCIE_2A_PHY_BCR>; reset-names = "phy"; -- 2.43.0