Received-SPF: pass (google.com: domain of linux-kernel+bounces-12446-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
Subject: RE: [PATCH v8 06/10] iommufd/selftest: Add coverage for
 IOMMU_HWPT_INVALIDATE ioctl
Thread-Topic: [PATCH v8 06/10] iommufd/selftest: Add coverage for
 IOMMU_HWPT_INVALIDATE ioctl
Thread-Index: AQHaON/DMEua3daO0USOPGF1UKMImrC+N36Q
Date: Thu, 28 Dec 2023 06:14:35 +0000
Message-ID: <BN9PR11MB5276DEF13D2F64D244A932C68C9EA@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231227161354.67701-1-yi.l.liu@intel.com>
 <20231227161354.67701-7-yi.l.liu@intel.com>
In-Reply-To: <20231227161354.67701-7-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kv0Cq54iqiyaxjkEHtn1H6/GPV7SvwxOxrT/eulX60uapQPfG0uPoQ8WT3gj?=
 =?us-ascii?Q?ZP8sSXa6T3EJwnCiphMhPgXXfTe+xXsW5MCgRMa1BzdD+hdNHto2GnNLeL14?=
 =?us-ascii?Q?qeqJkRtneWh0vEX337OQp2vu7cvJGzLVFCm1PmTL7DinVCQZAoBSLnoz2A14?=
 =?us-ascii?Q?Xwa7DQ6EVmVT4lUsda9x68wtSENhwS7+9i2cwMzqc3C2aRe1xil6KtvYFqjZ?=
 =?us-ascii?Q?QVqjOEtHsxWByLWSbsIQbBmlwI0kFFgA1k/XFosRmK8C6ruRGSjR5gscH0PV?=
 =?us-ascii?Q?azuMIWhPC02xmfzzW0i04aHAUdFDYtW2hNYYaEFRJ4r5a6gqz86V5PO97Dn8?=
 =?us-ascii?Q?JJYocWA6zPuk7H5GBxL0Us8Y+1WtpYCdmSZ9EB4434HpwPkiwjfoNByU5OPL?=
 =?us-ascii?Q?TLSw3TKlOLJZs/dOJj5Qc+lQ4nmvz9vOZdW0x5xOgZp2fROO5nCuTAXvF4OB?=
 =?us-ascii?Q?Gy7OGvC5pSCUwdc9baEs8IbF/rxM4FifhYYEdWgl+rz4z2slvAg5DL6rHVVu?=
 =?us-ascii?Q?8oGxlylKJM2UlmVmTvmQ6fVM9Fz6ZpvYis8s56HGUyaebXmxUNrPq/rpnZLG?=
 =?us-ascii?Q?IS/sSUTw8ZxCR5gyycvwovhZ5fm4Gnk5odxVUxP+PMzRILAzNZDYTpS9bos/?=
 =?us-ascii?Q?T98/0w5AoO0uvw+rw/uyjqdSSu2rreE6DrjT+UFJ6HYwf4k4+8PWSxlfPb4T?=
 =?us-ascii?Q?pJi7zpc6TOjNQplbn8tH99DBvlXMX5yGfuyaI7mA9I2OlFGzKMkiT1cCSR8V?=
 =?us-ascii?Q?ARMErdJlen+FXarr3UGvGjGC3JZ0nz+6+7KG9DNJQZanSis3ET3USUiAnQAf?=
 =?us-ascii?Q?vkOT6QYY2OnWoaT6UOkonVDZSjYcDvj8cccx/AAtp7pIIxA83EMy3q6cumEt?=
 =?us-ascii?Q?1ZfgWTWVUv4tBb8jeYRWfq/w6ubshWzIIWhWHGNMpyx48YDe+rh2PYxmSKuB?=
 =?us-ascii?Q?3FSekEikS9gOzB21v/V8xAlWrsdPYn1IL/Io16o2EwQdweJZuxjf4nDEzd8t?=
 =?us-ascii?Q?1wKciogVYSfLeb8h02tAVcDznpjJuWNzha993RkBOm17Vyfx7Btlyw1ac42M?=
 =?us-ascii?Q?zGdABROhsIbACWxoeUfLWk0QeUnQP2X6wenLlOq7ooRbirUtuBLe8LyjvCut?=
 =?us-ascii?Q?Gvy+Dy+7Mv9f5u7uOZO/RZzDnfFIKTWdAzdCLJYgmzNtslu9tqV3rpkQ2om7?=
 =?us-ascii?Q?tiqDdmWjH/DtKLJG2BKzLQFiCZZnwyBRrZNP7oRb1zTqYGpdGv2kz7xbYHXu?=
 =?us-ascii?Q?3iimShX4nS7aZFrSlfPrLv/yDT4tCCd1THuNxMHqIc0OIXmFnhMgmEbotHik?=
 =?us-ascii?Q?H4hqkDKDdPpgIePqkkPCVdkWdsyGGnTGpTx00eQ0vj6NmX5TBiZybhlRh2hd?=
 =?us-ascii?Q?h/HTBSL8b9f1NGB+AkLlJu3JVvhdVm1dtVRS9wc3lstkDdZOSk3iaDTb9Jw2?=
 =?us-ascii?Q?uD53DffKE1GAkTyYicqFlTV7aJXEZQj/CF9x7LvFEWZRr8ne7mFRLTdOHfGZ?=
 =?us-ascii?Q?ScuVEfAOPpbQjwXyRbZmJFkLPzdS76woE+OIsxlBzeDmqEqxMdLUvrUvXZZV?=
 =?us-ascii?Q?iWLSKFulAKQoWnBy8Yvpvcn5ImWVO78A9XigLJuT?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6af8faea-e45b-447d-79d9-08dc076c43a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2023 06:14:35.2469
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5vvrmoLi1Uzsf8vRdgKKOawqXsfkSYO+Al1M+WQO6cVoflvem3Hm5gKI3ulgfWDtfFB5BJGpv5oIXJJPHJ8Q0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4822
X-OriginatorOrg: intel.com

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, December 28, 2023 12:14 AM
>=20
> +		/* Negative test: trigger error */
> +		num_inv =3D 1;
> +		inv_reqs[0].flags =3D
> IOMMU_TEST_INVALIDATE_FLAG_TRIGGER_ERROR;
> +		inv_reqs[0].iotlb_id =3D 0;
> +		test_cmd_hwpt_invalidate(nested_hwpt_id[0], inv_reqs,
> +
> IOMMU_HWPT_INVALIDATE_DATA_SELFTEST,
> +					 sizeof(*inv_reqs), &num_inv);
> +		assert(num_inv =3D=3D 1);
> +		assert(inv_reqs[0].hw_error =3D=3D
> IOMMU_TEST_INVALIDATE_FAKE_ERROR);
> +

instead of removing TRIGGER_ERROR|ALL err check, it makes more
sense to keep it but making it a similar case as above.