Received-SPF: pass (google.com: domain of linux-kernel+bounces-12448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
Subject: RE: [PATCH v8 07/10] iommu/vt-d: Allow qi_submit_sync() to return the
 QI faults
Thread-Topic: [PATCH v8 07/10] iommu/vt-d: Allow qi_submit_sync() to return
 the QI faults
Thread-Index: AQHaON/A5bfZH72AA02vmOQ862qYJLC+OJ2Q
Date: Thu, 28 Dec 2023 06:17:19 +0000
Message-ID: <BN9PR11MB5276429906ED56258BB433068C9EA@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231227161354.67701-1-yi.l.liu@intel.com>
 <20231227161354.67701-8-yi.l.liu@intel.com>
In-Reply-To: <20231227161354.67701-8-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IwSvjoM3R8b1gyTDL0Yeb7doUw5UOxyX+EiRqM0wZMuQg5J0RGOvFI5AyYkk?=
 =?us-ascii?Q?4MGH92pHjD7WfBvfed8RIjQm77Px5yLOTsHtg2FSI8SJFDTtBocrJhlYTKNo?=
 =?us-ascii?Q?9jRfq5hjEUUqfPKUKoUJEBIhRB+3WqeJkZRLSSZot4GoBoLoMqu8TkHFJ2aj?=
 =?us-ascii?Q?56JqaJm6JakIB/jsVa1P9tSTUYWilK89DlVXdvcjsVX0GbvgwclZQlg3So9K?=
 =?us-ascii?Q?XqxM5EyXIWFHadc/xoN7UrTX+Eyc75FNaQQB2oSbZogEiouvizSnJpVUxUun?=
 =?us-ascii?Q?uQbhKRoJsmFnaDRcybnMpph8i/zyLKP870oqX49NZPNeCR/w1BDalTr2Nceh?=
 =?us-ascii?Q?+a7KSqVj5MBPB5NDNk3q5fB4QAIM+C8L26eVGRoSI62yw9FngY2YnWXmqb9l?=
 =?us-ascii?Q?h4kWlCKFF1FUpr9tW1ub/PRGJOQJ54P+lqBrcgJgTIdmcYWXibbmwHeUDZwE?=
 =?us-ascii?Q?4kcbNCkl6GBSxZT/GOlf6qnpbkaB1DoBPzOYzZKuQBkCNW00cm8loc7z2gRQ?=
 =?us-ascii?Q?RhfqaowPi8/kwTA6CWPR8UwyuBcmgIFvnbQfnStDleMTG3KFS8F/p5r0qu3i?=
 =?us-ascii?Q?Mb3R2vzc3UwO11P0r0FmRdSBf2w2CW7cklH+Xp1ShlgMQ4irJ+CAUQAiYkbX?=
 =?us-ascii?Q?4PsmtrT7CzTaV+lx4mW8ZEuDBLI9FajzOOhFZbqO3vSMDlWTazkducdDiARk?=
 =?us-ascii?Q?6taZAjZ9Z/fXcD6a5TtmNCNGAprw3w1lxxqq+FVFWltOZEF2R7GV2JI/cvZe?=
 =?us-ascii?Q?50kuirrGTbO19LK+1zwVmYdl+L7elgV7hsLmKu8nnpbzJ3oSWo20FZsCc+Bx?=
 =?us-ascii?Q?bFBol/4ejKQmqIaVnklZNkEGabHpQADJucay/Be8eM1q4sC+FfkrAvmtMmyc?=
 =?us-ascii?Q?+q+WHQzj5rR06oBWRYvIodlgUXxQL4c+4NcFosIKzkw79CPDNahLVCzxZmU4?=
 =?us-ascii?Q?s1t4XRB+ZWqW6iKoVpZXsi5gYO5596yt9EVvUeRCFusdWFeZ4znP7ELeHv4r?=
 =?us-ascii?Q?JkBAesyDGlQ1HEClW1sUZOr6QKc6Y1TCTripFUlDfAKWizzAbFRvxsZR1uZR?=
 =?us-ascii?Q?oSGk0eiSOTdKe/aZnbtr5WfUlotEnZoHF3M9OXDEFs7BhnBrn/jwrNdeUdfK?=
 =?us-ascii?Q?1mw/COcVhBTnuno+3+KrAzwOzjkc+dtqKdSYTBqkK3mF+7TfTCOJN4a24vhw?=
 =?us-ascii?Q?PF/oaLArhtt2LX1gJWUdyeMCjmdKBsDyLDgtk0jdH7AOpR3Ysm2RAKgSG40X?=
 =?us-ascii?Q?j28N2yFewnIJiVa7UlXJMjMsnj0lswXh98h4oSCNyDBWsU3T51aFd+AlJhW2?=
 =?us-ascii?Q?7Amyxd+lGPGlhe/faK0lHIHmls8iZz09IWBCOSd5U0pIvR076qqNjcfHtvGV?=
 =?us-ascii?Q?LQqAF15maQIKpRFxnxsstrzepYuWEApBV8KBCtmcI8BxoNyGzzgJ7kkJyq43?=
 =?us-ascii?Q?3QcW6xNPxd2LwC8ANP30q8+gSKRwdKmOvOihp3by24z1PeMNwBr4o5BtntEh?=
 =?us-ascii?Q?IrVl0TDgAy0TzfcuvpAl9XMJcVRCgCPwejefpG+bAjne28AcFkjSSzNwnriY?=
 =?us-ascii?Q?LeFniNge5RDF2nRw6TUE/I9iAcNoKguq/uMKyuMp?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26cd99ec-c628-4d57-0301-08dc076ca575
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2023 06:17:19.3046
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RLi0KA4hZtPjA4GioFSQIPWhEtk1fAKDLAExT8/WYb/ghg+MZCQaqJvUaCigW3/pidrYpddlwK2VkS8pEXdJLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4822
X-OriginatorOrg: intel.com

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, December 28, 2023 12:14 AM
>=20
> @@ -1376,6 +1383,8 @@ int qi_submit_sync(struct intel_iommu *iommu,
> struct qi_desc *desc,
>=20
>  restart:
>  	rc =3D 0;
> +	if (fault)
> +		*fault =3D 0;

move it to right before the loop of qi_check_fault()

>=20
>  	raw_spin_lock_irqsave(&qi->q_lock, flags);
>  	/*
> @@ -1430,7 +1439,7 @@ int qi_submit_sync(struct intel_iommu *iommu,
> struct qi_desc *desc,
>  		 * a deadlock where the interrupt context can wait
> indefinitely
>  		 * for free slots in the queue.
>  		 */
> -		rc =3D qi_check_fault(iommu, index, wait_index);
> +		rc =3D qi_check_fault(iommu, index, wait_index, fault);
>  		if (rc)
>  			break;

and as replied in another thread let's change qi_check_fault to return
-ETIMEDOUT to break the restart loop when fault pointer is valid.