Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp3802852rdb; Wed, 27 Dec 2023 23:41:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEP3d9Wce91pHejcy1znb29VTJXCEW1Eq95llEtqmI5HIUVG3YwwA2moezFi7BfWz0sURT3 X-Received: by 2002:a81:ac65:0:b0:5ea:ac12:d6bc with SMTP id z37-20020a81ac65000000b005eaac12d6bcmr3851384ywj.49.1703749292440; Wed, 27 Dec 2023 23:41:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703749292; cv=none; d=google.com; s=arc-20160816; b=QrXpUtgB8edzka7gh1NBhgIhx8GihqVsaY2I149mVJpY2HdjUz9+MYDocJ6lnRQR2O 678w0DyH60+yvGeE6j8ls4iRvykvQhBPnO6S3fARCVJUOBLhA86T/4xqFwy7COUDWN4t T0M0IyF4QddoGlVqoZ/TXw9eGp6om4uc5Qczt2fZikKNU6ow/BheC80eg1y/I07l7dpf 514RuO4KxJxOHG4RaQ7h5xMDN7RUiu7XGsJtU2QfobdUvRolpVQAfvQUCoSNzk00hzFV Dd8197s/BsybZfbv+GJBcdr8vx8PQ5wnaHWTqAlZIoCEWUrdCXgQKedsLrP4DPFBZ7yc Xflg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=R1jRQECzeG3GsegzdTQal/KRp9PeJ1Vov8kA8Na9www=; fh=jPTPjQDlPiPaOuognUviW/34STbjLYjh/ryqVrb6+KE=; b=Bw/6pbqGikOStc0CKhOVO0+DePNQa/Qug4/rXR59AWi71OxNKAWwl+VwnDC7XIUTo3 YNQj2SipPcMFLKLDEJ4FFrYG99k6GSf0A/rIejAYgf6Vk4pi5DE2hPUem8NrnLVZcZEY Nktlcef3n9GsJs0uo1b12vdCmGXLtqNvLlusSBeDxKcjcXzpP66/oMiLLcv6oJ5cqBc8 dTHvWPjXCuDx+R79DNsypWViULeMCI/HKIdJOyRih/BXTQb304gz6YKr/Gsxw3x6JjeY OSYyqESF2Krr5T4yhofemgHj6cNaLXaCgYR+0dKBudmYXc3bbEjfI6FUTT8JdVSFaD6z la9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dXXhr/j4"; spf=pass (google.com: domain of linux-kernel+bounces-12493-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12493-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h11-20020a37c44b000000b0078154ea9b59si5206854qkm.734.2023.12.27.23.41.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 23:41:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12493-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dXXhr/j4"; spf=pass (google.com: domain of linux-kernel+bounces-12493-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12493-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 249F71C21B52 for ; Thu, 28 Dec 2023 07:41:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0835746BF; Thu, 28 Dec 2023 07:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dXXhr/j4" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A54014402 for ; Thu, 28 Dec 2023 07:41:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3369339f638so4553437f8f.0 for ; Wed, 27 Dec 2023 23:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703749282; x=1704354082; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R1jRQECzeG3GsegzdTQal/KRp9PeJ1Vov8kA8Na9www=; b=dXXhr/j4gj9KoBwtvilj6VeFY6K4v6y18fpyaD+ccMGmQR7QVsqRzoYDmkl8jd4ZsP 65cPeckqvLeZg7YrV4EICVUMa3XZRHa3VK6LetJ2E6Hw7vysmpQ/+KoWEJ/qkh64DY1x 63Pz+t3PFd+ab4fGji/gKyVBs4KANAKZjo74Q2J2aDNFyqgXyLDDKZVe5S80AyfFdHnZ Fs/dScLqlTzSvXIxrVnFsavoXJzdxhI6T+WiSLXZlxDemzadMJlePv7DL/VIMfpPiDh/ 7F23y1lVUrr4ykDs/8JzIoy2rVAmfeER2Ub+3fRUPFzUIE4SlhsIPIAva+WISbG7JOfy ualg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703749282; x=1704354082; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R1jRQECzeG3GsegzdTQal/KRp9PeJ1Vov8kA8Na9www=; b=YqJCvRMZVsDjjd2ipx0Ndm2zvYMlG6Jg6eTN1tcYVNOGlLGP+EPVEkZe5YgIZxZePZ cXX+/o0tKwKH9ep+a3dSsD0oOjk6VaZoWjzgrOs353q2tDtoCGWZdQSQjK7uhbY14h+1 hLM20H6fq5SdXKMYvj1dTNK4zRkJG4kseKLDI1098eHwTPiWJG/T8WmQDdLTv31i0cl9 v3jXovIhYgN/fLB+aZFjSTjLx5H/G1FcR/8WEQo1kLqAg0jKaOt7VN5jhGsIIpKLwo8e tKLerzebIYGoOW7Dw4hdmpuje0xxUyF2tjkhFu6Yh6gXvYaWNdGDIi1POXzXOle5Pm/X xRpg== X-Gm-Message-State: AOJu0YzS4cbvDRGzDYrDLFDYNsukuHJXHzB8e/UTlVSOw9Safb7DuD0j 3PgfCEVxvsXZi5fpNylq+O47wcLZ0kkGxg== X-Received: by 2002:a5d:5405:0:b0:336:7ece:3f05 with SMTP id g5-20020a5d5405000000b003367ece3f05mr2760418wrv.20.1703749281885; Wed, 27 Dec 2023 23:41:21 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id p9-20020adfcc89000000b003368100ff71sm16344009wrj.10.2023.12.27.23.41.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Dec 2023 23:41:21 -0800 (PST) Message-ID: <9c0fdb52-6312-4b3a-9ed8-ca8f38d1010d@linaro.org> Date: Thu, 28 Dec 2023 08:41:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs Content-Language: en-US To: James Tai , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20231228060825.1380439-1-james.tai@realtek.com> <20231228060825.1380439-2-james.tai@realtek.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231228060825.1380439-2-james.tai@realtek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/12/2023 07:08, James Tai wrote: > Add the YAML documentation for Realtek DHC (Digital Home Center) SoCs. > > Signed-off-by: James Tai Thank you for your patch. There is something to discuss/improve. > + interrupts: > + minItems: 1 > + maxItems: 3 > + description: > + Contains the GIC SPI IRQs mapped to the external interrupt lines. > + > +required: > + - compatible > + - reg > + - interrupt-controller > + - '#interrupt-cells' > + - '#address-cells' > + - interrupts > + > +additionalProperties: false > + > +allOf: If there is going to be new version/resend, allOf: block goes before additionalProperties:. > + - $ref: /schemas/interrupt-controller.yaml# > + - if: > + properties: > + compatible: > + enum: > + - realtek,rtd1319-intc-iso > + then: > + properties: > + interrupts: > + minItems: 1 Why the second interrupt is optional? It's a SoC, the pins are not configurable usually. Same question for other cases. > +... Best regards, Krzysztof