Received-SPF: pass (google.com: domain of linux-kernel+bounces-12512-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <eb560b8d-e7e1-4af8-a585-78e50352c8f0@intel.com>
Date: Thu, 28 Dec 2023 16:32:40 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 06/10] iommufd/selftest: Add coverage for
 IOMMU_HWPT_INVALIDATE ioctl
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
References: <20231227161354.67701-1-yi.l.liu@intel.com>
 <20231227161354.67701-7-yi.l.liu@intel.com>
 <BN9PR11MB5276DEF13D2F64D244A932C68C9EA@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB5276DEF13D2F64D244A932C68C9EA@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTl6Qm1pYlU5WmpGSmxOdlZIdjg1ZmNDYVpiRjFlSkFGdURoa2dTK0pxUzNy?=
 =?utf-8?B?dzRyNWV5K3lKOXo0eElmWnZtTVByYVpYMmZ1NE03R1cwTTloRGJnSTZuSlhK?=
 =?utf-8?B?RjUwZUgwemtVbXRuWlhJRHVJVDBrbnNGTno1YzZxQUZPbmJDRmptUzY5aS9q?=
 =?utf-8?B?TjZlRTVnanRrOUk1K042clFRUFhmV1NNZFNnVTMvcjJGNlRRYU1sblFuMEpn?=
 =?utf-8?B?QzRZK0Q2NXAycW10eEdjRlRNVWhBVDhEYlErQk5BUzB3ZnpKRVFkS252MDFU?=
 =?utf-8?B?N1pGQVRXMWdiVDBwS1BMTmNZNDh3VEhVZi9HYU5nRzlwRGRUYkRjZVR2ckEz?=
 =?utf-8?B?OHZNbEFnWGRHZmUrNnBvTUFpeHdmYzJ3UjZRNmdzVU1rdDJYUENudE9FREVP?=
 =?utf-8?B?ZmJ4eTByNFEvM2JmSGdhbkovVUptSHExeDlOTmR5TFU2VUtrcmlGTnVRVjlh?=
 =?utf-8?B?OVQ4Nk41TC80Sko0V0VCeEdDYkIxVjRwMW9CUy9Od2E3YkwyR1JuV1JIYzk3?=
 =?utf-8?B?emtBcTJaZENHNXZhTXhxMzhwL2JIL1lSWU1UMzlnc0pISGRLK2RNVmp1UG9i?=
 =?utf-8?B?WkFNNXdjQUpzUEJHWFFDZWxURThveHpwM0lvR21SMGV2TVd2dlh4RDc1L2pX?=
 =?utf-8?B?YmIyKytuczVHSmdxTHpKcnczUFIzL1lVVGZMQVdFUy9ZenNGdWlEejFua09t?=
 =?utf-8?B?SWkrUS8zaktHbzJpU0krdGhFMFJVOHZYSmlBZlkvekdTTm8xRVZ3bFA1MjRD?=
 =?utf-8?B?bTg5VDZkU3JoblpjakJXNkVFbCt1ZUpVR1NtYXVrZHJwZ0Y1ME4rOWt0MmNC?=
 =?utf-8?B?NmRVK29EcGpZcnk2ME5zQzB4UW05dms0Z0x6a1NvR2p2ZUE1SUtjREpvK3Jh?=
 =?utf-8?B?WVF6c0VUY1NCdjNnVDBEbXBlUitGemJYcElRdEdrb0ROeENZb0FsNnYvTG1X?=
 =?utf-8?B?UWFKNFdjTGZXZzNJNnR0OVBGL0NLSjFaeitTOHpVZnRZUTcrcE9RbktHc3E3?=
 =?utf-8?B?QmFUTmlRSmhvbW9ORWk0R0psNy9hU0tweHg2QnVTQ1BYcnpiYUNNWHlYaUlR?=
 =?utf-8?B?RFZSWVI5d2dYbGxtS1RQZmQ3VEJ0WmFGTTlZbHhDOFBuakFHa01IeWhnQ0lH?=
 =?utf-8?B?VjJKS0xtWFRtYityUW81Qkt2M0E3M2Y0Nk1CMXhXQUwzOWovME16MEtOOWt1?=
 =?utf-8?B?M3hXZ0JvTDdYZGNPUmliYlo5NGxZcTdCMGw0UmdVTWgyMForSjU1eHFON3oy?=
 =?utf-8?B?QXE0MlVFT25oQ1I2U2ExV2lXM1g2MTkwNm11YnhTU3ZRU0Q3RXBqN1dNaGlk?=
 =?utf-8?B?SkZHVWZVYkJuWGd4eURZTjJ4SUxZQXVmUjJVajl6bzVPcDc5TGhWWFF5M05V?=
 =?utf-8?B?Vm1uYk1pZjVKUGlCVi9sMW1hUWtIZVc4UWFnamhraTVQWEUzNGpnSHRJRVBa?=
 =?utf-8?B?Qm1KUkRXQ09COU9lVUdQbXpIN3haeWFYRzRvcHRTRDdmdkxxS3pYTWFuSTJu?=
 =?utf-8?B?YWo4UkVYOUNsTWtwd1NtSDEzVFBBNkRuOEpxVEticXdLVzFuMlBPTUpQOTNB?=
 =?utf-8?B?MWpmb213cUgyZnpYREJyNVJab1dZOTY5SlBtTUc4a3VQd0sxcXhRR3o4a1Z5?=
 =?utf-8?B?OHVYdEsxYWFoVWFVT1lla2l3alpXWU4wL3J6MG1KZXlZeU4vcHlDbTVQdFBS?=
 =?utf-8?B?bXRIUVVjNEFlNVJ5RTQ1WHQ3NDh0bTBDZHF3VFNKL01lOU5xQi8vK2VYMEdF?=
 =?utf-8?B?TXlIR3BQQTdtQm5YeWloRWwzSW1Ca3hldHg3TDBmUkZoWlNFM1EyQVNwT1Vz?=
 =?utf-8?B?Y0Vldm5lcitCL2Q4SDhKcG5aV1dJTmNtMjUxd1dVVFRzSGJJN01iOE9YZ3pN?=
 =?utf-8?B?SGdmNkVPR2FCaFpqazR6M0dHNytTNTcySHRxUmJPZUN2VXJTN2lUWitnRmlI?=
 =?utf-8?B?RzkySEhTRVZ4aUFVM3Q0SDBHSlM3NHVvejBXUFlVMlNwQWlCaFp5cTQ5UHF2?=
 =?utf-8?B?OHlVb1V3ZHFuK2VvNHJlVlRFNG41dW1RSTNoNzNNZ2FBRVlTT1A0L1o5QVF3?=
 =?utf-8?B?b3Y3clA4NzIwUTZOSXJUWVdqeFBsSU8xeWI2a0JXbGluYkt3N0dQeVcwN043?=
 =?utf-8?Q?0fdNShfpH6N6Rgm360jDr5MHb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 012e1db5-678c-4776-d360-08dc077f29b7
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2023 08:29:52.6748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MGeZE4H+sg9fk6HLd+u3PnxabrZsVARzaXAPZfuyjxum5uCUzfaTgI4GVXV80SHkOOvY4+Zwt6wetiQFvM+snA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7163
X-OriginatorOrg: intel.com

On 2023/12/28 14:14, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Thursday, December 28, 2023 12:14 AM
>>
>> +		/* Negative test: trigger error */
>> +		num_inv = 1;
>> +		inv_reqs[0].flags =
>> IOMMU_TEST_INVALIDATE_FLAG_TRIGGER_ERROR;
>> +		inv_reqs[0].iotlb_id = 0;
>> +		test_cmd_hwpt_invalidate(nested_hwpt_id[0], inv_reqs,
>> +
>> IOMMU_HWPT_INVALIDATE_DATA_SELFTEST,
>> +					 sizeof(*inv_reqs), &num_inv);
>> +		assert(num_inv == 1);
>> +		assert(inv_reqs[0].hw_error ==
>> IOMMU_TEST_INVALIDATE_FAKE_ERROR);
>> +
> 
> instead of removing TRIGGER_ERROR|ALL err check, it makes more
> sense to keep it but making it a similar case as above.

yeah, but the config of TRIGGER_ERROR|ALL would be valid. is it?
Your point is to add another test case to see if "error" is generated
even if there is other flags set. is it?

-- 
Regards,
Yi Liu