Received-SPF: pass (google.com: domain of linux-kernel+bounces-12515-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <9370a5a7-6050-47f6-a3db-e042461a383b@intel.com>
Date: Thu, 28 Dec 2023 16:33:43 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 07/10] iommu/vt-d: Allow qi_submit_sync() to return the
 QI faults
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
References: <20231227161354.67701-1-yi.l.liu@intel.com>
 <20231227161354.67701-8-yi.l.liu@intel.com>
 <BN9PR11MB5276429906ED56258BB433068C9EA@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB5276429906ED56258BB433068C9EA@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHJDSGxObmdreXplMFlkaDZPemxCYTRBbUZqSjdreTk3a2ZDM05UT0sySE40?=
 =?utf-8?B?d1Q4WnF2WDdzZXBlcTc0UVVUeUw1Y1hDQVZ6T3drSmxTL3JTZ2o4dEFZWFBX?=
 =?utf-8?B?ZGVWK2dZaDdzWXpRTGhGRGx3SWNydGROc2hMdmF5WE1VMlZkR2JPNFNVWjdG?=
 =?utf-8?B?Y3N3Wlhxai8xakNXeVNXMjBQbHVpdkxiZnZUaTdDNmdXYmRiU2FiOWJSaVND?=
 =?utf-8?B?QkhLQW43VE40WUF2WlNsU2NvV0V0ZDNreTNSS1ZRZ25mRkxHc3lDamZSNFla?=
 =?utf-8?B?clc1Sy9YbVl4b05pNDRIcUdmbmhsWVdHYTZ4WXgvSGZNNHR4RWIzYUZ1YlY0?=
 =?utf-8?B?S1BGeHE1aWFGVDA5VzhDN0pub3hWOWFDQVI2bHhDdDJCSE1UTWhxYWFqVWha?=
 =?utf-8?B?QWpIYmIvUElyblMrekdySE5UWjkxUStvZ05YRUZSQ0x5d0hpYTNFTGFKMVJt?=
 =?utf-8?B?blQ5L2l3Y21XU0RFNU1lMUFFZ2RjOUhST01ndGx3dGM0Q3JFaVZVUThWdmlM?=
 =?utf-8?B?ZENOaWxVZ2hqUkN5ZUpjZGtqUW50Y0czVUh1bVExVGg3R21qYmpPaGVRZ2lE?=
 =?utf-8?B?NHJGWGozT1J3RW5vanJFTHRmakJRYS9UcjdaU0dwSGxrZXB3KytNdFRmc0sz?=
 =?utf-8?B?OEdyYWVtWm1wRE91K0wvbVhtVER3b3NaZmwyN0g0aU1NVnJ4UWl0aUxkZTZW?=
 =?utf-8?B?bTVMeWhsT2NhQnN1MHNYd3Q1UThPYWkrbVhiYnZNeWx4Y3AwaEdMOGZVRGw3?=
 =?utf-8?B?bC96Tm1HclpwZWljOTIvYUUvNHI3eVIxQU5zcVBwRmlMM3lmTVdPcVY4RElj?=
 =?utf-8?B?eTJGQlpuU1dkM2tTSEZ4NGp4L20wZ3RPNUxVRk1zV1ppOHovRmQ2ODVmanFX?=
 =?utf-8?B?UGVWbEJuVCtsWjJCNTJhZzBqZTkyaUpxYjkwYm9zZHhEVnZ1UzM3MmhaaEk0?=
 =?utf-8?B?cVVqV1pNSjR0Mi8vS3RlSm9JajVUQlNBdU1YejI3L1JPbmVsa3hFTjNyMVVK?=
 =?utf-8?B?QXVZZGFJeHV5YzRtaUFQdkE4VnE5ajRpU0FRWC83ZXlZc3ZNZXI5am05aHVT?=
 =?utf-8?B?dGFLUFl1SHhhK3VGUmJiK1l6b1piZklzblJkNW82SGhnaXZudGxaNnFPNHNj?=
 =?utf-8?B?Z3QrbHhKZXgvYytPME1nYVFvQVh1NFZ6d0tkODNPRjcwYXBPblYxRGdPNk5L?=
 =?utf-8?B?WS8rQ3FJdE9vZjhHUWxZNUtYNHgwaWY5dGZJR1NlaVMxYjgzeEsvbFNzUU01?=
 =?utf-8?B?NjB5bEpoUk1sbmtxVnNwcGswZnVvZmhHWFdvT1owakxkY2I2Y2VRMUExOGhZ?=
 =?utf-8?B?T0pLY0ozSmdzYUFjM05hWFp6MnAxYkhnam8zTFVyUkVtSFdCVTBmK3JtVWtS?=
 =?utf-8?B?eG80OGhnSWFQYW9DMHN2UEpqU3I2SkI3QURncUt2Yy9WYXFzN25RTk5Ic20r?=
 =?utf-8?B?ZWUyVkZHOWc4ZVpQTm5pUHpnMmdxSTVQaHY5VXRIZVZxZnp5RVovd0RDaDIr?=
 =?utf-8?B?dzJXSVA2OGt6b2pNVkxQaUs1MEU3djFCWXlKNnFaQlpSeVJoNW5vT3VqVG93?=
 =?utf-8?B?dVFpYjJidVZ6cmxjVWVWd2VucWhBNFBPeWorbldkaEpnUEU1M2xiT04ybkZs?=
 =?utf-8?B?ODJvV3FscitDQVdDNE9aRStNdDVLcmRmbjgvTmxsS0hQbElzNlc1TTg0N1Ba?=
 =?utf-8?B?L2dWcC9tMEpQbFdtbDhTekh5TE1UY2tML25XWE1hVGF5OU80eVdJNXdad1ho?=
 =?utf-8?B?K0ppbzUreW5XRFRMNk1GdVBZL1BIbTNRVjJOc2J2YnVUZGxDSkwvRzUrVW9P?=
 =?utf-8?B?Rnh0V3NxZ05nZExPaFVndnc5Y3d6U3NlenVadjF5WGwxTXBlcW0wZDRrWHR4?=
 =?utf-8?B?TmlOVGY3dDhrSDZiakJoVW5YdXZXM0lRbitKY0dBNHVJU3p3ZXdzYk92WVhU?=
 =?utf-8?B?a1J4RGZyb0M4c25YUFdnQ0F3Rm5lTnZOdG1JTDdTd1BYWkFCZmZULzgybXk1?=
 =?utf-8?B?R2NpT1JXK0JkYlUyaVR4VWJadGl0ZitHd1A0ZU96NW4wd0JYdlNLcDY3T0Fo?=
 =?utf-8?B?Z3o1bDgya1JVT3JUME5KK1F3V2hTTm9FYktzcGZHMkwrZzVDYnQzdHhVVGZi?=
 =?utf-8?Q?xUZDgy/GabStoprgpmlZvs45s?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ff017082-c698-4c1f-5824-08dc077f4d25
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2023 08:30:51.9608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C9CBLM9BzZJZJMQYLpJTgB8uV0mSA/inFly0Zys8Xr63kSGliA+K+fVAtsrVAuULkrqg08PggSHirtEy6DqFNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5474
X-OriginatorOrg: intel.com

On 2023/12/28 14:17, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Thursday, December 28, 2023 12:14 AM
>>
>> @@ -1376,6 +1383,8 @@ int qi_submit_sync(struct intel_iommu *iommu,
>> struct qi_desc *desc,
>>
>>   restart:
>>   	rc = 0;
>> +	if (fault)
>> +		*fault = 0;
> 
> move it to right before the loop of qi_check_fault()

ok.

>>
>>   	raw_spin_lock_irqsave(&qi->q_lock, flags);
>>   	/*
>> @@ -1430,7 +1439,7 @@ int qi_submit_sync(struct intel_iommu *iommu,
>> struct qi_desc *desc,
>>   		 * a deadlock where the interrupt context can wait
>> indefinitely
>>   		 * for free slots in the queue.
>>   		 */
>> -		rc = qi_check_fault(iommu, index, wait_index);
>> +		rc = qi_check_fault(iommu, index, wait_index, fault);
>>   		if (rc)
>>   			break;
> 
> and as replied in another thread let's change qi_check_fault to return
> -ETIMEDOUT to break the restart loop when fault pointer is valid.

sure.

-- 
Regards,
Yi Liu