Received-SPF: pass (google.com: domain of linux-kernel+bounces-12516-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9be98837-b656-49e5-8ae6-d70ad2c073b4@intel.com>
Date: Thu, 28 Dec 2023 16:35:13 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 09/10] iommufd: Add data structure for Intel VT-d
 stage-1 cache invalidation
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
References: <20231227161354.67701-1-yi.l.liu@intel.com>
 <20231227161354.67701-10-yi.l.liu@intel.com>
 <BN9PR11MB5276A53786CD3AF7F170E8B98C9EA@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB5276A53786CD3AF7F170E8B98C9EA@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3F0dFB6TXJPWlNBclROeGZyemRsWHlOTlJmV1B6QU0venNMcHpLVTIxb3h0?=
 =?utf-8?B?TllSVGhJKytoM21uWWZJN3dNcVh6TjJZanBQWEk3Z0xoaUdEOVlKNGN4OFhq?=
 =?utf-8?B?cG12YXpIeTRtK21ROXFabWJ4bGRGSTdnZkhGZVlPdElHZzd2MGx5MkFhN2dU?=
 =?utf-8?B?aGgrTzNxSDBtMDNSQUVyWEM1RERCYVY3azRMQ01mbEc2bFhxWXA3ajVkRWw0?=
 =?utf-8?B?aERzQitDWFg5UU5xeWphZ1haeWFhdlNtNmo5c0RDMWdJMENDWmRGYXFzc09n?=
 =?utf-8?B?MnFpTkl5ZzgrRm1XRjl5MVFMVDBpT2FHd0pOZHB3Tm93SXFnemlBY0JnWlRM?=
 =?utf-8?B?TUVlNU5jRENqY2VwUk4zdDFhWmQxMkJGTFliN0NaenFxOERqVmhSZmtLZk1s?=
 =?utf-8?B?eGlnK2NOUmZLQWQ1bUZQUGNEb2FiWHJDRDlUbzdkSThuMFRrMG5HdDNHZkcz?=
 =?utf-8?B?ZWd0Yi9uWmorYVJQMXg1djR4bytvRnZtSS91azhWeVVMS0wvYzdCdFN6ekZS?=
 =?utf-8?B?U3pVMUIxZFJJWit6TkZpNHRsY2kwSlJaNlVjeDdmcEhWMkVMWVdEL3hoZFk1?=
 =?utf-8?B?NnVPdFBaelh3bkEwTnVWcUpMeUFVbjVjNXlFTnhBaTE5Yko3N2JsSzV6eFdz?=
 =?utf-8?B?c2E1emdzbjJrS2J3QndMZTlYOUJRMzJWeTJmcHhSYzB5c2ZBcWorbW9jRmY5?=
 =?utf-8?B?dnlLbDJWRGpiWWd3QTBJcVYvSE1XL1RTeE9YQlpyaVg4MXA5eG9KZXNJOFZr?=
 =?utf-8?B?NnJmN3IySGN6cGVoNGVZVjBKYUhyL0k0M0FkQjZVYVJkRWl5cTMrem13dVUz?=
 =?utf-8?B?dFBvVS9WNlI2S0pqbyt4czhuVGszdWs5N0w3dDRrVEd2bWVpa1ZLL2dodklH?=
 =?utf-8?B?cUFzYlRKMU9SSGxMeC9WY2xxamh4NHo0TjJDRmgyZUhBS21NcHVkbkZWREY5?=
 =?utf-8?B?OUpQTWxYNVBZOFlOUXlWMWtYWUJDNWdUWEhxemowMGNxcHgyMmluVkNtMGlY?=
 =?utf-8?B?MEl5R3dQNk5jQ3BMMXhPQXcyc2VRYWR6b0tCM1VkNVZoTnp6bFBhV0NnN3ZV?=
 =?utf-8?B?Tmx4M09HZmZ5bU0wR2pGdEppTUk3UUdyMjJZNGtTR3Q2S3VoYjNaZzN4MmlZ?=
 =?utf-8?B?WWtoaGRWSlo4bWFtaUFHckZuVGNQS3RJdGJHL3pMWC9VajJUcTlXR1hrS0Fv?=
 =?utf-8?B?VWk1QVYyNGc1a2JlQmRXZ0dDQjVZUHB1aE5aZDBqbWFiamY0dS8zV0xvczNK?=
 =?utf-8?B?Skw3dkJwL1VyTUd5UjJ0c3BORWhCV005UjJ3YlpEeEVURGpjanpwd081ZU84?=
 =?utf-8?B?QW5zSHdVN2VRaEtCMGc4akNZMUo1S3hMaWRERHp0RXpRcVBXQ09vTmI1anN6?=
 =?utf-8?B?dHhrZjlpZ3FZNzExdW1mUlI3aEdyeTByOCtyQU9FWFJNSGI5a2VTZ2N4N050?=
 =?utf-8?B?eTBnWWJIRWc1RUsyTjRoYmYwalNYY1RWYVNJZnJoVlA4czlHNFBNVGdleTNN?=
 =?utf-8?B?dERqeGkzdzVFV2JpdVEzWFQ0ZUNLU3hHcVBFcy80NVoxSWx1b3o4VVpNeFUy?=
 =?utf-8?B?dlJhU0ZMVHVLUmh6b3hwT2pGZzRLRHNLSDhLNHRxMDFRK3l6R3VjaFZyNG53?=
 =?utf-8?B?NTdmYmxaVG5oSVJvNERQWkpHWHZZKytPMFFieDlMMWhWdWt1SERwc2M3MGtr?=
 =?utf-8?B?S2g1Ykx5TlZJWFdudURTOTVrK1lxUmlaVnkwM21WbWxEV1JlcEFUODYvNk4r?=
 =?utf-8?B?NWFFaW9SMGs4eDdGOXJqRjlBS3BiRFVkZXZPbW9FSHVnRlFLa1pFUGtubThu?=
 =?utf-8?B?YjVQNTB3dGIzK2NVMTYyWW5SSTl0Nm04aWg1R1F0ZjFlaktKV2FlbWtvdS9W?=
 =?utf-8?B?Qmpud0VZbGxhS1BXYkFqZExmNnY5N3lHRlFNK3BUNUlERERLRENxN2wrd0dz?=
 =?utf-8?B?SDJsMzhML3ZiNVBGaWZJOTlWZEpmNnV3TmtyZGd0OEszZlZCb01Pd204UnF3?=
 =?utf-8?B?SFZOd0xvYU1nTGRQTk5Kb1o1Qlg4TFlCejRTdVoydEtscmVmOXdpMEtlbEJF?=
 =?utf-8?B?UWxvMS9ONVBzeTR3bXdhMGNhaG9ScGErcGh5VDJCb1FaQUdGeEhSZUhFVG5z?=
 =?utf-8?Q?nyxJGW7048i+aP1b7MaN4ZHnn?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e06d89d4-0310-4b9e-8fb0-08dc077f8217
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2023 08:32:20.7964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jQhk7LB6w+fwPKe74flYHL/0CqAGQO04hSs7RSW5qQp3m+HX+mjoUiq6XAHeLTcnhG2JF7UjA9I7v8E7EXPuJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5474
X-OriginatorOrg: intel.com

On 2023/12/28 14:38, Tian, Kevin wrote:
>> From: Tian, Kevin
>> Sent: Thursday, December 28, 2023 2:38 PM
>>
>>> From: Liu, Yi L <yi.l.liu@intel.com>
>>> Sent: Thursday, December 28, 2023 12:14 AM
>>> +/**
>>> + * struct iommu_hwpt_vtd_s1_invalidate - Intel VT-d cache invalidation
>>> + *                                       (IOMMU_HWPT_INVALIDATE_DATA_VTD_S1)
>>> + * @addr: The start address of the range to be invalidated. It needs to
>>> + *        be 4KB aligned.
>>> + * @npages: Number of contiguous 4K pages to be invalidated.
>>> + * @flags: Combination of enum iommu_hwpt_vtd_s1_invalidate_flags
>>> + * @hw_error: One of enum iommu_hwpt_vtd_s1_invalidate_error
>>> + *
>>> + * The Intel VT-d specific invalidation data for user-managed stage-1 cache
>>> + * invalidation in nested translation. Userspace uses this structure to
>>> + * tell the impacted cache scope after modifying the stage-1 page table.
>>> + *
>>> + * Invalidating all the caches related to the page table by setting @addr
>>> + * to be 0 and @npages to be U64_MAX.
>>> + *
>>> + * The device TLB will be invalidated automatically if ATS is enabled.
>>> + *
>>> + * The @hw_error is meaningful when the entry is handled by the kernel.
>>> + * Check the entry_num output of IOMMU_HWPT_INVALIDATE ioctl to
>>> know the
>>> + * handled entries. @hw_error only covers the errors detected by
>> hardware.
>>> + * The software detected errors would go through the normal ioctl errno.
>>> + */
>>
>> * An entry is considered 'handled' after it passes the audit and submitted
>> * to the IOMMU by the underlying driver. Check the @entry_num output of
>> * struct iommu_hwpt_invalidate for the number of handled entries. A
>> 'handled'
>> * request may still fail in hardware for various reasons, e.g. due to timeout
>> * on waiting for device response upon a device TLB invalidation request. In
>> * such case the hardware error info is reported in the @hw_error field of the
>> * handled entry.
> 
> with that:
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

yep.

-- 
Regards,
Yi Liu