Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp3870187rdb; Thu, 28 Dec 2023 02:49:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyjAFB+cKbbmF+BxVc3dVrHPtJ/l8QFodZ8vO/bbT5luMoLHzwwQqqziLcFeTiV/xSAvZE X-Received: by 2002:a05:6214:a86:b0:680:d8b:52ee with SMTP id ev6-20020a0562140a8600b006800d8b52eemr6514095qvb.125.1703760576631; Thu, 28 Dec 2023 02:49:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703760576; cv=none; d=google.com; s=arc-20160816; b=OpUghITCGUYgmlR6SoAiJD6LujRRXalvvzeU4U3grCkjXJi6bUTdA7HdRqTBfRykcR DQNh17U83KBQldh7q2355DOhiCmPFNI7sY6TYUDQleJRNMfmIQiBHIGem6dAwgkILRCm Y3bTotBebuSsEX8//kU96afK/47HUBMaPFM1yPLU9zeU/2H4OdvKdCvEO+09F/kvc7a4 mitPk4s+hsq9zphDBh5b5Dy33kAgdMz59aZjGCY/T5WMyMHMVUIFPH71oYm2HU/g6Ytr DiE2iuUNwHsED0rvgPnplEbT6lcwRKgxArMms8m3Ql6wXrnZGcPLmEpHJLag4duwESww 2V5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=XUSvxM4FrF/uthD1ijBiu6GvPzMxWVTixwy5BIvC4l8=; fh=iIUc5/wk4xn6tEsNjWtIyMERF5eYNhc5ltYHS6rcfHM=; b=O0xM6y1vfv+tnKW7eNJPCVbjI5HZeRJLZIvOR1I5OzE60fHBRBCMuMVCEyfuVHGVXS TQfSmBMqmTQLjseDVZlbkBiFJIF/K+3m3ncJfigG4OUCgXcW0QLitx/uf4IrA/cO7ONQ NGTt50TCxX7sIuNVwrDI1gw+Is3W9uQd2CYTUqLy1NcTqg6IHXw8V9ohV8NEcqFbOwNO sUJg+mFd1VA2gqfrABcOtw4SV7pfTVyS317/5AHmOghd4HdYxHrzZ2no2rltCGgE+2t0 TtOOiYAH/bkNCBHE41KGLGsAZbUU3ix5H3olvjTGPXTTM9DJZj7DmdGe5X7oNcebeUx8 SEFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tlm1zSZA; spf=pass (google.com: domain of linux-kernel+bounces-12576-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12576-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j5-20020a05621419c500b0067fe0852ad9si9522478qvc.169.2023.12.28.02.49.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 02:49:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12576-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tlm1zSZA; spf=pass (google.com: domain of linux-kernel+bounces-12576-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12576-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 511631C21D6D for ; Thu, 28 Dec 2023 10:49:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 67A406FAC; Thu, 28 Dec 2023 10:49:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tlm1zSZA" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9553D6AA4; Thu, 28 Dec 2023 10:49:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DB01C433C7; Thu, 28 Dec 2023 10:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703760542; bh=kXdM8l6YBnsY84eHi4eZAnWpfsxkw1Psni5CMD4xugU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tlm1zSZAF9rDDu6xZHygpQ0OabYcZcvyfgPyltQddupRJkvBFHn68a0hm/WTVa4xe EeSWlnBIwp38QleElX+ZcxO/E1+y8IJboF7iO72KeGY7HNJ3LZzq+VYn10u89BPXt0 YluU2jfAVGMlJ43d3121Y/Fg4Vkzh7jwzmSPEtC9iYc75kbfZvCtDI/A4IXHbW8Vwa oBfqnd20y8uh6t2DwINznlxneOxlLrJXfNmXZdacJA3joCH6R33suHv8E9m7gSmM2c oCIJPl7Cs3Jl7i5o5BOgBrk+P1qUhVZ1IJr4MBZJXBhhLwWsym8a5caEKG5hWZBn1Y IKQ2xyPX7ekAA== From: Christian Brauner To: Jens Axboe , Jan Kara , Christophe JAILLET Cc: Christian Brauner , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH] block: Fix a memory leak in bdev_open_by_dev() Date: Thu, 28 Dec 2023 11:48:37 +0100 Message-ID: <20231228-marmorieren-frisch-f6677dbebc8c@brauner> X-Mailer: git-send-email 2.42.0 In-Reply-To: <8eaec334781e695810aaa383b55de00ca4ab1352.1703439383.git.christophe.jaillet@wanadoo.fr> References: <8eaec334781e695810aaa383b55de00ca4ab1352.1703439383.git.christophe.jaillet@wanadoo.fr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=941; i=brauner@kernel.org; h=from:subject:message-id; bh=Ax77AMZlSmHKwfAhMNiE2q9swju9T0TiGdasEacnqp0=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaT2BrUwaytwyK/ZMLcn7JzuL8fJH1Oiex7vD5h0wj7l0 Ip26TMPO0pZGMS4GGTFFFkc2k3C5ZbzVGw2ytSAmcPKBDKEgYtTACYSPo3hf+r5Jj9nrzcSre2M h6z/duwqVC+TvZ1dmDZvw9/rCu4quxgZDvjcNXiWyhj5af2vqyrN8fW3Fqlt2Rte1vtFhcGCR/E nEwA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit On Sun, 24 Dec 2023 18:36:42 +0100, Christophe JAILLET wrote: > If we early exit here, 'handle' needs to be freed, or some memory leaks. > > Applied to the vfs.super branch of the vfs/vfs.git tree. Patches in the vfs.super branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.super [1/1] block: Fix a memory leak in bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/8ff363ade395