Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754116AbXLKBPQ (ORCPT ); Mon, 10 Dec 2007 20:15:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751983AbXLKBPE (ORCPT ); Mon, 10 Dec 2007 20:15:04 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:54646 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751568AbXLKBPB (ORCPT ); Mon, 10 Dec 2007 20:15:01 -0500 Date: Mon, 10 Dec 2007 17:15:00 -0800 (PST) Message-Id: <20071210.171500.07031787.davem@davemloft.net> To: julia@diku.dk Cc: jdike@karaya.com, wangchen@cn.fujitsu.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/3] Fix use of skb after netif_rx From: David Miller In-Reply-To: References: X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 21 From: Julia Lawall Date: Sun, 9 Dec 2007 21:02:31 +0100 (CET) > From: Julia Lawall > > Recently, Wang Chen submitted a patch > (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb) > after a subsequent reference to skb, because netif_rx may call kfree_skb on > its argument. The same problem occurs in some other drivers as well. > > This was found using the following semantic match. > (http://www.emn.fr/x-info/coccinelle/) ... > Signed-off-by: Julia Lawall Patch applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/