Received-SPF: pass (google.com: domain of linux-kernel+bounces-12679-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 28 Dec 2023 05:22:56 -0800
From: Luis Chamberlain <mcgrof@kernel.org>
To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc: Kees Cook <keescook@chromium.org>,
	Joel Granados <j.granados@samsung.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH] sysctl: treewide: constify ctl_table_root::set_ownership
Message-ID: <ZY12sLZYlQ09zU6D@bombadil.infradead.org>
References: <20231226-sysctl-const-ownership-v1-1-d78fdd744ba1@weissschuh.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231226-sysctl-const-ownership-v1-1-d78fdd744ba1@weissschuh.net>
Sender: Luis Chamberlain <mcgrof@infradead.org>

On Tue, Dec 26, 2023 at 01:32:42PM +0100, Thomas Wei?schuh wrote:
> The set_ownership callback is not supposed to modify the ctl_table.
> Enforce this expectation via the typesystem.
> 
> The patch was created with the following coccinelle script:
> 
>   virtual patch
>   virtual context
>   virtual report

If you remove this virtual stuff and mention how we verify manually
through the build how users do not exits which rely on modifying the the
table I thinkt these two patches are ready, thanks for doing this in
Coccinelle it helps me review this faster!

  Luis