Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp4014639rdb; Thu, 28 Dec 2023 07:28:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdotVGgR10It279tyKqoH7S2cxXBLuYBsl1WKoRxN5hh8Q9XrUpJusFF0wQpkX5lfqrWJ7 X-Received: by 2002:a9d:6e91:0:b0:6d9:e00c:6253 with SMTP id a17-20020a9d6e91000000b006d9e00c6253mr7180394otr.56.1703777294513; Thu, 28 Dec 2023 07:28:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703777294; cv=none; d=google.com; s=arc-20160816; b=k7k2HltyS5uV+K8EUStqyql4BBSpa2axJ2BbpvWsTtEfssV4aCt6A7kW2xfZ/Mn3dz aO8LnR+DgCfGzWeFXArlsrMYMy2hGR1RE87NRNVPxlmiUOdrx007Al0Zy4r2DsbQvby1 E4/iCkOkadLe707yebBZeiJ05j1+Y0IMzIT0LxvEWZZnpb4fFGEF5dCE6QNRRFun4sGB SqS59/43NwJRpztBsBHTwskTHxOJ7w+g0KGlaMGz6Z15RbjeWrquPFe9T6GIDNhLKM0U jKqOy0tTaSlSJLl95U1scN0FFNROPRezK+lvhne97+r2h5p8r7TQ0OlKwlIsZmnIhsc9 aQww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=8hDCaGUiJOSlEvDP+89aklIHTn9TkTcAJHanG/8kP64=; fh=AVxFP4OEYlrPnZIRQLJ2tEtUp42+r7wDrVdq0+xiBRU=; b=mphtxa/aGMEq4G/6YHPW7kYZuq1UP5rY49LHsoeEHyMTu1ZmwmaIhyfsoQl9nEuUO6 gbCleedwRFknm8pF+eib7Z0JJaq7BcpNspV7FbWHR8UsCM9CsNL7wPKS4jzYwEUN5SF2 vO94o4Nkj0NdoH2J09UlK47FdoDDaugUE9JFYpPSzOSxd3x+p+MUiJgbRJsY/yjS7s+V KxxTVsR0l8fLNUGDvEog419ijjrc86mhgpKh4+9c+iwyDaPY6veoEyQHRUhWtWDdH0xJ HTN0Zdc0E0kcPZM/3M50ygQTW5jv7VTGH+atydd3+F9Z9Y+0gJ9SJgns91opzMcJC35p rlow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r5qXoWg7; spf=pass (google.com: domain of linux-kernel+bounces-12752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12752-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h5-20020ac87d45000000b0042787151f8csi17645707qtb.222.2023.12.28.07.28.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 07:28:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r5qXoWg7; spf=pass (google.com: domain of linux-kernel+bounces-12752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12752-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 312EE1C21E06 for ; Thu, 28 Dec 2023 15:28:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BA9D4E57C; Thu, 28 Dec 2023 15:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r5qXoWg7" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAC45F4E3; Thu, 28 Dec 2023 15:28:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18021C433C8; Thu, 28 Dec 2023 15:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703777286; bh=JKOcjvbYfHkJvn1sfMd5XKOIPk2AMe7CQiUb/va/zxg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=r5qXoWg7nLTtYiEnYHdKzq+NutZ211En0VUB1nGeCaJ5Dx7tptofG8LO3CxA9ANyd VWfQwjpzsUgEz+BtZN4n8rr5Civpc72+/z1oblWzqJYoMyJfFnfzPC3RvCLY9bczvD AufWE3785jXuHT1U7eEi9QtCVzcr/C2DScNPCF1YgjQNANoJev56MVXBFZuPpUtxIU qXIs35lceWr+CedKjJQSJ/iMkFuRIAO/I/msAv3+kUL/QKgyEhd7NNL+rZ0oTl7ejI WASe8MiGlg7Pal1k+I0N+4/sLw7chp8TCMAj9k8pfBWVZLmTNpTcUssGxTwzJS64qI XoYaargd8wZ8Q== Message-ID: <49f1ebee-c2c6-426a-8b85-69d8f5b65c65@kernel.org> Date: Thu, 28 Dec 2023 16:28:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V8 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA Content-Language: en-US To: "larry.lai" , lee@kernel.org, andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org, pavel@ucw.cz Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org, GaryWang@aaeon.com.tw, musa.lin@yunjingtech.com, jack.chang@yunjingtech.com, noah.hung@yunjingtech.com References: <20231228151544.14408-1-larry.lai@yunjingtech.com> <20231228151544.14408-3-larry.lai@yunjingtech.com> From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20231228151544.14408-3-larry.lai@yunjingtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/12/2023 16:15, larry.lai wrote: > The UP Squared board implements certain > features (pin control) through an on-board FPGA. > ... > +module_platform_driver_probe(upboard_pinctrl_driver, upboard_pinctrl_probe); > + > +MODULE_AUTHOR("Gary Wang "); > +MODULE_DESCRIPTION("UP Board HAT pin controller driver"); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("platform:upboard-pinctrl"); This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof