Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp4015468rdb; Thu, 28 Dec 2023 07:29:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHCvEAZNNw5R4kUg2MVLlfa6/34egrd4ppfqDJolm3/e2LIDD2rqV5CPKvBHgiHMCBkgGuH X-Received: by 2002:a05:6808:1453:b0:3bb:d089:266b with SMTP id x19-20020a056808145300b003bbd089266bmr1368327oiv.89.1703777395923; Thu, 28 Dec 2023 07:29:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703777395; cv=none; d=google.com; s=arc-20160816; b=AbF0/IferhQXCScpO55BBl2TYOLjzag/YioL0jYnG0978PxNV979R9DIwnsSlmL2jE 9rk0eT9asFOR4LE1PfGZ7A0Z86cBl0lFSLyI6zeQVvQ62qypfinJLsPVRLLJN35rsmm4 wgIXyVyJib7QqIXuaBKEplRYZIKAxBXWJezErsxH7+w1huqQHT1paPFakElJDHbmdqrv xP6/EiBL5DxUuKdPhiSXtUN/vi5sGBCk8YNFKXsROYoYJtOLHR1GDdYo7tm4IOhnuTIw 1Uh3QVqoLQhQJmcHG1cHFFWWVv4MBX2d/VRyNnuaymKUB/Ou1W82LOy9+Pr1Ibs17XoV bABw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=kLBmHLlRqZz+ebawZceeIQt67BCzupEfhBNvMK1xnME=; fh=AVxFP4OEYlrPnZIRQLJ2tEtUp42+r7wDrVdq0+xiBRU=; b=qsqrOa4V7DL/gWI3w3bfyi5/2S4LEY4QwBhQTFNOBdGJBDwFadPAwCT6vC7x5r1ScO +f4ChedhY6gxVXAzCbPfMfudPpRf5Z4fomb113AcQo7N+yee+7X8brUJRwdHIBWjDKtY TmK4/FHYEbYXv0oUENyGGRNC22Xl3DA00jqoS51V8grigbby4i4IgzuZ5z2uJwUisU/V 8wkNiqW6x4LqH0uIoBKgXBUnLaed1BKjLf6D0cBWebKVaBUdpN8twl+T2zFdnGn+sJMS o+jESCc1Y8z51aiPdJITo72YfwibebZ7vFydtaqKO4BT99MnJ9O29ndPzDNIaUoaymHm 1DCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IkhVO1si; spf=pass (google.com: domain of linux-kernel+bounces-12754-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12754-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s3-20020a0ce303000000b0067f911915easi3139440qvl.86.2023.12.28.07.29.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 07:29:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12754-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IkhVO1si; spf=pass (google.com: domain of linux-kernel+bounces-12754-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12754-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DA0771C23175 for ; Thu, 28 Dec 2023 15:29:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5FBB4F4E1; Thu, 28 Dec 2023 15:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IkhVO1si" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9064FE54E; Thu, 28 Dec 2023 15:29:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CA67C433C7; Thu, 28 Dec 2023 15:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703777385; bh=kGqaPiWe87W+qKQNuAZXfmZ46EmuGzB7sckchD9aWJk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IkhVO1si84o49z+Z7may5z0QqOod2xI559smAPq8dRAwZhmRoiz4JCt9KmfBYbc/I ku78kDR43P5rlwQ4Y8tAqXzHZODqmnwOEDotY4I2FEr3JBGCmg39xhpJJHRjnhdJ72 8aK/S+RSaI2q3aPUYKihGHOaXV0bRlAbdpD4tiPfUDwsIBQ/upjal6ajLx7Uc4mvIa xZjFj/QvziZAuOutOBD2GV7sWkBFfgjnQ4xdq9sX1gzXImIgQsTe/YFiwV7yF8oHUY VF88N6987Iwks3oEZ1SCmrC5Sw9prmuQOSLMTiF7YOZvLwH/nyM4U4h3iTlfFQlMnG NzN8pK+gqApUg== Message-ID: Date: Thu, 28 Dec 2023 16:29:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V8 3/3] leds: Add support for UP board CPLD onboard LEDS Content-Language: en-US To: "larry.lai" , lee@kernel.org, andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org, pavel@ucw.cz Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org, GaryWang@aaeon.com.tw, musa.lin@yunjingtech.com, jack.chang@yunjingtech.com, noah.hung@yunjingtech.com References: <20231228151544.14408-1-larry.lai@yunjingtech.com> <20231228151544.14408-4-larry.lai@yunjingtech.com> From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20231228151544.14408-4-larry.lai@yunjingtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/12/2023 16:15, larry.lai wrote: > The UP boards come with a few FPGA-controlled onboard LEDs: > * UP Board: yellow, green, red > * UP Squared: blue, yellow, green, red > ... > + > +static int upboard_led_probe(struct platform_device *pdev) > +{ > + struct upboard_fpga * const cpld = dev_get_drvdata(pdev->dev.parent); > + struct reg_field fldconf = { > + .reg = UPFPGA_REG_FUNC_EN0, > + }; > + struct upboard_led_data * const pdata = pdev->dev.platform_data; Your const does not make sense. Please read C standard how qualifiers are applied. ... > +module_platform_driver_probe(upboard_led_driver, upboard_led_probe); > + > +MODULE_AUTHOR("Gary Wang "); > +MODULE_DESCRIPTION("UP Board LED driver"); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("platform:upboard-led"); Nothing improved here. This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof