Received-SPF: pass (google.com: domain of linux-kernel+bounces-12760-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 28 Dec 2023 16:32:54 +0100
From: Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= <u.kleine-koenig@pengutronix.de>
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/11] firmware: turris-mox-rwtm: Convert to platform
 remove callback returning void
Message-ID: <20231228163254.72b770ba@dellmb>
In-Reply-To: <9074d1ad2e889425991fecad664781ae27b2418a.1703693980.git.u.kleine-koenig@pengutronix.de>
References: <cover.1703693980.git.u.kleine-koenig@pengutronix.de>
	<9074d1ad2e889425991fecad664781ae27b2418a.1703693980.git.u.kleine-koenig@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 27 Dec 2023 17:26:34 +0100
Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de> wrote:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>=20
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>=20
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/firmware/turris-mox-rwtm.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris=
-mox-rwtm.c
> index 2de0fb139ce1..31d962cdd6eb 100644
> --- a/drivers/firmware/turris-mox-rwtm.c
> +++ b/drivers/firmware/turris-mox-rwtm.c
> @@ -554,7 +554,7 @@ static int turris_mox_rwtm_probe(struct platform_devi=
ce *pdev)
>  	return ret;
>  }
> =20
> -static int turris_mox_rwtm_remove(struct platform_device *pdev)
> +static void turris_mox_rwtm_remove(struct platform_device *pdev)
>  {
>  	struct mox_rwtm *rwtm =3D platform_get_drvdata(pdev);
> =20
> @@ -562,8 +562,6 @@ static int turris_mox_rwtm_remove(struct platform_dev=
ice *pdev)
>  	sysfs_remove_files(rwtm_to_kobj(rwtm), mox_rwtm_attrs);
>  	kobject_put(rwtm_to_kobj(rwtm));
>  	mbox_free_channel(rwtm->mbox);
> -
> -	return 0;
>  }
> =20
>  static const struct of_device_id turris_mox_rwtm_match[] =3D {
> @@ -576,7 +574,7 @@ MODULE_DEVICE_TABLE(of, turris_mox_rwtm_match);
> =20
>  static struct platform_driver turris_mox_rwtm_driver =3D {
>  	.probe	=3D turris_mox_rwtm_probe,
> -	.remove	=3D turris_mox_rwtm_remove,
> +	.remove_new =3D turris_mox_rwtm_remove,
>  	.driver	=3D {
>  		.name		=3D DRIVER_NAME,
>  		.of_match_table	=3D turris_mox_rwtm_match,

Reviewed-by: Marek Beh=C3=BAn <kabel@kernel.org>