Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp4048780rdb; Thu, 28 Dec 2023 08:26:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+pXIvAa/v0hdAvXQ7yk6LIJTpKYD22fEOujIaXlv7waiGcBsLhDzCI345uJah8AbnjeRj X-Received: by 2002:a05:6e02:1c89:b0:35f:f67b:b004 with SMTP id w9-20020a056e021c8900b0035ff67bb004mr6681485ill.15.1703780774376; Thu, 28 Dec 2023 08:26:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703780774; cv=none; d=google.com; s=arc-20160816; b=lq3KkYnXmPS5XI45BGUBCDgS6EmpBgNaOpEHRcq89Xc2ML+DFEm6AkNyUhP0Zw3Lic JuI9gAGEAbVyFC39FqQyq96+99Zpq8H/768O+ekxrlYWxxOHKS9oDh4Ll1mgTYp4sEK5 O2nPI04wHhGH4k+QHcn3mXAHeqyPKNptNuIgKzGV/Bgv1EmMjZejaq+okf3rq0KNjVwZ i00dvo/jZAMcnP2BJEurlvL7Vkse22czMbPwYi54XfHAAkM6Y87GBhSj+kqzpwRX17bv vrT14UyNBkQ7sRAzohf5Fg16SNidn8b1oElpULCu1aEKrCd8uFd8jfKcwoMIKlyEXDB2 HeYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KpMAxSo0RJhFE0xqa9S3nLNvZVhAutJM3iE4mqxHHPM=; fh=clMW8qq0496gMnE7nGy7VZctbwtSbS9u9PcJv0YWbC4=; b=PKp3D1xn1EQfi1AvX1rCaBF8a6eAEyT2ld+k2WNRCHWupFDcWG+mHw23uPGQykEegR O2neMcXa/SwOVpdvl4SlM70asyzWsNtIuX0HHxY0eZawGgZPqNokBx5i1ao3n9t+zIKS nr3/leHvpBQDY0ulenfO2aoRUhGwsliUeLdjYesFoz6n4iRvgrSnZ69oLYGgyxaSdZnp Thbz0DhYc5LSdzzvO+5QAMuBYSTtFE6ZH1Tbn0EZTaBuAI1k1+yfbL6ABl6L7E+n+U1b PILMLLwcOqqm/xIsb7gDBkIs1bH0ngV5x6xcUCdK6dzMhCasjmxly2xX9RwY3y8XJ504 Bt/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W4wAEZlt; spf=pass (google.com: domain of linux-kernel+bounces-12774-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12774-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b2-20020a655cc2000000b005cd8f461cf1si12607418pgt.515.2023.12.28.08.26.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 08:26:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12774-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W4wAEZlt; spf=pass (google.com: domain of linux-kernel+bounces-12774-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12774-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0FFE0284B7B for ; Thu, 28 Dec 2023 16:26:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2C59BF511; Thu, 28 Dec 2023 16:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="W4wAEZlt" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED797F4F8 for ; Thu, 28 Dec 2023 16:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703780767; x=1735316767; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cquyNjhYzpwCizk15rHvGi0L/xABUbBm6EGekJs4+08=; b=W4wAEZlteqYxn20YJa14AdGnGk8CPc5tkC/SBKukVPbu1wFnQt9s9SNc 5LTWslu/fYDIGdQLQALI+c29OYepTimQc6ASiFYYqBXR/FTqmGu2LZpS7 QGw3PIO3qBB7wuZM1QuZIoZCr3E60Tufl0AyMLF0cfyarEvgTjUZkp3+p Q9SL5ZY+6T6NvDHC8zStpRcoU++Z+kmpY68PBM79XGjIHTx8/Ki8VOjMe xsxtao0NtVF6uZV/9eHc0GZMzJ9/pf4zny/QM4Fehlj9Y4eL8zjFNwHIi l4bMrHIH1oSY8LSbxxn+Sc2lOpV5subpJvqDu23gB/EWMoSYta8nq4Lqw w==; X-IronPort-AV: E=McAfee;i="6600,9927,10937"; a="3855075" X-IronPort-AV: E=Sophos;i="6.04,312,1695711600"; d="scan'208";a="3855075" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2023 08:26:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10937"; a="728350199" X-IronPort-AV: E=Sophos;i="6.04,312,1695711600"; d="scan'208";a="728350199" Received: from ceyeghel-mobl.amr.corp.intel.com (HELO intel.com) ([10.252.50.226]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2023 08:26:03 -0800 Date: Thu, 28 Dec 2023 17:25:59 +0100 From: Andi Shyti To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Jonathan Corbet , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi Subject: Re: [PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings Message-ID: References: <20231226195432.10891-1-rdunlap@infradead.org> <20231226195432.10891-2-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231226195432.10891-2-rdunlap@infradead.org> Hi Randy, ... > /** > * struct intel_gsc - graphics security controller > * > - * @gem_obj: scratch memory GSC operations > - * @intf : gsc interface > + * @intf : gsc interface > + * @intf.adev : MEI aux. device for this @intf > + * @intf.gem_obj : scratch memory GSC operations > + * @intf.irq : IRQ for this device (%-1 for no IRQ) > + * @intf.id : this interface's id number/index > */ I don't really like the tabs here and the space before the ':', which makes it a bit harder to read. Besides it doesn't look consistent with the rest of the documentation. Otherwise, looks good. Andi