Received-SPF: pass (google.com: domain of linux-kernel+bounces-12777-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <ZY1Pk61PP5HvLDag@p100>
In-Reply-To: <ZY1Pk61PP5HvLDag@p100>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Fri, 29 Dec 2023 01:32:26 +0900
Message-ID: <CAK7LNATmQSB-ZhQf6FyhK0Y7y6J91pVGN5NF2=FjUE9vJLkDCg@mail.gmail.com>
Subject: Re: [PATCH] linux/export: Ensure natural alignment of kcrctab array
To: Helge Deller <deller@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 28, 2023 at 7:36=E2=80=AFPM Helge Deller <deller@kernel.org> wr=
ote:
>
> The ___kcrctab section holds an array of 32-bit CRC values.
> Add a .balign 4 to tell the linker the correct memory alignment.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> Fixes: f3304ecd7f06 ("linux/export: use inline assembler to populate symb=
ol CRCs")
> Link: https://lore.kernel.org/r/CAK7LNAT5gyn0C9EJhh1EeFT7gF0rOudWcdqAVN=
=3D+C4jR42W90w@mail.gmail.com/


Applied to linux-kbuild/fixes.
Thanks!


> diff --git a/include/linux/export-internal.h b/include/linux/export-inter=
nal.h
> index 69501e0ec239..51b8cf3f60ef 100644
> --- a/include/linux/export-internal.h
> +++ b/include/linux/export-internal.h
> @@ -61,6 +61,7 @@
>
>  #define SYMBOL_CRC(sym, crc, sec)   \
>         asm(".section \"___kcrctab" sec "+" #sym "\",\"a\""     "\n" \
> +           ".balign 4"                                         "\n" \
>             "__crc_" #sym ":"                                   "\n" \
>             ".long " #crc                                       "\n" \
>             ".previous"                                         "\n")


--=20
Best Regards
Masahiro Yamada