Received-SPF: pass (google.com: domain of linux-kernel+bounces-12779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 28 Dec 2023 17:40:44 +0100
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member
 kernel-doc warnings
Message-ID: <ZY2lDJ4BkwO1AZGj@ashyti-mobl2.lan>
References: <20231226195432.10891-1-rdunlap@infradead.org>
 <20231226195432.10891-3-rdunlap@infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231226195432.10891-3-rdunlap@infradead.org>

Hi Randy,

[...]

> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> @@ -105,61 +105,67 @@ struct intel_guc {
>  	 */


struct { } interrupts is missing here.

>  	struct {
>  		/**
> -		 * @lock: protects everything in submission_state,
> -		 * ce->guc_id.id, and ce->guc_id.ref when transitioning in and

[...]

> +		 * we start bypassing the schedule disable delay
>  		 */
>  		unsigned int sched_disable_gucid_threshold;
>  	} submission_state;

Here struct { } send_regs is missing

But as for this patch:

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi

>  	struct {
>  		/**
> -		 * @lock: Lock protecting the below fields and the engine stats.
> +		 * @timestamp.lock: Lock protecting the below fields and

[...]