Received-SPF: pass (google.com: domain of linux-kernel+bounces-12819-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 28 Dec 2023 17:28:48 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: jyri.sarha@iki.fi
Message-ID: <7fee3509faf9d134db2f537dccacbc1adf284cce@iki.fi>
To: "Philipp Stanner" <pstanner@redhat.com>, "Jyri Sarha"
 <jyri.sarha@iki.fi>, "Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
 "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>, "Maxime Ripard"
 <mripard@kernel.org>, "Thomas Zimmermann" <tzimmermann@suse.de>, "David
 Airlie" <airlied@gmail.com>, "Daniel Vetter" <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: undefined
Subject: Re: [PATCH] drm/tilcdc: request and mapp iomem with devres

December 22, 2023 at 1:52 PM, "Philipp Stanner" <pstanner@redhat.com mail=
to:pstanner@redhat.com?to=3D%22Philipp%20Stanner%22%20%3Cpstanner%40redha=
t.com%3E > wrote:

>=20
>=20tilcdc currently just ioremaps its iomem, without doing the (a bit mo=
re
> robust) request on the memory first. The devm_ functions provide a hand=
y
> way to both request and ioremap the memory with automatic cleanup.
>=20
>=20Replace the manual ioremap with the devm_ version.
>=20
>=20Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Philipp Stanner <pstanner@redhat.com>

Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
Tested-by: Jyri Sarha <jyri.sarha@iki.fi>

I'll apply this shortly to drm-misc-next.

Thanks,
Jyri

> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 19 ++++---------------
> 1 file changed, 4 insertions(+), 15 deletions(-)
>=20
>=20diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/ti=
lcdc/tilcdc_drv.c
> index 8ebd7134ee21..2ad3f44a6e2d 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -182,9 +182,6 @@ static void tilcdc_fini(struct drm_device *dev)
>  if (priv->clk)
>  clk_put(priv->clk);
>=20
>=20- if (priv->mmio)
> - iounmap(priv->mmio);
> -
>  if (priv->wq)
>  destroy_workqueue(priv->wq);
>=20
>=20@@ -201,7 +198,6 @@ static int tilcdc_init(const struct drm_driver *d=
drv, struct device *dev)
>  struct platform_device *pdev =3D to_platform_device(dev);
>  struct device_node *node =3D dev->of_node;
>  struct tilcdc_drm_private *priv;
> - struct resource *res;
>  u32 bpp =3D 0;
>  int ret;
>=20
>=20@@ -226,17 +222,10 @@ static int tilcdc_init(const struct drm_driver =
*ddrv, struct device *dev)
>  goto init_failed;
>  }
>=20
>=20- res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "failed to get memory resource\n");
> - ret =3D -EINVAL;
> - goto init_failed;
> - }
> -
> - priv->mmio =3D ioremap(res->start, resource_size(res));
> - if (!priv->mmio) {
> - dev_err(dev, "failed to ioremap\n");
> - ret =3D -ENOMEM;
> + priv->mmio =3D devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(priv->mmio)) {
> + dev_err(dev, "failed to request / ioremap\n");
> + ret =3D PTR_ERR(priv->mmio);
>  goto init_failed;
>  }
>=20
>=20--=20
>=202.43.0
>