Received-SPF: pass (google.com: domain of linux-kernel+bounces-12830-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231228061802.25280-1-v-songbaohua@oppo.com>
In-Reply-To: <20231228061802.25280-1-v-songbaohua@oppo.com>
From: Nhat Pham <nphamcs@gmail.com>
Date: Thu, 28 Dec 2023 11:19:08 -0800
Message-ID: <CAKEwX=Njnwzf-TRTOp_L0wvzGnH+kQb8HJ9x_b6vt+FncOhgWw@mail.gmail.com>
Subject: Re: [PATCH] mm: zsmalloc: return -ENOSPC rather than -EINVAL in
 zs_malloc while size is too large
To: Barry Song <21cnbao@gmail.com>
Cc: minchan@kernel.org, senozhatsky@chromium.org, akpm@linux-foundation.org, 
	linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com, 
	vitaly.wool@konsulko.com, linux-kernel@vger.kernel.org, chriscli@google.com, 
	chrisl@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, 
	zhouchengming@bytedance.com, Barry Song <v-songbaohua@oppo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 27, 2023 at 10:18=E2=80=AFPM Barry Song <21cnbao@gmail.com> wro=
te:
>
> This is the case the "compressed" data is larger than the original data,
> it is better to return -ENOSPC which can help zswap record a poor compr
> rather than an invalid request. Then we get more friendly counting for
> reject_compress_poor in debugfs.
>
>  bool zswap_store(struct folio *folio)
>  {
>         ...
>         ret =3D zpool_malloc(zpool, dlen, gfp, &handle);
>         if (ret =3D=3D -ENOSPC) {
>                 zswap_reject_compress_poor++;
>                 goto put_dstmem;
>         }
>         if (ret) {
>                 zswap_reject_alloc_fail++;
>                 goto put_dstmem;
>         }
>         ...
>  }
>
> Also, zbud_alloc() and z3fold_alloc() are returning ENOSPC in the same
> case, eg
>  static int z3fold_alloc(struct z3fold_pool *pool, size_t size, gfp_t gfp=
,
>                         unsigned long *handle)
>  {
>         ...
>         if (!size || (gfp & __GFP_HIGHMEM))
>                 return -EINVAL;
>
>         if (size > PAGE_SIZE)
>                 return -ENOSPC;
>         ...
>  }
>
> Signed-off-by: Barry Song <v-songbaohua@oppo.com>
> ---
>  mm/zsmalloc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index b1c0dad7f4cf..c937635e0ad1 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -1364,9 +1364,12 @@ unsigned long zs_malloc(struct zs_pool *pool, size=
_t size, gfp_t gfp)
>         int newfg;
>         struct zspage *zspage;
>
> -       if (unlikely(!size || size > ZS_MAX_ALLOC_SIZE))
> +       if (unlikely(!size))
>                 return (unsigned long)ERR_PTR(-EINVAL);
>
> +       if (unlikely(size > ZS_MAX_ALLOC_SIZE))
> +               return (unsigned long)ERR_PTR(-ENOSPC);
> +
>         handle =3D cache_alloc_handle(pool, gfp);
>         if (!handle)
>                 return (unsigned long)ERR_PTR(-ENOMEM);
> --
> 2.34.1
>

LGTM.
Reviewed-by: Nhat Pham <nphamcs@gmail.com>