Received-SPF: pass (google.com: domain of linux-kernel+bounces-12863-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 28 Dec 2023 22:25:11 +0100
From: Borislav Petkov <bp@alien8.de>
To: Tanzir Hasan <tanzirh@google.com>
Cc: Andy Lutomirski <luto@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
	Nick Desaulniers <nnn@google.com>
Subject: Re: [PATCH] x86/vdso: shrink vdso/extable.i via IWYU
Message-ID: <20231228212511.GCZY3nt3gKI+aDvSF1@fat_crate.local>
References: <20231228-extable-v1-1-32a18c66b440@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231228-extable-v1-1-32a18c66b440@google.com>

On Thu, Dec 28, 2023 at 08:56:35PM +0000, Tanzir Hasan wrote:
> This diff uses an open source tool include-what-you-use (IWYU) to modify
> the include list, changing indirect includes to direct includes. IWYU is
> implemented using the IWYUScripts github repository which is a tool that
> is currently undergoing development. These changes seek to improve build
> times.
> 
> This change to vdso/extable.c resulted in a preprocessed size of
> vdso/extable.i from 64332 lines to 45377 lines (-27%) for the x86
> defconfig.

Maybe I'm missing something but this sounds like the build-time
"improvement" is so minute that you have to look at preprocessed sizes.

Do you have any, more "noticeable" numbers to justify this churn?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette