Message-ID: <475DFEF9.6060006@highpoint-tech.com>
Date: Tue, 11 Dec 2007 11:07:37 +0800
From: HighPoint Linux Team <linux@highpoint-tech.com>
Reply-To: linux@highpoint-tech.com
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: Matthew Wilcox <matthew@wil.cx>
CC: Andrew Morton <akpm@linux-foundation.org>, linux-scsi@vger.kernel.org,
       linux-kernel@vger.kernel.org, James.Bottomley@SteelEye.com
Subject: Re: [PATCH][SCSI] hptiop: add more adapter models and other fixes
References: <200712101354.53575.linux@highpoint-tech.com> <20071210165030.GB26334@parisc-linux.org>
In-Reply-To: <20071210165030.GB26334@parisc-linux.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1096
Lines: 28

Matthew Wilcox wrote:
 >> - add more PCI device IDs
 >> - support for adapters based on Marvell IOP
 >
 > Are you sure it's a good idea to do this?  This patch is 1200 lines long
 > ... the same size as the existing driver:
 >
 > $ wc drivers/scsi/hptiop.*
 >   947  2273 24531 drivers/scsi/hptiop.c
 >   256   612  6175 drivers/scsi/hptiop.h
 >   1203  2885 30706 total
 >
 > That suggests to me there's not much commonality between the two drivers,
 > and you'd be better off adding a second driver for the 4xxx cards

The new adapter implementation adds to the driver about 300 lines of
code (some lines in the original driver was changed slightly to accommodate
the difference). It is only different from the original models on the
messaging interface, and still shares same firmware command block
structures and work flow.

HighPoint Linux Team

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/