Received-SPF: pass (google.com: domain of linux-kernel+bounces-12944-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <a22047ed-22e2-4b7f-9a61-16e9f77f3ba2@intel.com>
Date: Fri, 29 Dec 2023 12:41:18 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 3/4] KVM: X86: Add a capability to configure bus
 frequency for APIC timer
Content-Language: en-US
To: Isaku Yamahata <isaku.yamahata@intel.com>, kvm@vger.kernel.org,
 linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
 erdemaktas@google.com, Sean Christopherson <seanjc@google.com>,
 Vishal Annapurve <vannapurve@google.com>, Jim Mattson <jmattson@google.com>,
 Maxim Levitsky <mlevitsk@redhat.com>
Cc: isaku.yamahata@gmail.com
References: <cover.1702974319.git.isaku.yamahata@intel.com>
 <f393da364d3389f8e65c7fae3e5d9210ffe7a2db.1702974319.git.isaku.yamahata@intel.com>
From: Xiaoyao Li <xiaoyao.li@intel.com>
In-Reply-To: <f393da364d3389f8e65c7fae3e5d9210ffe7a2db.1702974319.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/19/2023 4:34 PM, Isaku Yamahata wrote:
> +7.34 KVM_CAP_X86_BUS_FREQUENCY_CONTROL
> +--------------------------------------
> +
> +:Architectures: x86
> +:Target: VM
> +:Parameters: args[0] is the value of apic bus clock frequency
> +:Returns: 0 on success, -EINVAL if args[0] contains invalid value for the
> +          frequency, or -ENXIO if virtual local APIC isn't enabled by
> +          KVM_CREATE_IRQCHIP, or -EBUSY if any vcpu is created.
> +
> +This capability sets the APIC bus clock frequency (or core crystal clock
> +frequency) for kvm to emulate APIC in the kernel.  

Isaku,

you are mixing the `bus clock` and `core crystal clock` frequency. They 
are different.

- When CPUID 0x15 doesn't exist, or CPUID 0x15 doesn't enumerate core 
crystal clock frequency, the APIC timer frequency is the processor's bus 
clock.

- When CPUID 0x15 does enumerate the core crystal clock frequency, the 
APIC timer frequency is the core crystal clock frequency.

This patch only enables the user-configurable bus clock frequency, or 
specifically APIC timer frequency. It doesn't enable the configuration 
of core crystal clock frequency. Userspace can configure core crystal 
clock frequency by passing a valid CPUID 0x15 leaf into KVM_SET_CPUID2, 
not by this KVM_CAP.

> The default value is 1000000
> +(1GHz).