Received-SPF: pass (google.com: domain of linux-kernel+bounces-12994-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <48943ae1-1d7f-44a6-97de-d2999b5f72a2@starfivetech.com>
Date: Fri, 29 Dec 2023 16:31:44 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 2/2] ASoC: starfive: Add drivers of Cadence
 Multi-Channel I2S Controller
Content-Language: en-US
To: Mark Brown <broonie@kernel.org>
CC: Liam Girdwood <lgirdwood@gmail.com>, Claudiu Beznea
	<Claudiu.Beznea@microchip.com>, Jaroslav Kysela <perex@perex.cz>, "Takashi
 Iwai" <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
	<conor.dooley@microchip.com>, Walker Chen <walker.chen@starfivetech.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<alsa-devel@alsa-project.org>, <linux-sound@vger.kernel.org>
References: <20231221033223.73201-1-xingyu.wu@starfivetech.com>
 <20231221033223.73201-3-xingyu.wu@starfivetech.com>
 <861f9b28-863d-48b0-8491-add4a286597e@sirena.org.uk>
 <c94b377a-1e21-4361-ae82-ca84d1dce60a@starfivetech.com>
 <27155281-573c-493d-96fe-1f28ebb0ce5e@sirena.org.uk>
From: Xingyu Wu <xingyu.wu@starfivetech.com>
In-Reply-To: <27155281-573c-493d-96fe-1f28ebb0ce5e@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 2023/12/22 20:39, Mark Brown wrote:
> On Fri, Dec 22, 2023 at 05:11:17PM +0800, Xingyu Wu wrote:
>> On 2023/12/21 20:55, Mark Brown wrote:
>> > On Thu, Dec 21, 2023 at 11:32:23AM +0800, Xingyu Wu wrote:
> 
>> >>  sound/soc/starfive/cdns-jh8100-i2s-pcm.c | 262 ++++++++
>> >>  sound/soc/starfive/cdns-jh8100-i2s.c     | 727 +++++++++++++++++++++++
>> >>  sound/soc/starfive/cdns-jh8100-i2s.h     | 171 ++++++
> 
>> > If this is a Cadence IP why is the entire driver SoC specific?
> 
>> This a new driver about this Cadence I2S controller. Should I create a new folder and file like this:
> 
>> sound/soc/cdns/cdns-i2s*
> 
>> and I use different compatible to support other SoC like JH8100?
> 
> Yes, that seems more what I'd expect - with a fallback compatible for
> things that don't need any special quirks.

Okay, I will modify these in next version.

Thanks,
Xingyu Wu