Received-SPF: pass (google.com: domain of linux-kernel+bounces-13021-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <635956ac-67e2-5b7c-82cc-6331b9555a7d@yunjingtech.com>
Date: Fri, 29 Dec 2023 17:18:24 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH V8 1/3] mfd: Add support for UP board CPLD/FPGA
Content-Language: en-US
To: Krzysztof Kozlowski <krzk@kernel.org>,
 "larry.lai" <larry.lai@yunjingtech.com>, lee@kernel.org,
 andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org, pavel@ucw.cz
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
 linux-leds@vger.kernel.org, GaryWang@aaeon.com.tw, musa.lin@yunjingtech.com,
 noah.hung@yunjingtech.com
References: <20231228151544.14408-1-larry.lai@yunjingtech.com>
 <20231228151544.14408-2-larry.lai@yunjingtech.com>
 <c684f26c-029f-4264-9cd8-d3a2bb330ad2@kernel.org>
From: Jack Chang <jack.chang@yunjingtech.com>
In-Reply-To: <c684f26c-029f-4264-9cd8-d3a2bb330ad2@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MTVyQUQ3SHVwbHJva1YwMzBPSStZRnp6SHBpNThaMEtXVmI3eHVWR0tCWTc3?=
 =?utf-8?B?S3poRDdudFFkVnl6WWE4Mnd6am9sbEo1NE8zQ2MrT1Z6WGE4WUhtaitkN1F5?=
 =?utf-8?B?NTNSRE1OYnpjcGtxMXJmV0Q0TDh5M0lBam1QeUZuSERGNmRaK3ltSjdzdGZT?=
 =?utf-8?B?aHQ3K05iS1BoQ2g2YzROVXNmckQ5MThNRUdRYWRlSWIrYmNPblQ5WWlNeHA0?=
 =?utf-8?B?T3lsVVo3bDU5aDZ6MTYzeUxTdUw3TmJ0VUkvMjZvUS9lak9iNys2blFncVUv?=
 =?utf-8?B?NklHdGNHVy9yM0Q2MGt1NEFyVzFOZHRjdk1Fd21SY1c3cXh3ZnZSMHJ5RmZG?=
 =?utf-8?B?SE1wT2F3VVMxQWFQWVJiSUN6ODZqdzY3bG9qRDB0UHdNOHh5UmtKN2NtSmJC?=
 =?utf-8?B?OGNLcDAybHRRRktKUTdNU1BENTNHcEJ5MElXRWJabzFJZXh5TWFScysydEtV?=
 =?utf-8?B?YlpDUGFLSk04M2c2YXVGVDFZeFBLWitiUGlsZ1JBcmpwZXk5NVl1cUNrK0tX?=
 =?utf-8?B?cG9mbHFzZTE4cCtMU2x0aGozY1VtUzZtNFk5ajE3cDJGR1c5djd1SXNxenVB?=
 =?utf-8?B?dzFaUCszcUxpY1h3ZmFJd1hxVTJwQ0c1djJZT2NsYlZEK2ZCM0oxQ2FIT3FP?=
 =?utf-8?B?TXpzQzdhM1d4TjA4K0VJSXFkc3BSczlHTTRqZHB5U3RFeXgyTFNKazNpL05R?=
 =?utf-8?B?UTVUTkIwdnhjMjlYbkV3RGRkS3Z2b2wwZnBBWXpiWTJTL3RLQ2lETVFvTzdn?=
 =?utf-8?B?VjBnZVZMS2pxWjdHaFFMWVkzSU5ia2c4SDA4bmtGVFZNMjBlTDFteFpHRmhM?=
 =?utf-8?B?Zk82T1c2emlNTU5RSzByYzM2U1lBRDZLdnhFYzdVNVRJZ0ZqSzlYTXNLV012?=
 =?utf-8?B?aFN2MXNrZ0Nxd1dmUTRpN3orYTNzRHZ4c05hUURkQ0RKaDlBME1jZ3gyaFFK?=
 =?utf-8?B?Um12WGZjT1J6c2xlenI5TmpyTUs2dldiQW44OFgxN2lqT0RGRU53S3dHSDdD?=
 =?utf-8?B?YmN3UnRsR1hmaTA3bFJxc0F0czcxbjhvRVZsTk5HVm5hY05WWlo2ZktUWm95?=
 =?utf-8?B?VXFqdktObDVLeEp5N25XWk9KdEZzVGU5U1BiS2lqWVM0WmNPdUJlelBxRURr?=
 =?utf-8?B?TTRKTjNZTnh2ajJaSFZscVRDQTJIdUtNVXRuRVR4a3Z6Umg5bi9OVW5VdmJZ?=
 =?utf-8?B?U2l3dEtNS29ncnJQeUlPWkxYMDZOQ3p0TzFGYS9HL0N6YWhKbVpVNXFXYzkv?=
 =?utf-8?B?N3RRcHVtN1h5K3ptczZ3bElaMHhoaG8wUHNVeHE5S1dic1p5OUxFTmlNT3c2?=
 =?utf-8?B?aUQ5ZHBOaFBLU0xwbUhsY1d5eDN4c1p5OHpRK1J5elltTkw2MG1haDFVMVJT?=
 =?utf-8?B?T1I1WFc4aXpuaGJXOS9MNDJSVVdLWE9nMXVydjlObUE2Nk1FakozQkxURnJ4?=
 =?utf-8?B?YnowZ1h1NS9yRWJtRmNqb091TjNFRTJZWWgyMkpLL20wV2pvdUF2MW83MkNQ?=
 =?utf-8?B?aThKQmtUTnZGM1lkZTNTbDJiMWZJcDNFdWE2THZEYThyakVVeExGVzlIMjYv?=
 =?utf-8?B?cUl2UWVtVjNwaW4rRVQ0QTZlQnVMb2dYWmk5K0YzeHZadXBrY0FtLzVYY0xj?=
 =?utf-8?B?L0QyTG05ZUd2dU4rT0dPS3ZtS09LelZFQUVpYTljNEloVHBmYmFkeGZqTnY5?=
 =?utf-8?B?bCtjVWdiQ1BPbmJQRUJmOElqMmJhK0UwdFEzQ250ZmNnVGpQVmRNSXlzQkRK?=
 =?utf-8?B?WEE4UWY3WFVGQzhDa0NTVFVnRHc1am5Idk5MY0dOcnRuTEtMTy9GRVJFQ29Q?=
 =?utf-8?B?NDNLZ0Y2VmRnalFkUGYyWjUvVCtvT0pLWHdQbGZESUVWZVdJNWdER0NnOFd5?=
 =?utf-8?B?bWVTb0QwZUZsNHpZWm9acEdOV1p0a2xkR1ROdVdCY1cxdGlYT0k0QUdrcFBt?=
 =?utf-8?B?NmNGNWtLK3ZWWDloNTFBOGpHQVFjSDJaU04xNUtaOTlxZ0dNSG9maUpZT1Ja?=
 =?utf-8?B?WTBPN2xMaUo5TWRDUHRKc1BaWGRYanZpd2VlL2QrU01iSWxsckJJMHdpK3FJ?=
 =?utf-8?B?Ukk5dlBqclNkd0cvVXVHK3BtWWFMMkhUSmp3bVJ1YUw4V1JYajhoS3hRaFBm?=
 =?utf-8?B?emEzdjkxOTFJb3pJYWh3V2lYaCt1MlhxN01CU285OXVYQzZZaDh4MGR0ZmdR?=
 =?utf-8?B?M0E9PQ==?=
X-OriginatorOrg: yunjingtech.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a31856d-4ea0-4154-97c3-08dc084f1deb
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB5950.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2023 09:18:27.9002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: be2d5505-f7e6-4600-bbe2-b3201c91b344
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1y0xSRvkFN0q1/oulvzVcoYkvJJIz9rkgu4FhBWggXD/k6Ohbd6YRgoqVC6M88i6COf4lBnKybXHctJC8tSTLGyjP007QXARPycmylwd5Rs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6394

On 2023/12/28 23:31, Krzysztof Kozlowski wrote:
> On 28/12/2023 16:15, larry.lai wrote:
>> The UP Squared board <http://www.upboard.com> implements certain
>> features (pin control, onboard LEDs or CEC) through an on-board CPLD/FPGA.

...

>> +static int upboard_cpld_read(void *context, unsigned int reg, unsigned int *val)
>> +{
>> +	struct upboard_fpga * const fpga = context;
> 
> This const does not make sense. Drop it. Unless you wanted to say
> something else, like struct is not modified, but then please read C
> tutorials. This applies to all your three patches.

will do

-- 
Best Regards,
Jack Chang