Received-SPF: pass (google.com: domain of linux-kernel+bounces-13023-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <0e5b8537-11c3-43f6-ca86-120b12ade3a4@yunjingtech.com>
Date: Fri, 29 Dec 2023 17:18:38 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH V8 3/3] leds: Add support for UP board CPLD onboard LEDS
Content-Language: en-US
To: Krzysztof Kozlowski <krzk@kernel.org>,
 "larry.lai" <larry.lai@yunjingtech.com>, lee@kernel.org,
 andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org, pavel@ucw.cz
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
 linux-leds@vger.kernel.org, GaryWang@aaeon.com.tw, musa.lin@yunjingtech.com,
 noah.hung@yunjingtech.com
References: <20231228151544.14408-1-larry.lai@yunjingtech.com>
 <20231228151544.14408-4-larry.lai@yunjingtech.com>
 <f02f1a6d-88fe-463b-b3a0-4feb5a6f8c85@kernel.org>
From: Jack Chang <jack.chang@yunjingtech.com>
In-Reply-To: <f02f1a6d-88fe-463b-b3a0-4feb5a6f8c85@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TzJKeVpOVUdNSjlxK1M4TDFNV2czeklRcEpUOTV2RVFQbTRGSE1TSGRYMjd4?=
 =?utf-8?B?ZHZWbzR4SFlGRVk2ZGdqU29jcWFqUHQ3RlNjVTh0SUtuQSs5dVF2d0pRU1BX?=
 =?utf-8?B?bXk0WndLQTBhdjZ6Sy9sa3VMTUZ5cEpIZGtNbWx3N3UvQXJEY2FTUkVIdVc0?=
 =?utf-8?B?UVBRQVJyY3FkSllpL0R5OFRuamxpUStGa0w2Q0lSb2FsL1BFa0tCK05HbzJN?=
 =?utf-8?B?OW5GK0ZvM0drNzRiZ0ZOK3RvdkdRUmdva3h3TlB1d1lHQW0vbkcyVXVrYURn?=
 =?utf-8?B?U0I0bldCWm85UWFlbTJnbVBRNUJGbnRGRkpSRjJDbWdpRTh1MlJtNE5LbTFh?=
 =?utf-8?B?cWRTU095ZHJzMlBLRVgyNTByd1JWY2ljMFkvZ3czRzFsblFFZlZmNmtFdU50?=
 =?utf-8?B?R20wc2s4K2JMWXY1aFBTVEZQNFQ5aWY4N0EwcXd3SG5WQ0hIOGlFZ3JLNkZK?=
 =?utf-8?B?aDlFcnBXSzRFNVF0Nk1kYXltc0RTZTUwQWExbURQc0VyRzlyeFVlWFRaN0xE?=
 =?utf-8?B?WmVYcjBQNmZ6M3dQUENGRTdjYlBEcWJzN1Ruc0VleSthYVp2QWM5UUY3cjYr?=
 =?utf-8?B?WUpRMXN5VjNNZFE1S1hXQXppRlp3Vk9sRm9wb2tVS2Z6ZDZpY2d0dUdFNlZt?=
 =?utf-8?B?S2tDSjlLYnJHTDgyS3BCZGVCTnBGZ0lQOENQMWpzajBEdU1lV0R1OXhjV0Nw?=
 =?utf-8?B?YVRRTXZXbWNpQkxmTDdpY2p3TVFiL09HNTNSVk1oYlM5SE5WRHNBMFdvMDVU?=
 =?utf-8?B?eWVYNVVCeEsrZ1pFVXVRMDlFUVdBZFpZSGVXUFNuL2xWN2EyL2Y2ZzJObWpY?=
 =?utf-8?B?VVZiNFh0YkoxbTFiTS9Tank1bGdOY0hSMzNsVGRlK1V0bVpmNDNFUHRlVEdj?=
 =?utf-8?B?MzdndmZXRGRXT1NuOTg4WTBSTU10aFFGRUFHQVlHMy8rOWh3TEpMZXlLaHFO?=
 =?utf-8?B?OEVuWUlsTDN0eUpwcHU4MStHSWhCS0grRDEwcXI0VDN3bkx1K25qa2xIVWRw?=
 =?utf-8?B?VDM5azFBOENjNlFDaWFvVjlpT1JzbE1BODQrM2JOOWZWamFTN2dBZC90MkJ3?=
 =?utf-8?B?SEFmb0dTOEZEM3h5a1ZFMDFzQVlqMkg5ZWJ1QW1PUFdVcDQyR1h4NTJ4a0p5?=
 =?utf-8?B?dnR4MTF0cnExNlBIZTFjQmxzTmpqckM3K2l6MWFiUDZqVjBmWVVFQTRWQm1p?=
 =?utf-8?B?MDN0cGRiL3ZwQmtLT0FIK25xT0VEOG1icU5rcUJDSzlxdVBwaDgvdHJObnZX?=
 =?utf-8?B?WW5FVEJsekFSQ1RVUE9ZWDgxTk1oWm1rN0tCWFpsQ3dFM3VYaVZVK1gzUVBD?=
 =?utf-8?B?VGxFVVRyWVliM0dhRDF3cmVWTXNQV1FyRS9sY1pIeUpPdHJyeWswUldiK0Vw?=
 =?utf-8?B?Y1JHbmJDV2VvUVJxeUN1bURIdXVvL3JXc0ZXeTVlMSt3TVViR2l4ZUZTWTdi?=
 =?utf-8?B?dVhwck9sb29TVTViMUZORTlTd2lmNjJDQW1rNVFLRHN4bkdBM08wdHA3VkxQ?=
 =?utf-8?B?bFNBbDFORnBEUTdGWUVoRzIvRlR4OGRvZytSelY2Q1o2b2pOblZBa0c0VXlR?=
 =?utf-8?B?a3VMWDdpUzA5RURjZWtlb3krOW1IQnJ4SlNUaml2V3FtdzJUNGJZaSt5TEFv?=
 =?utf-8?B?YzFtUTNBRlFUTHlNSEhIYkNwaEpocUMzdGZPM3A0eExrbDdkVnJVTFR5eEhM?=
 =?utf-8?B?NnRIQnhMWkE4ZTR6QXJWYm43VDc3dWR2MWlpeEwxL0JwM01WQ25kSUJ4VUcz?=
 =?utf-8?B?R3paYlVDZmNQK1I4Rlk1ZlRucUZpYUpJWUlRKzIvbloxdFR1Qkc1SWFEOXpY?=
 =?utf-8?B?NVJhYmI0ejBVSHdmb0tRMHVwbDBQc3FyM2l2WnRKVEFFaXZNWGhOOEZjUjlK?=
 =?utf-8?B?bzdUemJ0MDhFQ2RWTDJDVmJwNkV2SFFPb3kvSVFSWldISTlOcUhYZElXdEcz?=
 =?utf-8?B?SWppWTlyaGw5MGgwUks1UjUwcUIzVTFYNXhtR2ZMOG91T3BHNFlwQ0IrdE4x?=
 =?utf-8?B?TnovV1Z6NXF5cmc1L2Noa05JdVJ4bnZnMlRMeW9MOVZDQ0hQaWgzaXVabFR4?=
 =?utf-8?B?djVBU3hyZUlLMU5odEVITnkyRFN0NGJhbHFxZCtMV3Q3ZURKeUhQK2ZJaHNY?=
 =?utf-8?B?MCtKOTFnSG9ib1lIQ0QvcUcwZERrY1BpSEIwRGY2c0djaVU0YjhjU01mVVNU?=
 =?utf-8?B?TkE9PQ==?=
X-OriginatorOrg: yunjingtech.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0c45d97-d1f2-4e79-4477-08dc084f25d6
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB5950.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2023 09:18:41.1067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: be2d5505-f7e6-4600-bbe2-b3201c91b344
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5UtoSSjvQWwgBXRgVQCuXt180JDMtfJ5y3EgzOyjOs06YiW18ncS6B1QYJbVvKlJ4zH1lLjWNcNZDOQVeEMzkA1cIGK15jLLSHFNL6aXPno=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5811

On 2023/12/28 23:29, Krzysztof Kozlowski wrote:
> On 28/12/2023 16:15, larry.lai wrote:
>> The UP boards come with a few FPGA-controlled onboard LEDs:

...

>> +static int upboard_led_probe(struct platform_device *pdev)
>> +{
>> +	struct upboard_fpga * const cpld = dev_get_drvdata(pdev->dev.parent);
>> +	struct reg_field fldconf = {
>> +		.reg = UPFPGA_REG_FUNC_EN0,
>> +	};
>> +	struct upboard_led_data * const pdata = pdev->dev.platform_data;
> 
> Your const does not make sense. Please read C standard how qualifiers
> are applied.

will do

>> +MODULE_ALIAS("platform:upboard-led");
> 
> Nothing improved here.
> 
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.

the same as pinctrl-upboard doing

-- 
Best Regards,
Jack Chang