Received-SPF: pass (google.com: domain of linux-kernel+bounces-13025-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <b1ac7e4c-e59f-43c8-a914-415a511beccc@linux.intel.com>
Date: Fri, 29 Dec 2023 17:24:31 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v9 5/5] iommu/vt-d: don't loop for timeout ATS
 Invalidation request forever
To: "Tian, Kevin" <kevin.tian@intel.com>,
 "bhelgaas@google.com" <bhelgaas@google.com>,
 "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
 "dwmw2@infradead.org" <dwmw2@infradead.org>,
 "will@kernel.org" <will@kernel.org>,
 "robin.murphy@arm.com" <robin.murphy@arm.com>,
 "lukas@wunner.de" <lukas@wunner.de>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
 "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20231228001646.587653-1-haifeng.zhao@linux.intel.com>
 <20231228001646.587653-6-haifeng.zhao@linux.intel.com>
 <BN9PR11MB527651C1A108721CFF057BCF8C9EA@BN9PR11MB5276.namprd11.prod.outlook.com>
 <bb3a8a4c-6dad-4347-9076-0f28d1e23de3@linux.intel.com>
 <BN9PR11MB5276E70591021395F1ED90D28C9DA@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Ethan Zhao <haifeng.zhao@linux.intel.com>
In-Reply-To: <BN9PR11MB5276E70591021395F1ED90D28C9DA@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 12/29/2023 4:17 PM, Tian, Kevin wrote:
>> From: Ethan Zhao <haifeng.zhao@linux.intel.com>
>> Sent: Thursday, December 28, 2023 9:10 PM
>>
>> On 12/28/2023 4:38 PM, Tian, Kevin wrote:
>>>> From: Ethan Zhao <haifeng.zhao@linux.intel.com>
>>>> Sent: Thursday, December 28, 2023 8:17 AM
>>>>
>>>>
>>>> -	if (rc == -EAGAIN)
>>>> +	if (rc == -EAGAIN && type !=QI_DIOTLB_TYPE && type !=
>>>> QI_DEIOTLB_TYPE)
>>>>    		goto restart;
>>>>
>>> this change is moot.
>>>
>>> -EAGAIN is set only when hardware detects a ATS invalidation completion
>>> timeout in qi_check_fault(). so above just essentially kills the restart logic.
>> This change is intended to break the restar login when device-TLB
>>
>> invalidation timeout happens, we don't know how long the ITE took
>>
>> if the device is just no reponse.
> if in the end the agreement is to remove the restart logic, then do it.
>
> it's not good to introduce a change which essentially kills the restart
> logic but still keeps the related code.

Here, the device-TLB invalidation, depends on devcies response,

no one could make sure the what the third party adapters will act.

but for those invalidation issued to iommu itself, should be more

likely to survive ?

Anyway, would like to see more comments.


Thanks,

Ethan