Received-SPF: pass (google.com: domain of linux-kernel+bounces-13046-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a83ad70d-910e-4bb4-97c8-008dc74526c4@5challer.de>
Date: Fri, 29 Dec 2023 11:31:20 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Regression] [PCI/ASPM] [ASUS PN51] Reboot on resume attempt
 (bisect done; commit found)
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: bhelgaas@google.com, kai.heng.feng@canonical.com,
 linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 regressions@lists.linux.dev, macro@orcam.me.uk, ajayagarwal@google.com,
 sathyanarayanan.kuppuswamy@linux.intel.com, gregkh@linuxfoundation.org,
 hkallweit1@gmail.com, michael.a.bottini@linux.intel.com,
 johan+linaro@kernel.org, "David E. Box" <david.e.box@linux.intel.com>
References: <20231229002623.GA1560896@bhelgaas>
Content-Language: en-US
From: Michael Schaller <michael@5challer.de>
In-Reply-To: <20231229002623.GA1560896@bhelgaas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

> Hi Michael, thank you very much for debugging and reporting this!
> Sorry for the major inconvenience.
> 
You're welcome and the only inconvenience was doing the bisect. ;-)

> We have some known issues with saving and restoring ASPM state on
> suspend/resume, in particular with ASPM L1 Substates, which are
> enabled on this device.
> 
> David Box has a patch in the works that should fix one of those
> issues:
> https://lore.kernel.org/r/20231221011250.191599-1-david.e.box@linux.intel.com
> 
> It's not merged yet, but it's possible it might fix or at least be
> related to this.  If you try it out, please let us know what happens.
> 
I gave the proposed patch a quick test on top of kernel 6.6.8 and it 
didn't affect this issue (the reboot still happens on resume attempt).