Received-SPF: pass (google.com: domain of linux-kernel+bounces-13071-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Swee, Leong Ching" <leong.ching.swee@intel.com>
To: Serge Semin <fancer.lancer@gmail.com>
CC: Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue
	<alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S .
 Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, "Jakub
 Kicinski" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring
	<robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>
Subject: RE: [PATCH net-next v1 4/4] net: stmmac: Use interrupt mode INTM=1
 for per channel irq
Thread-Topic: [PATCH net-next v1 4/4] net: stmmac: Use interrupt mode INTM=1
 for per channel irq
Thread-Index: AQHaNJo+8U9tJ0DEGUmu+Vd+sNpgu7C12k4AgApRhVA=
Date: Fri, 29 Dec 2023 11:51:06 +0000
Message-ID: <CH0PR11MB5490FBE567511E89C8F80BE5CF9DA@CH0PR11MB5490.namprd11.prod.outlook.com>
References: <20231222054451.2683242-1-leong.ching.swee@intel.com>
 <20231222054451.2683242-5-leong.ching.swee@intel.com>
 <prjrrsznvpnbanseqttqgtu3s6kgillyyhs5hozwxwh4kt7eiv@zmups3rcbvby>
In-Reply-To: <prjrrsznvpnbanseqttqgtu3s6kgillyyhs5hozwxwh4kt7eiv@zmups3rcbvby>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WN7iOskPt5Dj35PN0FKtEfSZCQo2wa4OYeBKPXCAPKI0TIOOuJ16HFXexoLy?=
 =?us-ascii?Q?p6dEoLFzJ1VOmejbZzeE56RpJl/Nzt30CpVORtfY7S+UoS1+i8r3dqMTc9wU?=
 =?us-ascii?Q?V9ZtUdTGkzaB+7xOeKEBHafs5l+i+V9hnZ1GCXeEAIDDvKM/I+OM0OMrFXyv?=
 =?us-ascii?Q?Qc0YTCf0TIpaC+WcgQxEkhxsdNFf4Z8+r6nSh37IdozdH/R9tIri8wOWwpSK?=
 =?us-ascii?Q?/EXHAVjUTNOrtUv+o7gbqkjNfOB4k3W6nE4REj9O4uTpysn8r2UozovuCyUf?=
 =?us-ascii?Q?OYcJWbfsK4rk8t8vAv+oncPkvP2TeO7gq8qOUq3oT3SWDv5RjiwzP8RRRCQJ?=
 =?us-ascii?Q?izfQMewtJbu9/VBBloFH3oDxhT/xQHLEIaZzjRMsGnv5Nzp0aIAX1xgGhel5?=
 =?us-ascii?Q?GJ4rTNUnvOVM6KmvnQEsQIZdXTmB6IjH0E5vatCzkZLof+zLZ1wKR3tyhyJc?=
 =?us-ascii?Q?1yyBDGlHnnQ0DfSOEAa+9vuVv5FLde3WpeuLD3cUefmfXxIEuL7F2240zAgc?=
 =?us-ascii?Q?wD5fCcK36s6kk0cttW/tag7OvOmQ2eKiz8oo8dUSkkNvENjdTgreB5wCvpYb?=
 =?us-ascii?Q?5/RaZJsFpo2LLU3Vq0SCKfFLcqaGhLiLMQPINaj5oNuRMjw/VfS+1QYQGglR?=
 =?us-ascii?Q?UZXzcjp1jrqQZ+5yB4Tz10yEx0NWO794NG2dFrg983bS9hL03NRegXpsT7Zk?=
 =?us-ascii?Q?yCW+lUSc7qFVj5lVXU8DHah6NLq5YpUFnURReMHf5r/xG26LAwcFmXjNU8E+?=
 =?us-ascii?Q?2FeJqZ341x8ZqlA3OsgyjgFuiHmzxoQ4j7NIHF3y1cdMcTegZCjotBb4CqKz?=
 =?us-ascii?Q?35r2E0FEJZsql0PQpmjY4TVVyf/IJTu/MkKXvNCHGWx5tciOqn+FxHeoyxd3?=
 =?us-ascii?Q?3dD+Ra/O928W0s7ZpV5hjh/R8f0oSeMuaB2wy6kK2CRIf4WcQRgdovs2wyhn?=
 =?us-ascii?Q?xFrD+eKwNvCRtV7remOyjY737KhaK8Mdb64PfVBDxiMBpXUJBGrT4vOV2fuB?=
 =?us-ascii?Q?CHJIRkPHUaGjoy8+SfhVMHHJ+/FKwNf5yjxikkTJUfdT5amd2n2k/I68pTR9?=
 =?us-ascii?Q?8f4x/P2YS9rcSKkDoKLJxCXn0QC1coedjb59Um/QUo2+hUr2cFwUL/aUVomE?=
 =?us-ascii?Q?95oEQ2NNAbLZVGm2Wc3vBtsgvBmIMssYdfE4jXMJ0++lFv+x01UztJMszqvi?=
 =?us-ascii?Q?U43KZ+r6tLwGE1j/97YaTJxvs+UlPMyubYqf6oI8RdaD2fr4paq76ektN0Tb?=
 =?us-ascii?Q?TeSE8+nMK0VWyvqeuGDWdXCxlVOqZuVzWNCtMRzculGUls7eyJSwx8F+58tZ?=
 =?us-ascii?Q?Zx2k/S26pJKJlxmmqJUnPL0DFwEZDy/U3Q/JtMRzkvgPVDU/wFvs08BsdXu4?=
 =?us-ascii?Q?plFhox5eEGLFzfez0y3GFgceK9JGRKNxoCmu4yQPWlWnvtO26M2RNxN0BEyL?=
 =?us-ascii?Q?wxw7OqNyBZ5DvqzeM9YWqFXyVNQnyIY+ZPt4mWiEzuIihI2YV8Eluie5zSxc?=
 =?us-ascii?Q?OOLHCLTXo2i/9cq5Rkf9NeKOD4JhDQ6P8AbelmhMJS24qVTia3hzdF6zcXz8?=
 =?us-ascii?Q?ffotK079wj5PmZSMhXc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5490.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2abcce0a-192f-4a88-9252-08dc086470ff
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2023 11:51:06.4884
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kHvfwaXR8dSylyBf19EIeo7HWyiHubywFXJ9rkrKXSqZwfRuS5PBmf3NssgH6b7g49WIcD6kgz7AsV250Kn7ScqbuaeL/wn4sUpMQ3MCMDI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4922
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Serge Semin <fancer.lancer@gmail.com>
> Sent: Saturday, December 23, 2023 5:57 AM
> To: Swee, Leong Ching <leong.ching.swee@intel.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>; Alexandre Torgue
> <alexandre.torgue@foss.st.com>; Jose Abreu <joabreu@synopsys.com>;
> David S . Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Rob Herring <robh+dt@kernel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Giuseppe Cavallaro <peppe.cavallaro@st.com>;
> linux-stm32@st-md-mailman.stormreply.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; devicetree@vger.kernel.org; Teoh Ji Sheng
> <ji.sheng.teoh@intel.com>
> Subject: Re: [PATCH net-next v1 4/4] net: stmmac: Use interrupt mode
> INTM=3D1 for per channel irq
>=20
> On Fri, Dec 22, 2023 at 01:44:51PM +0800, Leong Ching Swee wrote:
> > From: Swee Leong Ching <leong.ching.swee@intel.com>
> >
> > Enable per DMA channel interrupt that uses shared peripheral interrupt
> > (SPI), so only per channel TX and RX intr (TI/RI) are handled by TX/RX
> > ISR without calling common interrupt ISR.
> >
> > Signed-off-by: Teoh Ji Sheng <ji.sheng.teoh@intel.com>
> > Signed-off-by: Swee Leong Ching <leong.ching.swee@intel.com>
> > ---
> >  .../net/ethernet/stmicro/stmmac/dwxgmac2.h    |  3 ++
> >  .../ethernet/stmicro/stmmac/dwxgmac2_dma.c    | 32 +++++++++++-------
> -
> >  2 files changed, 22 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > index 207ff1799f2c..04bf731cb7ea 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > @@ -346,6 +346,9 @@
> >  /* DMA Registers */
> >  #define XGMAC_DMA_MODE			0x00003000
> >  #define XGMAC_SWR			BIT(0)
> > +#define XGMAC_DMA_MODE_INTM_MASK	GENMASK(13, 12)
> > +#define XGMAC_DMA_MODE_INTM_SHIFT	12
> > +#define XGMAC_DMA_MODE_INTM_MODE1	0x1
> >  #define XGMAC_DMA_SYSBUS_MODE		0x00003004
> >  #define XGMAC_WR_OSR_LMT		GENMASK(29, 24)
> >  #define XGMAC_WR_OSR_LMT_SHIFT		24
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
> > b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
> > index 3cde695fec91..dcb9f094415d 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
> > @@ -31,6 +31,13 @@ static void dwxgmac2_dma_init(void __iomem
> *ioaddr,
> >  		value |=3D XGMAC_EAME;
> >
> >  	writel(value, ioaddr + XGMAC_DMA_SYSBUS_MODE);
> > +
> > +	if (dma_cfg->multi_irq_en) {
> > +		value =3D readl(ioaddr + XGMAC_DMA_MODE);
> > +		value &=3D ~XGMAC_DMA_MODE_INTM_MASK;
> > +		value |=3D (XGMAC_DMA_MODE_INTM_MODE1 <<
> XGMAC_DMA_MODE_INTM_SHIFT);
> > +		writel(value, ioaddr + XGMAC_DMA_MODE);
> > +	}
> >  }
> >
> >  static void dwxgmac2_dma_init_chan(struct stmmac_priv *priv, @@
> > -365,19 +372,18 @@ static int dwxgmac2_dma_interrupt(struct
> stmmac_priv *priv,
> >  	}
> >
>=20
> >  	/* TX/RX NORMAL interrupts */
> > -	if (likely(intr_status & XGMAC_NIS)) {
> > -		if (likely(intr_status & XGMAC_RI)) {
> > -			u64_stats_update_begin(&rxq_stats->syncp);
> > -			rxq_stats->rx_normal_irq_n++;
> > -			u64_stats_update_end(&rxq_stats->syncp);
> > -			ret |=3D handle_rx;
> > -		}
> > -		if (likely(intr_status & (XGMAC_TI | XGMAC_TBU))) {
> > -			u64_stats_update_begin(&txq_stats->syncp);
> > -			txq_stats->tx_normal_irq_n++;
> > -			u64_stats_update_end(&txq_stats->syncp);
> > -			ret |=3D handle_tx;
> > -		}
> > +	if (likely(intr_status & XGMAC_RI)) {
> > +		u64_stats_update_begin(&rxq_stats->syncp);
> > +		rxq_stats->rx_normal_irq_n++;
> > +		u64_stats_update_end(&rxq_stats->syncp);
> > +		ret |=3D handle_rx;
> > +	}
> > +
> > +	if (likely(intr_status & (XGMAC_TI | XGMAC_TBU))) {
> > +		u64_stats_update_begin(&txq_stats->syncp);
> > +		txq_stats->tx_normal_irq_n++;
> > +		u64_stats_update_end(&txq_stats->syncp);
> > +		ret |=3D handle_tx;
>=20
> Could you please clarify my comment to the original patch:
>=20
> On Fri, Aug 18, 2023 at 20:10:21PM +0300, Serge Semin wrote:
> > Just curious. Is this change really necessary seeing NIS IRQ is
> > unmasked and it is unmasked-OR of the RI/TI/TBU flags in the
> > DMA_CHx_Status register? Moreover based on the HW manual,
> > DMA_CHx_Status reflects raw IRQ flags status except NIS and AIS which
> > are the masked OR of the respective flags. So AFAIU NIS will be set in
> > anyway if you have RI/TI/TBU IRQs enabled.
>=20
> -Serge(y)
>=20
Thanks for your comment.=20
From my test, NIS bit value is 0 once INTM is set, even with RI/TI flags va=
lue is 1.=20
This might be the reason why previous patch set had this change.
-Jim
> >  	}
> >
> >  	/* Clear interrupts */
> > --
> > 2.34.1
> >
> >