Received-SPF: pass (google.com: domain of linux-kernel+bounces-13102-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 29 Dec 2023 21:34:00 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: Hangbin Liu <liuhangbin@gmail.com>
CC: <netdev@vger.kernel.org>, Paolo Abeni <pabeni@redhat.com>, David Ahern
	<dsahern@kernel.org>, <linux-kselftest@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <lkp@intel.com>, kernel test robot
	<oliver.sang@intel.com>
Subject: Re: [PATCH net-next] selftests/net: change the shebang of
 unicast_extensions.sh to bash
Message-ID: <ZY7KyPhGeMJ4iSO9@yujie-X299>
References: <20231225072109.3835503-1-yujie.liu@intel.com>
 <ZYl37fnxGGop7VCs@Laptop-X1>
 <ZYqSJk9rMxGxLx8s@yujie-X299>
 <ZYrMX5GTjxCzGeK-@Laptop-X1>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZYrMX5GTjxCzGeK-@Laptop-X1>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZiQiliBVfMcCZ7uMhWWMqlppLdLOH3MaF9CDzTprkSkzP1EyOkULpQ4VW2ee?=
 =?us-ascii?Q?9pFUcWO8yR1Nrjl8qDtK/VOqbr9ydJmJdfFOt0bOvMiu1zYAL3eYTaQAlYrh?=
 =?us-ascii?Q?l4XVaBgUpSL4kafENzoWMoc87+B45PJWRpZ51PoehQeyQ6qJEDMatr+aIyB7?=
 =?us-ascii?Q?v7YRC2ahe6GfEroi4eoSBC9lor7ifQCOiUO9O9lQl4i1/mZk1DwzYJFi7GLc?=
 =?us-ascii?Q?PR+45bHFC6Qa/epw4oUmg8FcHnVOD2bUWEM6v5OwHyPGJujdswlgO7MiAu43?=
 =?us-ascii?Q?Fs9E9UCxiQz/JYwe6eS5V1vEt0GOiiFcSpbExfmNvdxMuNnwQ8c1ZG0eul01?=
 =?us-ascii?Q?yN/TBByXFjGw28fZiAF9SkBGQvfLtCZhhj2vgiuV385OXSFVjDMsb7rWx40S?=
 =?us-ascii?Q?XnaXpoQmfumAdixjsYp7F6v2m22GqEKVZJ897Hs7P8nHjzoBdf5Xbu1dQtn3?=
 =?us-ascii?Q?ov4j7uvMt2PBvxmF7zgBMFxkoGRMlmjqb0QxXiWd7WeKpO4kRT9huT0kLkkC?=
 =?us-ascii?Q?6rMbDjE7w73mZ66GqQhhT3hQeq9FpTK4ZqbGnmtlMvUOTfvXgDyglrpLql/B?=
 =?us-ascii?Q?N0DQ9knPqjOXMIZREf0qvEta5MefYWrSoTIdj0OrK4Sv/XR0/2+vi9lkCH6Y?=
 =?us-ascii?Q?r4fGzDXg6217wSoEae+FVrjJDfcOw6JWVE8vZkKhmazFgDqwif6vDa+7HyMS?=
 =?us-ascii?Q?HqHBgEOWIbkdS7GLEtRBu2PIeLoy8N/4+reCZvt1b365qvEefpYUBvIVVmBD?=
 =?us-ascii?Q?rYyz6W9Fyg/ry4b6b5dSGfeqplSl1T5Rua23poGT34L2YP4yeoVVZYXoaFX1?=
 =?us-ascii?Q?RT1g+hTcLNocReW64ZQbZHR49TjUcAr+UVER8rfh/O5+RNaM10tvR8o6pvQ8?=
 =?us-ascii?Q?+xCroQ0CAl6bcZhcu6itdqzIPCbWHnr4HA8rADbrx+A1l3HYn8E84Bfo35EG?=
 =?us-ascii?Q?0Hh8hAcApb9zqB3984x/dLjkyhRmj0evO2cWcJK0IkeQxYzcwuiUFPiaMFLk?=
 =?us-ascii?Q?2c+FCOTLs37ioRPI9+Y8YlWe7BNMwXqd/xvISnVdmMn8MxdTISk7a6+cELXV?=
 =?us-ascii?Q?i/iXtluR7RAQmqTnXPMXDlJKa3lxRM1GHw0TTLFdE1T+Fn7z9GxcXmWj+GWw?=
 =?us-ascii?Q?y94iiU4Zj1s+hB3zVATl+qTMulEdusZWEd+zxlNuardMPlEhh+FVfpqm0FFe?=
 =?us-ascii?Q?Bbw6EjHBE960voHvjozN5tF6q/qy5pPgos7HSBHB0JwiR9doHmcQRURDo/cD?=
 =?us-ascii?Q?UvuKbhJ07h5uLcWIMgru5G4kR8aKd7cyrSsg3H7AZD0VKGxETfynVM3glJYr?=
 =?us-ascii?Q?EgcNZlQnUMN1oWw0zYuEzNb4rP6prLs1A2tcEZWfiyNvJhoTe5CZ3bL3lZ1s?=
 =?us-ascii?Q?U0WHQeCYX7TXXUJu19a399NGqjJEPHfZEVHqfzYxQt1WnbUaEmZFEV7W3/uH?=
 =?us-ascii?Q?YOoARyrG2MdCOO3cq8ojBDP5YZCsHf+aCIoB9wcdWr3jtBiCJB3eB1rkZSVr?=
 =?us-ascii?Q?/p0TnOycomO9tSGrRHAhLRVZ9bBJCAra9seEtpjwedUpalgV1t+X4JQNrI0U?=
 =?us-ascii?Q?uS84b3qdiyBn5rKQ6yDYbYzWFwzI5l6oUO0T5e9E?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fa71465-5daa-4ddf-1c7b-08dc08736e38
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2023 13:38:24.4553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aS7s2JBnYvFO8bDDtYzyzY2s5/NfLTYHgJdyuLmtFLEv8SFtEi5SClIiUMVKt2ByBK7seQhG+yVkyfu93oQO0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5348
X-OriginatorOrg: intel.com

On Tue, Dec 26, 2023 at 08:51:43PM +0800, Hangbin Liu wrote:
> On Tue, Dec 26, 2023 at 04:43:18PM +0800, Yujie Liu wrote:
> > Hi Hangbin,
> > 
> > On Mon, Dec 25, 2023 at 08:39:09PM +0800, Hangbin Liu wrote:
> > > On Mon, Dec 25, 2023 at 03:21:09PM +0800, Yujie Liu wrote:
> > > > The patch set [1] added a general lib.sh in net selftests, and converted
> > > > several test scripts to source the lib.sh.
> > > 
> > > Oh, I didn't know dash doesn't support "source". Thanks for the fix.
> > > Would you please also help fix the pmtu.sh, which has the same issue?
> > 
> > It looks like pmtu.sh was not converted in patch set [1], so it doesn't
> > have "source lib.sh" yet. The cover letter of [1] mentions that the
> > whole process of conversion will be split into several parts. Not sure
> > if pmtu.sh will be converted in the subsequent parts soon? If so, would
> > you like to change the shebang of pmtu.sh when converting it later, or
> > change it together in this patch? Thanks.
> 
> The pmtu.sh update is in this patch set.
> https://lore.kernel.org/all/20231219094856.1740079-1-liuhangbin@gmail.com/
> 
> It would be good to fix these 2 tests together.

Sorry for the late reply due to recent holiday. v2 patch has been sent at: 
https://lore.kernel.org/all/20231229131931.3961150-1-yujie.liu@intel.com/
Please kindly review.

Thanks,
Yujie

> > 
> > BTW, in addition to pmtu.sh, I noticed that there are several other
> > scripts in net selftests which have "/bin/sh" shebang:
> 
> Yes, but the other tests don't use "source".
> 
> > 
> > linux/tools/testing/selftests/net$ grep -rF '#!/bin/sh'
> > openvswitch/openvswitch.sh:#!/bin/sh
> > in_netns.sh:#!/bin/sh
> > netdevice.sh:#!/bin/sh
> > test_bpf.sh:#!/bin/sh
> > test_blackhole_dev.sh:#!/bin/sh
> > vlan_hw_filter.sh:#!/bin/sh
> > run_netsocktests:#!/bin/sh
> > pmtu.sh:#!/bin/sh
> > bareudp.sh:#!/bin/sh
> > l2_tos_ttl_inherit.sh:#!/bin/sh
> > veth.sh:#!/bin/sh
> > ipv6_flowlabel.sh:#!/bin/sh
> > unicast_extensions.sh:#!/bin/sh
> > reuseport_addr_any.sh:#!/bin/sh
> > run_afpackettests:#!/bin/sh
> > ip_local_port_range.sh:#!/bin/sh
> > amt.sh:#!/bin/sh
> > udpgso.sh:#!/bin/sh
> > ip_defrag.sh:#!/bin/sh
> > rps_default_mask.sh:#!/bin/sh
> > 
> > > BTW, you can change the "source ./lib.sh" to "source lib.sh" to consistent
> > > with other tests.
> > 
> > Sure, will respin a v2 with this change added.
> 
> Thanks
> Hangbin