Received-SPF: pass (google.com: domain of linux-kernel+bounces-13121-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <838abf56-e2b1-474b-977a-8671a31053ed@gmx.net>
Date: Fri, 29 Dec 2023 15:34:57 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: Fix smatch errors
Content-Language: en-US
To: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>,
 haibo.chen@nxp.com, ulf.hansson@linaro.org, shawnguo@kernel.org,
 s.hauer@pengutronix.de
Cc: Adrian Hunter <adrian.hunter@intel.com>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>,
 linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <20231229130207.3539334-1-hardevsinh.palaniya@siliconsignals.io>
From: Stefan Wahren <wahrenst@gmx.net>
In-Reply-To: <20231229130207.3539334-1-hardevsinh.palaniya@siliconsignals.io>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:qwtbHYET9Uo=;aCEAr1UMuLD7V6SR8uGZrErjKer
 S0tcO4VqwIampsd8m9pZMLAgoEiIbpPrwx5MXoqMRKiUktpiwQGprLaFpStI0+/wBfVJjgjd2
 9p7bA/bzEN5hXwrzhaHDgDlUuMv2wHyoGi74PgszoyRu7kTbL6nJ91WxHiYX4QfQZ7+uBSTvr
 yYfZZy2+r4U2jdQmd4ykqlcgKfU3bklUtkKnmsGxWB4HxgmV+zoLRQ13aWZ6G3b4mQ1PF5W28
 7RgXZOFNmgJhHlOLLEKwPMBFKPnbXaOKntoEKpANFHRnPlfRybv5829FHn/D4qkHCyRr7bkEE
 3Ph2leiRMr8hZrk9RvFc8nYSlmelGjeWY8Iwdyu6jyd4oIbX9pMOxNoqagUTM3Pv3XlapE5yr
 M1PdrGNlFk0dKRgRIfsNNWiHIwFomEFMazNQwA2yVwuZS2e96j6MjszsLfLpqL9+7WnQzfK56
 TrJqhbE0cfqk3aUpJB7wX/u6C6yF/zyc2MaBFdfMI1CqIGHFXFqmF4gqX9d9geV8wnpg1XRme
 Qw/RVV/8lubmODTTvmxfvKV8NPq8DSspmI/ztmN9VxSBDW/FmqXUYePCT06x6D60xpmwSd9Oi
 vcDmMLQUWMosVcCaeRUVuUqbeN1DeTp50G1NWoqzWqYAih+UfIHzryirHqRcv4slgp631XADA
 vYHMXDqSVaqc2fvlfca8t1xxRw6GQlGhMekAyiBE0NXmDgcw/USOfWE7qyxmA91H5MsFwkmSa
 hCZkhUDFohiVI9dWFujNw1xBt88QMH5BF7iglUgcOq5E6zsf8AVwvJEUV0NBPllNW8gBHfknn
 jIw7AXnGmMu/pcB72AEYFxqhNsCsIYLSI+asry5aFEwj2jTt6nBAgXEzxCNL5CGC5nFDl/Snk
 S1vx/d5Z40+6AVhSGvxDdyfXrX1R0JrTSt/6ylXB63sVtC7pzaSHWiUpuqtV4xUZtyMcxm4bm
 D0ISK/EFFxi/0waPbh0Hk7HcGa7eNWbnYnEn3eEH9xn0Zybx

Hi Hardevsinh,

the patch subject is a too generic. Maybe something like "fix
initialization of target_min/max"

Am 29.12.23 um 14:02 schrieb Hardevsinh Palaniya:
> Resolve smatch errors in esdhc_executing_tuning()
>
> esdhc_executing_tuning() error: uninitialized symbol 'target_min'
> esdhc_executing_tuning() error: uninitialized symbol 'target_max'
I think this deserve

Fixes: 541a95e64d76 ("mmc: sdhci-esdhc-imx: optimize the manual tuing
logic to get the best timing")

Thanks
> Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.i=
o>
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci=
-esdhc-imx.c
> index 40a6e2f8145a..839b60138f04 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1166,6 +1166,8 @@ static int esdhc_executing_tuning(struct sdhci_hos=
t *host, u32 opcode)
>   	min =3D ESDHC_TUNE_CTRL_MIN;
>   	max =3D ESDHC_TUNE_CTRL_MIN;
>   	target_win_length =3D 0;
> +	target_min =3D 0;
> +	target_max =3D 0;
>   	while (max < ESDHC_TUNE_CTRL_MAX) {
>   		/* find the mininum delay first which can pass tuning */
>   		while (min < ESDHC_TUNE_CTRL_MAX) {