Received-SPF: pass (google.com: domain of linux-kernel+bounces-13135-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <912e8ffa-364c-1ca2-6bb7-803902a3fd6e@intel.com>
Date: Fri, 29 Dec 2023 16:19:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 net-next] selftests/net: change shebang to bash to
 support "source"
Content-Language: en-US
To: Yujie Liu <yujie.liu@intel.com>, <netdev@vger.kernel.org>, Hangbin Liu
	<liuhangbin@gmail.com>
CC: Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lkp@intel.com>, kernel test robot <oliver.sang@intel.com>
References: <20231229131931.3961150-1-yujie.liu@intel.com>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20231229131931.3961150-1-yujie.liu@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amJtak9aaTB2SU43TVFXc29KOXF6ZVNKVlJDZmN0TllzMWE3dmczNVM5QlUy?=
 =?utf-8?B?VElsdWJKSml6RXc5TlRoV2hRQ3AzZVlLU1c3ckw3TzYyVkIrS3U2L21tNXV4?=
 =?utf-8?B?SkJGRnZSemhIQjVGMWNHMWdWbzlJcVN5T3owRThMSmZrOUVzRTNKTm5xdGxN?=
 =?utf-8?B?U2loc0ZWYTJveCt4SnlhR01NeDUvbXZtTEFWbVpZTVNHYmovNzVrNzFwcWRZ?=
 =?utf-8?B?ZVlUMGJHcmM3NitKZzhQUUYxUFowUDk4dXNKK09UVzB0cUpLeWJHZVJLNXY0?=
 =?utf-8?B?M1JmZVhPNzVMbUFZV2ZGbEF0TlRIZ2xnS2J6bnU3RHJLcGNRY0l0czVRZXM4?=
 =?utf-8?B?Y0lFdXIvVnZCZVRKQUp1TC9wc1ZYSEloVTRZc1JuczdlenJER21QbFF5V01K?=
 =?utf-8?B?SnBFQ2JHa1FSODkxUFJJdEk4N29NYlVkWU1kSStNa3ZIODZtUmdBNzcza1VM?=
 =?utf-8?B?Y29sNExTQ1lMUE9vZ0MzSnBrbG1ZZ1E1OFJNOVlXRUI3SktRbWhSMmVid3FV?=
 =?utf-8?B?bW9NUVk1TDlyQ0lUTXA2WFZDOXR0cDBKVEx1YWtWU29HLzl4T2JaUGR3SjAv?=
 =?utf-8?B?UUFFTS9BVXY4UVovdC9SK3JrdnZhSXVEUlVLVFJqZG5yYVh3UnU3bVNNTXFr?=
 =?utf-8?B?a2ZwQUxFUnJIM2liMk83NTdUWVVpYi8rZzg0OU5TMVVvNUZJcFIvM01MRjM4?=
 =?utf-8?B?UzJydFQ1b3JhU3E1TURuNUs1YWpocmNVTytJRS8ySjFnZ3V3eThPMExvK3ZZ?=
 =?utf-8?B?cjF3bkxwUE5xalhibStKbllKQUl2R2N4c3VmdS84a2FoMzhFOU8zQWhpSXBa?=
 =?utf-8?B?QndpN3ZDR1d3bHhBSU8zZXVRT3BlRC83Sm9vbFRiTGpTQk1oZzc2cVNSWlBF?=
 =?utf-8?B?RXNqemM1RzIvZEhVK050OGJWRjFWYVdhRDV6ejlrdGxUbHU0TW5IQ2xDWGdG?=
 =?utf-8?B?aUF1M3pDSG94YTdvU0JOU2VwYnpjeGpUeU03S3BiMkZJQ0l3ZnV5amY0OXF2?=
 =?utf-8?B?dE4wMzhzMTlZbkMxZlZXWWdHcmIzbTFiMkhHVW0wMHErQTlkT01JVGFkeGpH?=
 =?utf-8?B?UmR5NTFxb2k5bzNtOVIvQU1sdXJzZmwrekFMdzRweFRLY2EzVlhKNERNdU84?=
 =?utf-8?B?REZKWG4zRU56SHpnVjhMbTZsZ09qWXdqZGdrcTZlQWNNNWo1cUVZUTRta2xq?=
 =?utf-8?B?ZHplRjZoVzVzZ1pCdURrRURaQ2hIdldIcUNsNXVHdUZYWVdrd0dMVWxUUDFt?=
 =?utf-8?B?amZ6K01rK3prQmVBdnNsaHFueGxuSmxoODdMVG9URVVES1NibzFKaHdjNzF0?=
 =?utf-8?B?dmtreXhMSy9Fbm1xaDRqM20remVrOThlLytrK2R4a3ZBb1VTMzBWb3IrRjFF?=
 =?utf-8?B?SHRadUp6OVhLQXlsZldiRnVuMk8rVTFDbnlnaUw5bUh6bFdVcTlvYVR6OWpj?=
 =?utf-8?B?MW9TSzd1UERRdmxsZE4vc1hUb0hEOWRpV3pnc1p4MjNlbytIVFdyanlzY2tS?=
 =?utf-8?B?NWg4SkxiOEJDZlpwdlFoREcwbDdiUHJFZmN1aFVqUGQwOFRjSWRTcnZlSWRS?=
 =?utf-8?B?cGhPdzgrUkcxUHBkZlJzMUxHRllBdjMreEJvOHBQQVdpV3NjNXI0NTlqZytY?=
 =?utf-8?B?cklLOVptRWNlSFc1SW5mdkQwMjY5WDNYYjlrV0VDcFRKNjZrNWpzSFUyZXFz?=
 =?utf-8?B?RkJGdUVHeDFUbGRaRWlVdDB5TG54aFZQaXFsS3o0cjkralFVS3hhdlo0aDZ5?=
 =?utf-8?B?bWx4THZqZFZPQ3huNjhOeDc1bmNraGtEM0RWN014NzNJVEp1Wi8raTI2ZjBs?=
 =?utf-8?B?b3FCS20zNjlQa05QYXJIdWVyQ0UrekZKYXFRdkF4MnpNazlpeDFGT0RpQ24v?=
 =?utf-8?B?aTJNcFhxai9vOHNPTTBabm9DT3VyV2hhd1BidW40WGMvb2dPcnk0QXRGZWpZ?=
 =?utf-8?B?aUZhSkRqTDF0aGhhbTNmQWhpSDhCOFdJVmtTNnpYVmZ3SkxWcHRad2g2UGFi?=
 =?utf-8?B?a0czU01qd0QvNC9LQldkdEVVOE1XdXZoM0tHNm9COFB6RDh0WE5VcEpTbEVC?=
 =?utf-8?B?dDZyV2tvYUF2b2RjZHB3TjQxK2F2dzdCWFZDQ1laTG00dUQvZGpiVldRcXhW?=
 =?utf-8?B?VGY2MnZjeFpHZHdpcUNPWUhISGltMFFEZHdnMk0yMXJxaWt1aUJhVGlhTEcx?=
 =?utf-8?B?Rmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 69989f9d-9146-449f-7b25-08dc08819821
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2023 15:19:47.8688
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J8kAa/ef40+FUWGyxO0PPQUnh2L8Xd9ys0LXs5ILF5UAM2ucj0b6E4EUk2CELcUg5Cms8A74RYIGu9KiQ8w014VZWiwls5yIicUy5ucG2p8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5564
X-OriginatorOrg: intel.com

On 12/29/23 14:19, Yujie Liu wrote:
> The patch set [1] added a general lib.sh in net selftests, and converted
> several test scripts to source the lib.sh.
> 
> unicast_extensions.sh (converted in [1]) and pmtu.sh (converted in [2])
> have a /bin/sh shebang which may point to various shells in different
> distributions, but "source" is only available in some of them. For
> example, "source" is a built-it function in bash, but it cannot be
> used in dash.
> 
> Refer to other scripts that were converted together, simply change the
> shebang to bash to fix the following issues when the default /bin/sh
> points to other shells.
> 

(snip)

> 
> Link: https://lore.kernel.org/all/20231202020110.362433-1-liuhangbin@gmail.com/ [1]
> Link: https://lore.kernel.org/all/20231219094856.1740079-1-liuhangbin@gmail.com/ [2]
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>

I would recommend use of shellcheck in the future, it will catch this
particular bug, with following warning:
SC3046: In POSIX sh, 'source' in place of '.' is undefined.

Being specific, and requiring bash looks fine for me.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>