Received-SPF: pass (google.com: domain of linux-kernel+bounces-13167-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <f1f002e9-8010-4b74-9da8-2551be97fa6f@kernel.dk>
Date: Fri, 29 Dec 2023 09:52:47 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drivers/block/null_blk: Switch from radix tree api to
 xarrays
Content-Language: en-US
To: Gautam Menghani <gautam@linux.ibm.com>, kch@nvidia.com,
 ming.lei@redhat.com, damien.lemoal@opensource.wdc.com,
 zhouchengming@bytedance.com, nj.shetty@samsung.com, akinobu.mita@gmail.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
 riteshh@linux.ibm.com
References: <20231229164155.73541-1-gautam@linux.ibm.com>
From: Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20231229164155.73541-1-gautam@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 12/29/23 9:41 AM, Gautam Menghani wrote:
> Convert the null_blk driver to use the xarray API instead of radix tree 
> API.
> 
> Testing:
> Used blktests test suite (block and zbd suites) to test the current 
> null_blk driver and null_blk driver with this patch applied. The tests 
> results in both the instances were the same.

What's the purpose of the change?

One thing that always annoys me slightly with xarray is the implied
locking. So now you're grabbing two locks rather than just utilizing the
lock that was already held. I think a better transformation would be to
first change the locking to be closer to the lookup and deletion, and
then convert to xarray and now being able to drop that other lock. Just
doing a blind conversion like this without potentially understanding the
details of it is not a good idea, imho.

-- 
Jens Axboe