Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp4685780rdb; Fri, 29 Dec 2023 09:46:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/XcoaigB3IQB2523niatei1q3o05xeYYHbLCz1eOsf+ex9uVW22UFh0rIHXOAqE2/Lq+v X-Received: by 2002:a50:d696:0:b0:553:727e:3b65 with SMTP id r22-20020a50d696000000b00553727e3b65mr5839418edi.59.1703872011679; Fri, 29 Dec 2023 09:46:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703872011; cv=none; d=google.com; s=arc-20160816; b=TMSvN0vZMYDfqCVTURR9k2nL001QC90BDr3P5CZM6Mth4GaDrDtgt/HDDFsA97NlS2 wpE1vG1CaFjxJ4/VVjOrH0oGuMoss2sENDrDjP5eZ6CL9S/7e+qkE61+CzO9nwV2kuaN HoSJFMrHOWeUXD6aJYWbd7yLh0yGukKVg4Ja08bvQTmKeiOIxOqCQBSWfDkOmzHIbE3j Uy/g0RuJYmS4y5AJQDkEDZuc28T4oijbZ1owJv3MURB2y4RgSy9k9axptPBTHVLocNTE G8rU3McUygyQLIqkHMdW+xnEdfDuyi4rtiXHGZ9eRc2SxIrc6IdHdRFod8eS/5lyCJjj wGIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=bW/8qnQVOuCrpelBOhL9bBZ5oe2cPmQUpD0VXBVorkw=; fh=aOSVRzHd0RYwGlKAPtHTq4zPGELHA6NRSa1YLISev34=; b=G372S0cVYP4GhJVV3b0TqAtNk83sTGMOfjT0QrP5ixrlvOz8A6vHxGtPcEdi3uVKlP 8M6MAeJH6BuLr0s5XsC8UQ4f8+dLd2d7sCZA25k7vb7/4drruxPdV5DmkZoJXelVZO2c UDBmlb6jdcMO7isZZNtE4cLoyn/o/ULB2eOc87dDQsMJoDDTVDoccK+6CNQpoO65HeGc QUDGBlMR5trzOqgJ+AZ2F+5zNFXentdGstMWFD+R0K8EHgCieEnXKoiDSjMPXt6P05yD wFNqVrTQ/GSEy3DL0uvfYaS/2gwROqx3Pa/9rGaTL8k0g4GL1pxXPK/pMqnB5C0DyCcL JAug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ArIQTrje; spf=pass (google.com: domain of linux-kernel+bounces-13190-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13190-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id x5-20020a05640226c500b00555c82c46afsi624415edd.282.2023.12.29.09.46.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Dec 2023 09:46:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13190-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ArIQTrje; spf=pass (google.com: domain of linux-kernel+bounces-13190-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13190-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 599981F21FB1 for ; Fri, 29 Dec 2023 17:46:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D11CB12B87; Fri, 29 Dec 2023 17:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ArIQTrje" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A516C12B7A for ; Fri, 29 Dec 2023 17:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-dbd73ac40ecso5227499276.1 for ; Fri, 29 Dec 2023 09:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703872001; x=1704476801; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bW/8qnQVOuCrpelBOhL9bBZ5oe2cPmQUpD0VXBVorkw=; b=ArIQTrjeqOU62WiMI9FMCw79OP+MODMUtzsP39IfY6DBo4eAMx+FcCn8ANfF2jzqQc uDkHZCwrfwPmNOsu3AMH6mGfWiLDV9n4147F4FJYDvHago9yWDrDw29gd83ljEvswqHO RDPovKbOtqcCqRnVTOxAtm2E9rUN3gHUER+w6rxV9WgsNeXhPrP2RkoySqY0Zg38q97i bhgaA7Gl5n4YA/932RhzO3Z3HtZNqogLn1SIw4u1l3KNcfZlZ1uJ+YnRzUuVA0D/m8vq vVqL2DITCkAeIB8Fti9MtpDe2vr/8/AM0cMug6fogDOmzezaqkWw6rrCCTIomL8MIx3F ZwAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703872001; x=1704476801; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bW/8qnQVOuCrpelBOhL9bBZ5oe2cPmQUpD0VXBVorkw=; b=GzXB2PiTxXXW0aKZGXrPZnreXK4xLeKuZ8WOxJkpoQRb5w/3MjYzwHQR18s8FCsVma 9HWyr5Qe07Va+eIaj/C3iiTLE35D/OqTzYPnFJamNUFptrx6JpB4WMx9MvNQlu+iyi3o mDk+kwwvlKKGrqKWEzcoHYicXhVpOOsD3KckW4BCKlWK0yCjA/eXJnwcngyAeW9DO3Fb PRUOQi7VVVGSmmB4XNEz/Nrn8NeBNwQmUCI2sn1qEjxg0AhpuHO3hxaGCQjs9RliITcw VP1GLx1Ot40woIBZg99fDcBOYis0xpnW5mYEeRzA2JCGNW/5dl5CHW+WGV1QmkOzlrfR z3Vw== X-Gm-Message-State: AOJu0Yy7p10vIhDo/d71bo89/wGvF7CLlj7W3X+VAoixxSXcMt38xorJ c2QSUmc6pYCVsMWcoIfkb+uxiFDc2Imy4w0eXguhhJ3j28+2hQ== X-Received: by 2002:a25:664d:0:b0:dbd:c1ef:bca8 with SMTP id z13-20020a25664d000000b00dbdc1efbca8mr6857806ybm.40.1703872001727; Fri, 29 Dec 2023 09:46:41 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231229135154.675946-1-dario.binacchi@amarulasolutions.com> <20231229135154.675946-9-dario.binacchi@amarulasolutions.com> In-Reply-To: <20231229135154.675946-9-dario.binacchi@amarulasolutions.com> From: Linus Walleij Date: Fri, 29 Dec 2023 18:46:30 +0100 Message-ID: Subject: Re: [PATCH 8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Alexandre Torgue , Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Sam Ravnborg , Thomas Zimmermann , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Dario, On Fri, Dec 29, 2023 at 2:52=E2=80=AFPM Dario Binacchi wrote: > The initialization commands are taken from the STMicroelectronics driver > found at https://github.com/STMicroelectronics/STM32CubeF7/blob/master/Dr= ivers/BSP/Components/nt35510/ > > Signed-off-by: Dario Binacchi NAK. Please rewrite the patch to use the detailed instructions with clear defini= tions about what is going on the same way as in the old driver, and add #defines for all the magic commands, and break down the commands to what they are actually doing with the display hardware. Magic display init sequences are not OK in this driver, and not in general, it is all the other drivers that are just unaware about what they are doing and this driver actually isn't. Yours, Linus Walleij