Received-SPF: pass (google.com: domain of linux-kernel+bounces-13243-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sat, 30 Dec 2023 00:33:35 +0300
From: Serge Semin <fancer.lancer@gmail.com>
To: Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Hoan Tran <hoan@os.amperecomputing.com>, Linus Walleij <linus.walleij@linaro.org>, 
	Bartosz Golaszewski <brgl@bgdev.pl>, Andy Shevchenko <andy@kernel.org>, 
	Jisheng Zhang <jszhang@kernel.org>, Drew Fustini <dfustini@baylibre.com>
Subject: Re: [PATCH v1] gpio: dwapb: Use generic request, free and set_config
Message-ID: <rgdbbvp5x5fp7m3klikacizt5rbg3iyfwk6glr2yrdmcxxrzxi@6godabmsp2ub>
References: <20231229130758.84214-1-emil.renner.berthing@canonical.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231229130758.84214-1-emil.renner.berthing@canonical.com>

On Fri, Dec 29, 2023 at 02:07:51PM +0100, Emil Renner Berthing wrote:
> This way GPIO will be denied on pins already claimed by other devices
> and basic pin configuration (pull-up, pull-down etc.) can be done
> through the userspace GPIO API.
> 
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>

LGTM. Thanks!
Acked-by: Serge Semin <fancer.lancer@gmail.com>

-Serge(y)

> ---
>  drivers/gpio/gpio-dwapb.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 8c59332429c2..798235791f70 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -416,11 +416,12 @@ static int dwapb_gpio_set_config(struct gpio_chip *gc, unsigned offset,
>  {
>  	u32 debounce;
>  
> -	if (pinconf_to_config_param(config) != PIN_CONFIG_INPUT_DEBOUNCE)
> -		return -ENOTSUPP;
> +	if (pinconf_to_config_param(config) == PIN_CONFIG_INPUT_DEBOUNCE) {
> +		debounce = pinconf_to_config_argument(config);
> +		return dwapb_gpio_set_debounce(gc, offset, debounce);
> +	}
>  
> -	debounce = pinconf_to_config_argument(config);
> -	return dwapb_gpio_set_debounce(gc, offset, debounce);
> +	return gpiochip_generic_config(gc, offset, config);
>  }
>  
>  static int dwapb_convert_irqs(struct dwapb_gpio_port_irqchip *pirq,
> @@ -530,10 +531,14 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
>  	port->gc.fwnode = pp->fwnode;
>  	port->gc.ngpio = pp->ngpio;
>  	port->gc.base = pp->gpio_base;
> +	port->gc.request = gpiochip_generic_request;
> +	port->gc.free = gpiochip_generic_free;
>  
>  	/* Only port A support debounce */
>  	if (pp->idx == 0)
>  		port->gc.set_config = dwapb_gpio_set_config;
> +	else
> +		port->gc.set_config = gpiochip_generic_config;
>  
>  	/* Only port A can provide interrupts in all configurations of the IP */
>  	if (pp->idx == 0)
> -- 
> 2.43.0
>