Received-SPF: pass (google.com: domain of linux-kernel+bounces-13244-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Luca Weiss <luca@z3ntu.xyz>
To: Bjorn Andersson <andersson@kernel.org>,
 Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, David Heidelberg <david@ixit.cz>
Cc: Caleb Connolly <caleb.connolly@linaro.org>,
 David Heidelberg <david@ixit.cz>, linux-arm-msm@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 Manivannan Sadhasivam <mani@kernel.org>
Subject:
 Re: [PATCH] arm64: dts: qcom: sdm845: add power domain to UFS phy interface
Date: Fri, 29 Dec 2023 22:37:56 +0100
Message-ID: <2710291.mvXUDI8C0e@z3ntu.xyz>
In-Reply-To: <20231229202959.266502-1-david@ixit.cz>
References: <20231229202959.266502-1-david@ixit.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Freitag, 29. Dezember 2023 21:29:54 CET David Heidelberg wrote:
> Reported by: `make CHECK_DTBS=1 qcom/sdm845-oneplus-enchilada.dtb`
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> b/arch/arm64/boot/dts/qcom/sdm845.dtsi index c2244824355a..ad8677b62bfb
> 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2644,6 +2644,8 @@ ufs_mem_phy: phy@1d87000 {
>  			clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
>  				 <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
> 
> +			power-domains = <&gcc UFS_PHY_GDSC>;
> +
>  			resets = <&ufs_mem_hc 0>;
>  			reset-names = "ufsphy";

This is potentially the wrong power domain, see the conversation here:
https://lore.kernel.org/linux-arm-msm/20231204172829.GA69580@thinkpad/

Hopefully Mani can give some input here :)

Regards
Luca