Received-SPF: pass (google.com: domain of linux-kernel+bounces-13263-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <33a556e3-a7ac-47a3-a621-4db12dbac208@gmail.com>
Date: Fri, 29 Dec 2023 23:42:12 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] platform/surface: aggregator_registry: add entry
 for fan speed
To: Ivor Wanders <ivor@iwanders.net>, Jean Delvare <jdelvare@suse.com>,
 Guenter Roeck <linux@roeck-us.net>, Jonathan Corbet <corbet@lwn.net>,
 Hans de Goede <hdegoede@redhat.com>, Mark Gross <markgross@kernel.org>
Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
References: <20231228003444.5580-1-ivor@iwanders.net>
 <20231228003444.5580-3-ivor@iwanders.net>
Content-Language: en-US
From: Maximilian Luz <luzmaximilian@gmail.com>
In-Reply-To: <20231228003444.5580-3-ivor@iwanders.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/28/23 01:34, Ivor Wanders wrote:
> Add an entry for the fan speed function.
> Add this new entry to the Surface Pro 9 group.
> 
> Signed-off-by: Ivor Wanders <ivor@iwanders.net>
> Link: https://github.com/linux-surface/kernel/pull/144
> ---
> Changes in v2:
>    - No changes in this patch.
> ---
>   drivers/platform/surface/surface_aggregator_registry.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c
> index 530db4db7..b0db25886 100644
> --- a/drivers/platform/surface/surface_aggregator_registry.c
> +++ b/drivers/platform/surface/surface_aggregator_registry.c
> @@ -74,6 +74,12 @@ static const struct software_node ssam_node_tmp_pprof = {
>   	.parent = &ssam_node_root,
>   };
>   
> +/* Fan speed function. */
> +static const struct software_node ssam_node_fan_speed = {
> +	.name = "ssam:01:05:01:01:01",
> +	.parent = &ssam_node_root,
> +};

I would prefer if we could keep the subsystem prefix for node names. So
something like `ssam_node_tmp_fan_speed`.

Otherwise, this looks good to me. With that changed:

Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>

> +
>   /* Tablet-mode switch via KIP subsystem. */
>   static const struct software_node ssam_node_kip_tablet_switch = {
>   	.name = "ssam:01:0e:01:00:01",
> @@ -319,6 +325,7 @@ static const struct software_node *ssam_node_group_sp9[] = {
>   	&ssam_node_bat_ac,
>   	&ssam_node_bat_main,
>   	&ssam_node_tmp_pprof,
> +	&ssam_node_fan_speed,
>   	&ssam_node_pos_tablet_switch,
>   	&ssam_node_hid_kip_keyboard,
>   	&ssam_node_hid_kip_penstash,