Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752756AbXLKIxY (ORCPT ); Tue, 11 Dec 2007 03:53:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751196AbXLKIxO (ORCPT ); Tue, 11 Dec 2007 03:53:14 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:34117 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbXLKIxN (ORCPT ); Tue, 11 Dec 2007 03:53:13 -0500 Date: Tue, 11 Dec 2007 09:52:32 +0100 From: Ingo Molnar To: Dave Jones , Linus Torvalds , Andrew Morton , Matt Mackall , "Rafael J. Wysocki" , LKML , Christoph Lameter Cc: "Rafael J. Wysocki" Subject: Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2.6.24-rc4-git5: Reported regressions from 2.6.23] Message-ID: <20071211085232.GE20172@elte.hu> References: <200712080340.49546.rjw@sisk.pl> <20071208093039.GA28054@elte.hu> <20071208163749.GI19691@waste.org> <20071208100950.a3547868.akpm@linux-foundation.org> <20071208195211.GA3727@elte.hu> <20071211062720.GA29764@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071211062720.GA29764@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1631 Lines: 46 * Dave Jones wrote: > On Sat, Dec 08, 2007 at 08:52:11PM +0100, Ingo Molnar wrote: > > > so even today's upstream kernel, which has 'ancient' SLUB code, SLAB and > > SLUB have essentially the same linecount: > > > > $ wc -l mm/slab.c mm/slub.c > > 4478 mm/slab.c > > 4125 mm/slub.c > > > > (and while linecount != complexity, there is a strong relationship.) > > > > With SLAB having 10 years more test coverage and tuning. > > FWIW, the one thing slub does that slab doesn't that I find really > nice is being enable to enable debugging at boot time rather than > compile time. yes, but that's largely due to "dont change SLAB because we've got SLUB" resistence to SLAB patches. It's a 2 minute hack to implement this for SLAB. > We don't get many people running benchmarks against the Fedora kernel, > so any scalability differences between slub/slab probably won't reach > us until we start shipping betas of the next RHEL based on the same > kernel. > > Which leaves my only other gripe. It broke slabtop. that's actually a _bad_ ABI regression. Rafael, could you please add this to the regressions list? > There's an alternative implementation in Documentation/vm/slabinfo.c > (why there not say, util-linux, home of current slabtop?) the kernel should output /proc/slabinfo data with the same formatting, period. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/