Received-SPF: pass (google.com: domain of linux-kernel+bounces-13377-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 30 Dec 2023 10:48:28 +0100
From: Borislav Petkov <bp@alien8.de>
To: Ashok Raj <ashok.raj@intel.com>,
	Song Shuai <songshuaishuai@tinylab.org>,
	Mike Rapoport <rppt@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	LKML Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Dave Hansen <dave.hansen@intel.com>, Ingo Molnar <mingo@kernel.org>,
	regressions@lists.linux.dev, Mike Rapoport <rppt@kernel.org>
Subject: Re: [REGRESSION] Platforms supporting SGX fail to kexec due to
 96c6b8f212a ("memblock: report failures when memblock_can_resize is not
 set")
Message-ID: <20231230094828.GAZY/nbBwBCP58RuxX@fat_crate.local>
References: <ZY4T7YxrJZCxhMxx@a4bf019067fa.jf.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZY4T7YxrJZCxhMxx@a4bf019067fa.jf.intel.com>

On Thu, Dec 28, 2023 at 04:33:49PM -0800, Ashok Raj wrote:
> Hi 
> 
> 96c6b8f212a ("memblock: report failures when memblock_can_resize is not set")
> 
> Causes kexec failure. Backing out this change, kexec succeeds. Symptom is
> it appears to hang, possibly hung at the panic. Although I have the
> earlyprintk enabled, I don't see any console messages when new kernel
> boots. 
> 
> Also tested turning off CONFIG_X86_SGX, the kernel with this commit
> included also kexec's fine.
> 
> Booting from warm/cold reset has no issues. Only kexec to new kernel with
> this change included and CONFIG_X86_SGX=y causes the kexec failure.
> 
> #regzbot introduced: 96c6b8f212a

Leaving in the whole mail for the people who you should have CCed. Lemme
CC them.

$ git show 96c6b8f212a
fatal: ambiguous argument '96c6b8f212a': unknown revision or path not in the working tree.

/me greps a bit.

Ah, you've dropped the first char of the sha1 - an 'e':

$ git show e96c6b8f212a
commit e96c6b8f212a510c9b22362de519f6e1d7920de5
Author: Song Shuai <songshuaishuai@tinylab.org>
Date:   Sat Jun 24 11:26:07 2023 +0800

    memblock: report failures when memblock_can_resize is not set

...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette